{"thread":{"id":"18302","subject":"[JGIT PATCH] Fix sorting of thin packs in PackWriter","startedAt":"2009-03-13T15:45:25Z","lastAt":"2009-03-13T15:45:25Z","messageCount":1,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107957","messageId":"1236959125-3789-1-git-send-email-spearce@spearce.org","threadId":"18302","inReplyTo":null,"subject":"[JGIT PATCH] Fix sorting of thin packs in PackWriter","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-03-13T15:45:25Z","receivedAt":"2009-03-13T15:45:25Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"We must retain the TOPO and COMMIT_TIME_DESC rules when we add in\nBOUNDARY for a thin pack, otherwise the resulting thin pack won't\nmatch the expected ordering.\n\nIts a non-critical error to sort the pack wrong, but it may cause the\nclient to skip around the pack data more frequently during access.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n .../src/org/spearce/jgit/lib/PackWriter.java       |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java b/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java\nindex f9945c4..b878409 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java\n@@ -765,10 +765,10 @@ private ObjectWalk setUpWalker(\n \t\t\tthrows MissingObjectException, IOException,\n \t\t\tIncorrectObjectTypeException {\n \t\tfinal ObjectWalk walker = new ObjectWalk(db);\n-\t\twalker.sort(RevSort.TOPO, true);\n+\t\twalker.sort(RevSort.TOPO);\n \t\twalker.sort(RevSort.COMMIT_TIME_DESC, true);\n \t\tif (thin)\n-\t\t\twalker.sort(RevSort.BOUNDARY);\n+\t\t\twalker.sort(RevSort.BOUNDARY, true);\n \n \t\tfor (ObjectId id : interestingObjects) {\n \t\t\tRevObject o = walker.parseAny(id);\n-- \n1.6.2.288.gc3f22\n"}]}