{"thread":{"id":"18235","subject":"[PATCH] Append ampersand to \"Target\" of lnk files created by do_cygwin_shortcut","startedAt":"2009-03-09T22:09:49Z","lastAt":"2009-03-09T23:23:00Z","messageCount":2,"participants":["Phil Lawrence","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107511","messageId":"530ac78e0903091509y5209dec9q4c716d1e400357f3@mail.gmail.com","threadId":"18235","inReplyTo":null,"subject":"[PATCH] Append ampersand to \"Target\" of lnk files created by do_cygwin_shortcut","fromName":"Phil Lawrence","fromEmail":"prlawrence@gmail.com","sentAt":"2009-03-09T22:09:49Z","receivedAt":"2009-03-09T22:09:49Z","isPatch":true,"sender":{"key":"prlawrence@gmail.com","avatar":"https://gravatar.com/avatar/352044d06dd8919a32522c18c712e0a8d07b8e8719c820b4b50ffb8f6f2fa1f0?d=mp&s=160"},"body":"On Mon, Mar 9, 2009 at 4:12 PM, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n>\n> <snip!>\n>\n> Could you add those explanations to the commit message?\n\nDone:\n\n>From 0780db8d53bdd0bb02b154d23c3c80bcccc0d955 Mon Sep 17 00:00:00 2001\nFrom: Phil Lawrence <prlawrence@gmail.com>\nDate: Thu, 5 Mar 2009 17:56:58 -0600\nSubject: [PATCH] Append ampersand to \"Target\" of lnk files created by\ndo_cygwin_shortcut\n\nThe git-gui menu item \"Repository | Create Desktop Icon\" creates a\nshortcut (.lnk file) on the Windows desktop.  The purpose of the\ncreated shortcut is to make it easy for a user to launch git-gui\nfor a particular repo in the future.\n\nA Windows user would expect to see git gui launch when they click\nthe shortcut; they would not expect (nor want) to see a cmd window\nopen and remain open in the background.\n\nmsysGit avoids opening a command window altogether when it's Git GUI\nshortcut is used.  Ideally, git on cygwin would also have shortcuts\nthat simply open the GUI, but as a first step, this change allows\nthe shell window to politely disappear after starting git gui as a\nbackground process.\n\nSigned-off-by: Phil Lawrence <prlawrence@gmail.com>\n---\n lib/shortcut.tcl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/lib/shortcut.tcl b/lib/shortcut.tcl\nindex 38c3151..2f20eb3 100644\n--- a/lib/shortcut.tcl\n+++ b/lib/shortcut.tcl\n@@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {\n                                        $argv0]\n                                win32_create_lnk $fn [list \\\n                                        $sh -c \\\n-                                       \"CHERE_INVOKING=1 source\n/etc/profile;[sq $me]\" \\\n+                                       \"CHERE_INVOKING=1 source\n/etc/profile;[sq $me] &\" \\\n                                        ] \\\n                                        [file dirname [file normalize [gitdir]]]\n                        } err]} {\n--\n1.6.1.9.g97c34\n\nPhil Lawrence\n"},{"id":"107522","messageId":"20090309232300.GK11989@spearce.org","threadId":"18235","inReplyTo":"530ac78e0903091509y5209dec9q4c716d1e400357f3@mail.gmail.com","subject":"Re: [PATCH] Append ampersand to \"Target\" of lnk files created by do_cygwin_shortcut","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-03-09T23:23:00Z","receivedAt":"2009-03-09T23:23:00Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Phil Lawrence <prlawrence@gmail.com> wrote:\n> From 0780db8d53bdd0bb02b154d23c3c80bcccc0d955 Mon Sep 17 00:00:00 2001\n> From: Phil Lawrence <prlawrence@gmail.com>\n> Date: Thu, 5 Mar 2009 17:56:58 -0600\n> Subject: [PATCH] Append ampersand to \"Target\" of lnk files created by\n> do_cygwin_shortcut\n> \n> The git-gui menu item \"Repository | Create Desktop Icon\" creates a\n> shortcut (.lnk file) on the Windows desktop.  The purpose of the\n> created shortcut is to make it easy for a user to launch git-gui\n> for a particular repo in the future.\n\nThanks.  The patch was white space damaged, but being only 2\ncharacters it was easier for me to just redo the change than\nto ask you to resend the patch.\n \n> @@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {\n>                                         $argv0]\n>                                 win32_create_lnk $fn [list \\\n>                                         $sh -c \\\n> -                                       \"CHERE_INVOKING=1 source\n> /etc/profile;[sq $me]\" \\\n> +                                       \"CHERE_INVOKING=1 source\n> /etc/profile;[sq $me] &\" \\\n>                                         ] \\\n>                                         [file dirname [file normalize [gitdir]]]\n>                         } err]} {\n\n-- \nShawn.\n"}]}