{"thread":{"id":"18194","subject":"[PATCH, acked] git-p4: remove tabs from usermap file","startedAt":"2009-03-07T15:05:19Z","lastAt":"2009-03-07T15:05:19Z","messageCount":1,"participants":["Pete Wyckoff"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107302","messageId":"20090307150519.GA29200@padd.com","threadId":"18194","inReplyTo":null,"subject":"[PATCH, acked] git-p4: remove tabs from usermap file","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2009-03-07T15:05:19Z","receivedAt":"2009-03-07T15:05:19Z","isPatch":true,"sender":{"key":"pw@padd.com","avatar":null},"body":"Some users have tabs in their names, oddly enough.  This\ncauses problems when loading the usercache from disk,\nas split separates the fields on the wrong tabs.  When\nfast-import's parse_ident() tries to parse the committer\nfield, it is unhappy about the unbalanced <..> angle brackets.\n\nIt is easy enough to convert the tabs to single spaces.\n\nSigned-off-by: Pete Wyckoff <pw@padd.com>\nAcked-by: Simon Hausmann <simon@lst.de>\n---\n contrib/fast-import/git-p4 |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\nindex 3832f60..342529d 100755\n--- a/contrib/fast-import/git-p4\n+++ b/contrib/fast-import/git-p4\n@@ -1142,7 +1142,7 @@ class P4Sync(Command):\n \n         s = ''\n         for (key, val) in self.users.items():\n-            s += \"%s\\t%s\\n\" % (key, val)\n+\t    s += \"%s\\t%s\\n\" % (key.expandtabs(1), val.expandtabs(1))\n \n         open(self.getUserCacheFilename(), \"wb\").write(s)\n         self.userMapFromPerforceServer = True\n-- \n1.6.0.6\n"}]}