{"thread":{"id":"18174","subject":"[PATCH] [JGit] Fix parsing peeled line in packed-ref","startedAt":"2009-03-06T15:25:38Z","lastAt":"2009-03-06T15:43:09Z","messageCount":2,"participants":["Daniel Cheng (aka SDiZ)","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107207","messageId":"1236353138-1427-1-git-send-email-j16sdiz+freenet@sdiz.net","threadId":"18174","inReplyTo":null,"subject":"[PATCH] [JGit] Fix parsing peeled line in packed-ref","fromName":"Daniel Cheng (aka SDiZ)","fromEmail":"j16sdiz+freenet@gmail.com","sentAt":"2009-03-06T15:25:38Z","receivedAt":"2009-03-06T15:25:38Z","isPatch":true,"sender":{"key":"j16sdiz+freenet@gmail.com","avatar":"https://gravatar.com/avatar/3e796e8a156ee86e305bfc1fbe01608302554ee3b5fa7eb8d1213b8877bfcabd?d=mp&s=160"},"body":"When doing a WalkTransport with packed-ref, peeled\nline are not handled correctly. This patch fix the\nissue.\n---\n .../jgit/transport/WalkRemoteObjectDatabase.java   |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\nindex a4f8961..d8e727b 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\n@@ -436,7 +436,7 @@ private void readPackedRefsImpl(final Map<String, Ref> avail,\n \t\t\tif (line.charAt(0) == '^') {\n \t\t\t\tif (last == null)\n \t\t\t\t\tthrow new TransportException(\"Peeled line before ref.\");\n-\t\t\t\tfinal ObjectId id = ObjectId.fromString(line + 1);\n+\t\t\t\tfinal ObjectId id = ObjectId.fromString(line.substring(1));\n \t\t\t\tlast = new Ref(Ref.Storage.PACKED, last.getName(), last\n \t\t\t\t\t\t.getObjectId(), id, true);\n \t\t\t\tavail.put(last.getName(), last);\n-- \n1.6.2.rc2\n"},{"id":"107212","messageId":"20090306154309.GF16213@spearce.org","threadId":"18174","inReplyTo":"1236353138-1427-1-git-send-email-j16sdiz+freenet@sdiz.net","subject":"Re: [PATCH] [JGit] Fix parsing peeled line in packed-ref","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-03-06T15:43:09Z","receivedAt":"2009-03-06T15:43:09Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"Daniel Cheng (aka SDiZ)\" <j16sdiz+freenet@gmail.com> wrote:\n> When doing a WalkTransport with packed-ref, peeled\n> line are not handled correctly. This patch fix the\n> issue.\n\nWow.  That old code was really wrong.  :-)\n\nSigned-off-by?  (See SUBMITTING_PATCHES, \"(5) Sign your work\")\n\n> diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\n> index a4f8961..d8e727b 100644\n> --- a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\n> +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java\n> @@ -436,7 +436,7 @@ private void readPackedRefsImpl(final Map<String, Ref> avail,\n>  \t\t\tif (line.charAt(0) == '^') {\n>  \t\t\t\tif (last == null)\n>  \t\t\t\t\tthrow new TransportException(\"Peeled line before ref.\");\n> -\t\t\t\tfinal ObjectId id = ObjectId.fromString(line + 1);\n> +\t\t\t\tfinal ObjectId id = ObjectId.fromString(line.substring(1));\n>  \t\t\t\tlast = new Ref(Ref.Storage.PACKED, last.getName(), last\n\nIf I'm at fault for that preimage, I should just be put out to\npasture now... before I do any more harm... *sigh*\n\n-- \nShawn.\n"}]}