{"thread":{"id":"18149","subject":"[PATCH] Documentation - More examples for git bisect","startedAt":"2009-03-05T12:36:14Z","lastAt":"2009-03-06T07:46:24Z","messageCount":4,"participants":["John Tapsell","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107065","messageId":"1236256574-24764-1-git-send-email-johnflux@gmail.com","threadId":"18149","inReplyTo":null,"subject":"[PATCH] Documentation - More examples for git bisect","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-03-05T12:36:14Z","receivedAt":"2009-03-05T12:36:14Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"Including passing parameters to the programs, and running more\ncomplicated checks without requiring a seperate shell script.\n\nSigned-off-by: John Tapsell\n---\n Documentation/git-bisect.txt |   18 +++++++++++++++++-\n 1 files changed, 17 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex 147ea38..e65c1ca 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -212,7 +212,7 @@ If you have a script that can tell if the current source code is good\n or bad, you can automatically bisect using:\n \n ------------\n-$ git bisect run my_script\n+$ git bisect run my_script arguments\n ------------\n \n Note that the \"run\" script (`my_script` in the above example) should\n@@ -252,6 +252,13 @@ $ git bisect start HEAD v1.2 --      # HEAD is bad, v1.2 is good\n $ git bisect run make                # \"make\" builds the app\n ------------\n \n+* Automatically bisect a test failure between origin and HEAD:\n++\n+------------\n+$ git bisect start HEAD origin --    # HEAD is bad, origin is good\n+$ git bisect run make test           # \"make test\" builds and tests\n+------------\n+\n * Automatically bisect a broken test suite:\n +\n ------------\n@@ -291,6 +298,15 @@ It's safer if both \"test.sh\" and \"check_test_case.sh\" scripts are\n outside the repo to prevent interactions between the bisect, make and\n test processes and the scripts.\n \n+* Automatically bisect a broken test suite:\n++\n+------------\n+$ git bisect start HEAD HEAD~10 --   # culprit is among the last 10\n+$ git bisect run sh -c \"make || exit 125; ~/check_test_case.sh\"\n+------------\n++\n+Does the same as the previous example, but on a single line.\n+\n Author\n ------\n Written by Linus Torvalds <torvalds@osdl.org>\n-- \n1.6.2.97.g1bcd6.dirty\n"},{"id":"107109","messageId":"200903052244.35702.chriscool@tuxfamily.org","threadId":"18149","inReplyTo":"1236256574-24764-1-git-send-email-johnflux@gmail.com","subject":"Re: [PATCH] Documentation - More examples for git bisect","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-03-05T21:44:35Z","receivedAt":"2009-03-05T21:44:35Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le jeudi 5 mars 2009, John Tapsell a écrit :\n> Including passing parameters to the programs, and running more\n> complicated checks without requiring a seperate shell script.\n>\n> Signed-off-by: John Tapsell\n\nThat looks good to me, except perhaps that your signed-off-by has no email \naddress, but I don't know if it's a problem or not.\n\nAcked-by: Christian Couder <chriscool@tuxfamily.org>\n\nThanks,\nChristian.\n"},{"id":"107131","messageId":"43d8ce650903051850o49f94398re09bb2bab793e925@mail.gmail.com","threadId":"18149","inReplyTo":"200903052244.35702.chriscool@tuxfamily.org","subject":"Re: [PATCH] Documentation - More examples for git bisect","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-03-06T02:50:49Z","receivedAt":"2009-03-06T02:50:49Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"2009/3/5 Christian Couder <chriscool@tuxfamily.org>:\n> Le jeudi 5 mars 2009, John Tapsell a écrit :\n>> Including passing parameters to the programs, and running more\n>> complicated checks without requiring a seperate shell script.\n>>\n>> Signed-off-by: John Tapsell\n>\n> That looks good to me, except perhaps that your signed-off-by has no email\n> address, but I don't know if it's a problem or not.\n\nOpps.  Signed-off-by: John Tapsell <johnflux@gmail.com>\n\n>\n> Acked-by: Christian Couder <chriscool@tuxfamily.org>\n>\n> Thanks,\n> Christian.\n>\n"},{"id":"107158","messageId":"200903060846.25151.chriscool@tuxfamily.org","threadId":"18149","inReplyTo":"1236256574-24764-1-git-send-email-johnflux@gmail.com","subject":"Re: [PATCH] Documentation - More examples for git bisect","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-03-06T07:46:24Z","receivedAt":"2009-03-06T07:46:24Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On a second look here are a few nit picks.\n\nFirst the patch title could be:\n\n\"Documentation: More examples for git bisect\"\n\ninstead of:\n\n\"Documentation - More examples for git bisect\"\n\nas it would be more consistent with other patches.\n\nLe jeudi 5 mars 2009, John Tapsell a écrit :\n> Including passing parameters to the programs, and running more\n> complicated checks without requiring a seperate shell script.\n>\n> Signed-off-by: John Tapsell\n> ---\n>  Documentation/git-bisect.txt |   18 +++++++++++++++++-\n>  1 files changed, 17 insertions(+), 1 deletions(-)\n>\n> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\n> index 147ea38..e65c1ca 100644\n> --- a/Documentation/git-bisect.txt\n> +++ b/Documentation/git-bisect.txt\n> @@ -212,7 +212,7 @@ If you have a script that can tell if the current\n> source code is good or bad, you can automatically bisect using:\n>\n>  ------------\n> -$ git bisect run my_script\n> +$ git bisect run my_script arguments\n>  ------------\n>\n>  Note that the \"run\" script (`my_script` in the above example) should\n> @@ -252,6 +252,13 @@ $ git bisect start HEAD v1.2 --      # HEAD is bad,\n> v1.2 is good $ git bisect run make                # \"make\" builds the app\n>  ------------\n>\n> +* Automatically bisect a test failure between origin and HEAD:\n> ++\n> +------------\n> +$ git bisect start HEAD origin --    # HEAD is bad, origin is good\n> +$ git bisect run make test           # \"make test\" builds and tests\n> +------------\n\nPerhaps we should add that the above may not work well if there are some \ncommits that don't build. And that it is fixed in the example below this \none.\n\n>  * Automatically bisect a broken test suite:\n>  +\n>  ------------\n> @@ -291,6 +298,15 @@ It's safer if both \"test.sh\" and\n> \"check_test_case.sh\" scripts are outside the repo to prevent interactions\n> between the bisect, make and test processes and the scripts.\n>\n> +* Automatically bisect a broken test suite:\n\nThe title of the previous example is \n\n* Automatically bisect a broken test case:\n\nso if it is the same, then it should perhaps have the same title or perhaps:\n\n* Automatically bisect a broken test case simplified:\n\nor something like that.\n\n> ++\n> +------------\n> +$ git bisect start HEAD HEAD~10 --   # culprit is among the last 10\n> +$ git bisect run sh -c \"make || exit 125; ~/check_test_case.sh\"\n> +------------\n> ++\n> +Does the same as the previous example, but on a single line.\n> +\n\nThanks,\nChristian.\n"}]}