{"thread":{"id":"18131","subject":"[PATCH] allow guilt to handle binary files","startedAt":"2009-03-04T14:19:32Z","lastAt":"2009-03-12T00:47:39Z","messageCount":2,"participants":["Yasushi SHOJI","Josef 'Jeff' Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"106983","messageId":"87vdqpuzj5.wl@mail2.atmark-techno.com","threadId":"18131","inReplyTo":null,"subject":"[PATCH] allow guilt to handle binary files","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2009-03-04T14:19:32Z","receivedAt":"2009-03-04T14:19:32Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"git plumbings has been working with binary diff for a while.  this one\nliner enable guilt to use those capabilities.\n\nSigned-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\n---\nHi Jeff,\n\nI just found out that guilt does not yet support binary patch\ncapability git has for a while.\n\nso, before I leave my office, I just tried guilt with this one liner.\nthe result was:\n\n - my local test with biniary files work (pop/push was check with md5), and\n - all regression test completed without any error\n\nI felt that I just send it out. :-) \n\n# Note: I've googled \"guilt bianry\" before sending this but could not\n# find any.  I'm not following nether git nor guilt development for a\n# while. so, let me know if I'm off track.\n\nthanks,\n\n guilt |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/guilt b/guilt\nindex c98fd30..17a6288 100755\n--- a/guilt\n+++ b/guilt\n@@ -689,7 +689,7 @@ __refresh_patch()\n \t\tfi\n \n \t\t# get the new patch\n-\t\tgit diff $diffopts \"$2\" >> \"$TMP_DIFF\"\n+\t\tgit diff --binary $diffopts \"$2\" >> \"$TMP_DIFF\"\n \n \t\t# move the new patch in\n \t\tmv \"$p\" \"$p~\"\n-- \n1.6.1.rc3.51.g5832d\n"},{"id":"107752","messageId":"20090312004739.GM13088@josefsipek.net","threadId":"18131","inReplyTo":"87vdqpuzj5.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] allow guilt to handle binary files","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2009-03-12T00:47:39Z","receivedAt":"2009-03-12T00:47:39Z","isPatch":true,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Wed, Mar 04, 2009 at 11:19:32PM +0900, Yasushi SHOJI wrote:\n> git plumbings has been working with binary diff for a while.  this one\n> liner enable guilt to use those capabilities.\n> \n> Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\n> ---\n> Hi Jeff,\n> \n> I just found out that guilt does not yet support binary patch\n> capability git has for a while.\n> \n> so, before I leave my office, I just tried guilt with this one liner.\n> the result was:\n> \n>  - my local test with biniary files work (pop/push was check with md5), and\n>  - all regression test completed without any error\n> \n> I felt that I just send it out. :-) \n\nThat's how it works :)\n\n> # Note: I've googled \"guilt bianry\" before sending this but could not\n> # find any.  I'm not following nether git nor guilt development for a\n> # while. so, let me know if I'm off track.\n\nSorry for taking so long...the patch looks fine. I applied it & pushed it\nout.\n\nI think it would be a good idea to have a regression test that specifically\nchecks binary file handling. I'm not going to get to write it for a couple\nof days at least, so feel free to give it a shot :)\n\nThanks!\n\nJosef 'Jeff' Sipek.\n\n-- \nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like\nthat.\n\t\t- Linus Torvalds\n"}]}