{"thread":{"id":"18130","subject":"[PATCH] Make the 'lock file' exists error more informative","startedAt":"2009-03-04T15:00:44Z","lastAt":"2009-03-04T15:03:13Z","messageCount":2,"participants":["John Tapsell"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"106981","messageId":"1236178844-7958-1-git-send-email-johnflux@gmail.com","threadId":"18130","inReplyTo":null,"subject":"[PATCH] Make the 'lock file' exists error more informative","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-03-04T15:00:44Z","receivedAt":"2009-03-04T15:00:44Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"It looks like someone did 90% of the work, then forgot to actually use\nthe function\n---\n lockfile.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/lockfile.c b/lockfile.c\nindex 1db1a2f..6772f38 100644\n--- a/lockfile.c\n+++ b/lockfile.c\n@@ -184,7 +184,7 @@ int hold_lock_file_for_append(struct lock_file *lk, const char *path, int flags)\n \tfd = lock_file(lk, path, flags);\n \tif (fd < 0) {\n \t\tif (flags & LOCK_DIE_ON_ERROR)\n-\t\t\tdie(\"unable to create '%s.lock': %s\", path, strerror(errno));\n+\t\t\tunable_to_lock_index_die(path, strerror(errno));\n \t\treturn fd;\n \t}\n \n-- \n1.6.2.rc1.3.g7d31b.dirty\n"},{"id":"106982","messageId":"43d8ce650903040703v2a743797rc30724f8c1c608e7@mail.gmail.com","threadId":"18130","inReplyTo":"1236178844-7958-1-git-send-email-johnflux@gmail.com","subject":"Re: [PATCH] Make the 'lock file' exists error more informative","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-03-04T15:03:13Z","receivedAt":"2009-03-04T15:03:13Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"Argh, I'm so sorry.  After all that, I went and sent a broken version.\n Plus I just noticed another bug.  Will retry..\n\n\n2009/3/4 John Tapsell <johnflux@gmail.com>:\n> It looks like someone did 90% of the work, then forgot to actually use\n> the function\n> ---\n>  lockfile.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/lockfile.c b/lockfile.c\n> index 1db1a2f..6772f38 100644\n> --- a/lockfile.c\n> +++ b/lockfile.c\n> @@ -184,7 +184,7 @@ int hold_lock_file_for_append(struct lock_file *lk, const char *path, int flags)\n>        fd = lock_file(lk, path, flags);\n>        if (fd < 0) {\n>                if (flags & LOCK_DIE_ON_ERROR)\n> -                       die(\"unable to create '%s.lock': %s\", path, strerror(errno));\n> +                       unable_to_lock_index_die(path, strerror(errno));\n>                return fd;\n>        }\n>\n> --\n> 1.6.2.rc1.3.g7d31b.dirty\n>\n>\n"}]}