{"thread":{"id":"18053","subject":"[PATCH] autoconf: Add support for --infodir","startedAt":"2009-02-28T00:33:29Z","lastAt":"2009-02-28T01:57:55Z","messageCount":4,"participants":["Jakub Narebski","David Syzdek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"106490","messageId":"20090228002550.22597.53878.stgit@localhost.localdomain","threadId":"18053","inReplyTo":"tim.visher@gmail.com","subject":"[PATCH] autoconf: Add support for --infodir","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-02-28T00:33:29Z","receivedAt":"2009-02-28T00:33:29Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 26 Feb 2009, Jeff King wrote:\n> On Thu, Feb 26, 2009 at 09:48:29AM -0500, Tim Visher wrote:\n> \n>> I'm working on getting git 1.6.2-rc2 built.  I have a bin, man, info,\n>> and html directory in my home folder that I'd like to use as the\n>> defaults for git.  I attempted to do this through\n>> \n>>     make configure\n>>     ./configure --XXdir=/full/path/to/dir\n>>     make all man info html\n>>     make install install-man install-info install-html\n>> \n>> But other than the binaries (and I'm not even totally convinced they\n>> got in correctly) and the man pages, everything else seems to be\n>> attempting to go to the typical places in /usr/local.\n>> \n>> What am I doing wrong?\n\nWhy don't you use simply --prefix=DIR?\n\n> \n> The configure support is notoriously incomplete (AFAIK, very few of the\n> active developers use it regularly). Probably you need something like\n> this (but I didn't test it):\n> \n> diff --git a/config.mak.in b/config.mak.in\n> index 7cce0c1..505d5c7 100644\n> --- a/config.mak.in\n> +++ b/config.mak.in\n> @@ -18,6 +18,8 @@ datarootdir = @datarootdir@\n>  template_dir = @datadir@/git-core/templates\n>  \n>  mandir=@mandir@\n> +htmldir=@htmldir@\n> +infodir=@infodir@\n>  \n>  srcdir = @srcdir@\n>  VPATH = @srcdir@\n\nWell, the infodir part works trivially, because autoconf (and\ntherefore ./configure script) has support for --infodir=DIR.\nBelow there is patch that adds that, with the commit message.\n\nBut it is more difficult with respect to --htmldir. I am not autoconf\nhacker, so I don't know how to add support for having --htmldir=DIR in\n./configure (in configure.ac).  What can be done is to derive htmldir\nin config.mak.in from other sources, for example:\n\n  htmldir=@datadir@/doc/git\n\nor something like that.\n\n-- >8 --\nNow that we actually (can) install some info files, and that $infodir\nis set and used in Makefile(s), let add support for --infodir=DIR\n[PREFIX/info] ./configure option in config.mak.in.\n\nHalf of patch by Jeff King <peff@peff.net>m adding --XXdir support \n(the easy part: autoconf has --infodir, but not --htmldir).\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n config.mak.in |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex 7cce0c1..acff9ed 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -18,6 +18,7 @@ datarootdir = @datarootdir@\n template_dir = @datadir@/git-core/templates\n \n mandir=@mandir@\n+infodir=@infodir@\n \n srcdir = @srcdir@\n VPATH = @srcdir@\n"},{"id":"106492","messageId":"m3d4d3v195.fsf@localhost.localdomain","threadId":"18053","inReplyTo":"20090228002550.22597.53878.stgit@localhost.localdomain","subject":"Re: [PATCH] autoconf: Add support for --infodir","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-02-28T00:45:06Z","receivedAt":"2009-02-28T00:45:06Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Gaah, this was meant to be reply to message by Peff\nMessage-ID: <20090226150013.GA9785@coredump.intra.peff.net>\nin the \"`./configure --XXdir=` ignored?\" thread, but I mis-pasted\nreply-to id.\n\nJakub Narebski <jnareb@gmail.com> writes:\n> -- >8 --\n> Now that we actually (can) install some info files, and that $infodir\n> is set and used in Makefile(s), let add support for --infodir=DIR\n> [PREFIX/info] ./configure option in config.mak.in.\n> \n> Half of patch by Jeff King <peff@peff.net>m adding --XXdir support \n\nThat was of course meant to be s/>m/>,/\n\nHalf of patch by Jeff King <peff@peff.net>, adding --XXdir support \n\n[...]\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"106496","messageId":"9a0027270902271715w3f72e01dp4e1e3a716b92527c@mail.gmail.com","threadId":"18053","inReplyTo":"20090228002550.22597.53878.stgit@localhost.localdomain","subject":"Re: [PATCH] autoconf: Add support for --infodir","fromName":"David Syzdek","fromEmail":"syzdek@gmail.com","sentAt":"2009-02-28T01:15:21Z","receivedAt":"2009-02-28T01:15:21Z","isPatch":true,"sender":{"key":"syzdek@gmail.com","avatar":"https://gravatar.com/avatar/7f7b4df7a7d9be0b968c23c9fb9281953356e59ddb5d6dd8f02a6ddf3d9d9d22?d=mp&s=160"},"body":"On Fri, Feb 27, 2009 at 3:33 PM, Jakub Narebski <jnareb@gmail.com> wrote:\n>\n> On Thu, 26 Feb 2009, Jeff King wrote:\n> > On Thu, Feb 26, 2009 at 09:48:29AM -0500, Tim Visher wrote:\n> >\n> >> I'm working on getting git 1.6.2-rc2 built.  I have a bin, man, info,\n> >> and html directory in my home folder that I'd like to use as the\n> >> defaults for git.  I attempted to do this through\n> >>\n> >>     make configure\n> >>     ./configure --XXdir=/full/path/to/dir\n> >>     make all man info html\n> >>     make install install-man install-info install-html\n> >>\n> >> But other than the binaries (and I'm not even totally convinced they\n> >> got in correctly) and the man pages, everything else seems to be\n> >> attempting to go to the typical places in /usr/local.\n> >>\n> >> What am I doing wrong?\n>\n> Why don't you use simply --prefix=DIR?\n>\n> >\n> > The configure support is notoriously incomplete (AFAIK, very few of the\n> > active developers use it regularly). Probably you need something like\n> > this (but I didn't test it):\n> >\n> > diff --git a/config.mak.in b/config.mak.in\n> > index 7cce0c1..505d5c7 100644\n> > --- a/config.mak.in\n> > +++ b/config.mak.in\n> > @@ -18,6 +18,8 @@ datarootdir = @datarootdir@\n> >  template_dir = @datadir@/git-core/templates\n> >\n> >  mandir=@mandir@\n> > +htmldir=@htmldir@\n> > +infodir=@infodir@\n> >\n> >  srcdir = @srcdir@\n> >  VPATH = @srcdir@\n>\n> Well, the infodir part works trivially, because autoconf (and\n> therefore ./configure script) has support for --infodir=DIR.\n> Below there is patch that adds that, with the commit message.\n>\n> But it is more difficult with respect to --htmldir. I am not autoconf\n> hacker, so I don't know how to add support for having --htmldir=DIR in\n> ./configure (in configure.ac).  What can be done is to derive htmldir\n> in config.mak.in from other sources, for example:\n>\n\nAutoconf add support for --htmldir in version 2.60.  Here is a snippet\nfrom the help message from a configure script generated with 2.60:\n   --datarootdir=DIR       read-only arch.-independent data root [PREFIX/share]\n   --docdir=DIR            documentation root [DATAROOTDIR/doc/PROJECT_TARNAME]\n   --htmldir=DIR           html documentation [DOCDIR]\n\nThe current configure.ac requires autoconf version >= 2.59, bumping\nthe requirement to autoconf >= 2.60 would allow the autoconf variable\n$(htmldir) to be used.  Bumping the required version of autoconf will\naffect users with older linux installations who use git to upgrade\ngit; and may affect the maintainer's ability to create a \"release\"\ntarball if he has an older version of autoconf.\n\n>  htmldir=@datadir@/doc/git\n>\n> or something like that.\n>\n> -- >8 --\n> Now that we actually (can) install some info files, and that $infodir\n> is set and used in Makefile(s), let add support for --infodir=DIR\n> [PREFIX/info] ./configure option in config.mak.in.\n>\n> Half of patch by Jeff King <peff@peff.net>m adding --XXdir support\n> (the easy part: autoconf has --infodir, but not --htmldir).\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n>  config.mak.in |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/config.mak.in b/config.mak.in\n> index 7cce0c1..acff9ed 100644\n> --- a/config.mak.in\n> +++ b/config.mak.in\n> @@ -18,6 +18,7 @@ datarootdir = @datarootdir@\n>  template_dir = @datadir@/git-core/templates\n>\n>  mandir=@mandir@\n> +infodir=@infodir@\n>\n>  srcdir = @srcdir@\n>  VPATH = @srcdir@\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n\n\n\n--\nAn earthquake wiped out Etchisketchistan today.\n  -- Onion TV\n"},{"id":"106500","messageId":"200902280257.56932.jnareb@gmail.com","threadId":"18053","inReplyTo":"9a0027270902271712y57839e22w492f7ad46baf49b@mail.gmail.com","subject":"Re: [PATCH] autoconf: Add support for --infodir","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-02-28T01:57:55Z","receivedAt":"2009-02-28T01:57:55Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sat, 28 Feb 2009, David Syzdek wrote:\n> On Fri, Feb 27, 2009 at 3:33 PM, Jakub Narebski <jnareb@gmail.com> wrote:\n>> On Thu, 26 Feb 2009, Jeff King wrote:\n>>> On Thu, Feb 26, 2009 at 09:48:29AM -0500, Tim Visher wrote:\n>>>\n>>>> I'm working on getting git 1.6.2-rc2 built.  I have a bin, man, info,\n>>>> and html directory in my home folder that I'd like to use as the\n>>>> defaults for git.  I attempted to do this through\n>>>>\n>>>>     make configure\n>>>>     ./configure --XXdir=/full/path/to/dir\n>>>>     make all man info html\n>>>>     make install install-man install-info install-html\n[...]\n\n>>> The configure support is notoriously incomplete (AFAIK, very few of the\n>>> active developers use it regularly). Probably you need something like\n>>> this (but I didn't test it):\n>>>\n>>> diff --git a/config.mak.in b/config.mak.in\n>>> index 7cce0c1..505d5c7 100644\n>>> --- a/config.mak.in\n>>> +++ b/config.mak.in\n>>> @@ -18,6 +18,8 @@ datarootdir = @datarootdir@\n>>>  template_dir = @datadir@/git-core/templates\n>>>\n>>>  mandir=@mandir@\n>>> +htmldir=@htmldir@\n>>> +infodir=@infodir@\n>>>\n>>>  srcdir = @srcdir@\n>>>  VPATH = @srcdir@\n>>\n>> Well, the infodir part works trivially, because autoconf (and\n>> therefore ./configure script) has support for --infodir=DIR.\n>> Below there is patch that adds that, with the commit message.\n>>\n>> But it is more difficult with respect to --htmldir. I am not autoconf\n>> hacker, so I don't know how to add support for having --htmldir=DIR in\n>> ./configure (in configure.ac).  What can be done is to derive htmldir\n>> in config.mak.in from other sources, for example:\n> \n> Autoconf add support for --htmldir in version 2.60.  Here is a snippet from\n> the help message from a configure script generated with 2.60:\n> \n> --datarootdir=DIR       read-only arch.-independent data root [PREFIX/share]\n> \n> --docdir=DIR            documentation root [DATAROOTDIR/doc/PROJECT_TARNAME]\n> \n> --htmldir=DIR           html documentation [DOCDIR]\n> \n> \n> The current configure.ac requires autoconf version>= 2.59, bumping the\n> requirement to autoconf>= 2.60 would allow the autoconf variable $(htmldir)\n> to be used.  Bumping the required version of autoconf will affect users with\n> older linux installations who use git to upgrade git; and may affect the\n> maintainer's ability to create a \"release\" tarball if he has an older\n> version of autoconf.\n\nWell, I have autoconf 2.59, so I cannot test the following patch\n(and I am not sure if it is welcome). And of course it needs commit\nmessage, at least with explanation why bumping required version of\nautoconf was needed.\n\n-- >8 --\ndiff --git a/config.mak.in b/config.mak.in\nindex acff9ed..56a0147 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates\n \n mandir=@mandir@\n infodir=@infodir@\n+htmldir=@htmldir@\n \n srcdir = @srcdir@\n VPATH = @srcdir@\ndiff --git a/configure.ac b/configure.ac\nindex 082a03d..b1ab0e1 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -1,7 +1,7 @@\n #                                               -*- Autoconf -*-\n # Process this file with autoconf to produce a configure script.\n \n-AC_PREREQ(2.59)\n+AC_PREREQ(2.60)\n AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])\n \n AC_CONFIG_SRCDIR([git.c])\n\n-- \nJakub Narebski\nPoland\n"}]}