{"thread":{"id":"18046","subject":"git-1.6.2-rc2 problems on t4034-diff-words.sh","startedAt":"2009-02-27T18:06:29Z","lastAt":"2009-02-27T20:49:10Z","messageCount":7,"participants":["Boyd Lynn Gerber","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"106453","messageId":"alpine.LNX.2.00.0902271103450.19082@suse104.zenez.com","threadId":"18046","inReplyTo":null,"subject":"git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2009-02-27T18:06:29Z","receivedAt":"2009-02-27T18:06:29Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"Hello,\n\nI just download and started to test this on SCO OpenServer 6.0.mp4\n\nThey just released a new Maintianence Patch for the OS. This is what I \nget while running gmake test.\n\n*** t4034-diff-words.sh ***\n* ok 1: setup\n* ok 2: word diff with runs of whitespace\n* ok 3: word diff with a regular expression\n* ok 4: set a diff driver\n* ok 5: option overrides .gitattributes\n* FAIL 6: use regex supplied by driver\n\n\n word_diff --color-words\n\n\n* ok 7: set diff.wordRegex option\n* ok 8: command-line overrides config\n* FAIL 9: .gitattributes override config\n\n word_diff --color-words\n\n* ok 10: remove diff driver regex\n* ok 11: use configured regex\n* FAIL 12: test parsing words for newline\n\n\n word_diff --color-words=\"a+\"\n\n\n\n* FAIL 13: test when words are only removed at the end\n\n\n word_diff --color-words=.\n\n\n* failed 4 among 13 test(s)\ngmake[2]: *** [t4034-diff-words.sh] Error 1\n\n\n-- \nBoyd Gerber 801 849-0213\nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"106455","messageId":"alpine.DEB.1.00.0902271936090.6600@intel-tinevez-2-302","threadId":"18046","inReplyTo":"alpine.LNX.2.00.0902271103450.19082@suse104.zenez.com","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-27T18:38:48Z","receivedAt":"2009-02-27T18:38:48Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:\n\n> I just download and started to test this on SCO OpenServer 6.0.mp4\n\nOh wow. SCO...\n\nBut as I did not forget your kind words, I'll try to help.\n\n> * FAIL 6: use regex supplied by driver\n> \n> \n> word_diff --color-words\n\nIt might be a regex related issue. Could you\n\n- run the test with -i -v (and if that does not help, \"sh -x t...\")?\n\n- try with \"make COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o\"?\n\nThanks,\nDscho\n"},{"id":"106462","messageId":"alpine.LNX.2.00.0902271216090.19082@suse104.zenez.com","threadId":"18046","inReplyTo":"alpine.DEB.1.00.0902271936090.6600@intel-tinevez-2-302","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2009-02-27T19:24:49Z","receivedAt":"2009-02-27T19:24:49Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"Thanks for your assistence. I try to test each version before release. \nSo I want to make sure no changes have broken things.\n\nOn Fri, 27 Feb 2009, Johannes Schindelin wrote:\n> On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:\n>> I just download and started to test this on SCO OpenServer 6.0.mp4\n>\n> Oh wow. SCO...\n\nYes, I still have to support some SCO OS's. I use git on all my OS's. So \nI want to make sure it works on all of them.\n\n> But as I did not forget your kind words, I'll try to help.\n>\n>> * FAIL 6: use regex supplied by driver\n>>\n>>\n>> word_diff --color-words\n\nDoes the test suite use bash as it's shell? I seem to have to use bash \nnow to run the test. I do not remember having to use bash on earlier \n1.6.0\n\n> It might be a regex related issue. Could you\n>\n> - run the test with -i -v (and if that does not help, \"sh -x t...\")?\n\nI have to use bash to run the test or I get\n\n$ ./t4034-diff-words.sh\n./t4034-diff-words.sh: syntax error at line 52: `(' unexpected\n\nBut if I run\n\n$ bash ./t4034-diff-words.sh\n* ok 1: setup\n* ok 2: word diff with runs of whitespace\n* ok 3: word diff with a regular expression\n* ok 4: set a diff driver\n* ok 5: option overrides .gitattributes\n* FAIL 6: use regex supplied by driver\n\n\n word_diff --color-words\n\n\n* ok 7: set diff.wordRegex option\n* ok 8: command-line overrides config\n* FAIL 9: .gitattributes override config\n\n word_diff --color-words\n\n* ok 10: remove diff driver regex\n* ok 11: use configured regex\n* FAIL 12: test parsing words for newline\n\n\n word_diff --color-words=\"a+\"\n\n\n\n* FAIL 13: test when words are only removed at the end\n\n\n word_diff --color-words=.\n\n\n* failed 4 among 13 test(s)\n$ bash ./t4034-diff-words.sh -i -v\nInitialized empty Git repository in /tmp/git-1.6.2.rc2/t/trash \ndirectory.t4034-diff-words/.git/\n* expecting success:\n\n git config diff.color.old red\n git config diff.color.new green\n\n\n* ok 1: setup\n\n* expecting success:\n\n word_diff --color-words\n\n\n* ok 2: word diff with runs of whitespace\n\n* expecting success:\n\n word_diff --color-words=\"[a-z]+\"\n\n\n* ok 3: word diff with a regular expression\n\n* expecting success:\n git config diff.testdriver.wordRegex \"[^[:space:]]\" &&\n cat < .gitattributes\npre diff=testdriver\npost diff=testdriver\nEOF\n\n* ok 4: set a diff driver\n\n* expecting success:\n\n word_diff --color-words=\"[a-z]+\"\n\n\n* ok 5: option overrides .gitattributes\n\n* expecting success:\n\n word_diff --color-words\n\n\nBinary files expect and output.decrypted differ\n* FAIL 6: use regex supplied by driver\n\n\n word_diff --color-words\n\n\n\n\nBinary files expect and output.decrypted differ\n* FAIL 6: use regex supplied by driver\n\n\n word_diff --color-words\n\n>\n> - try with \"make COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o\"?\n\n$ gmake COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o\n CC compat/regex/regex.o\n AR libgit.a\n LINK git-fast-import\nUndefined first referenced\nsymbol in file\ngit_fopen fast-import.o\ngit_vsnprintf fast-import.o\ngit_snprintf fast-import.o\nUX:ld: ERROR: Symbol referencing errors. No output written to \ngit-fast-import\ngmake: *** [git-fast-import] Error 1\n\n-- \nBoyd Gerber 801 849-0213\nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"106466","messageId":"alpine.DEB.1.00.0902272041510.6600@intel-tinevez-2-302","threadId":"18046","inReplyTo":"alpine.LNX.2.00.0902271216090.19082@suse104.zenez.com","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-27T19:43:49Z","receivedAt":"2009-02-27T19:43:49Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:\n\n> On Fri, 27 Feb 2009, Johannes Schindelin wrote:\n> \n> > But as I did not forget your kind words, I'll try to help.\n> >\n> > > * FAIL 6: use regex supplied by driver\n> > >\n> > >\n> > > word_diff --color-words\n> \n> Does the test suite use bash as it's shell? I seem to have to use bash \n> now to run the test. I do not remember having to use bash on earlier \n> 1.6.0\n\nNo, bash should not be required.\n\n> > It might be a regex related issue. Could you\n> >\n> > - run the test with -i -v (and if that does not help, \"sh -x t...\")?\n> \n> I have to use bash to run the test or I get\n> \n> $ ./t4034-diff-words.sh\n> ./t4034-diff-words.sh: syntax error at line 52: `(' unexpected\n\nCould you tell me what your version of t4034 has at line 52? Mine does \nnot have a single parenthesis on that line.\n\n> But if I run\n> \n> $ bash ./t4034-diff-words.sh\n> * ok 1: setup\n> * ok 2: word diff with runs of whitespace\n> * ok 3: word diff with a regular expression\n> * ok 4: set a diff driver\n> * ok 5: option overrides .gitattributes\n> * FAIL 6: use regex supplied by driver\n> \n> \n> word_diff --color-words\n\nCould you run it again after appending \"-i -v\" to the command line?\n\nCiao,\nDscho\n"},{"id":"106470","messageId":"7vwsbbir1j.fsf@gitster.siamese.dyndns.org","threadId":"18046","inReplyTo":"alpine.LNX.2.00.0902271216090.19082@suse104.zenez.com","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-27T20:05:44Z","receivedAt":"2009-02-27T20:05:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Boyd Lynn Gerber writes:\n\n> Does the test suite use bash as it's shell? I seem to have to use\n> bash now to run the test. I do not remember having to use bash on\n> earlier 1.6.0\n\nIf your /bin/sh is not POSIX enough, you may be using a different shell\nwhen building the scripted commands in the main Makefile by setting\nSHELL_PATH. The tests are supposed to use the same one as that.\n\n> I have to use bash to run the test or I get\n>\n> $ ./t4034-diff-words.sh\n> ./t4034-diff-words.sh: syntax error at line 52: `(' unexpected\n\nThe open parenthesis on line 52 is the one between h and 4 here:\n\n cat > expect <<\\EOF\n diff --git a/pre b/post\n index 330b04f..5ed8eff 100644\n --- a/pre\n +++ b/post\n @@ -1,3 +1,7 @@\n h(4)h(4),hh[44]\n \n a = b + c\n\n aa = a\n\n aeff = aeff * ( aaa )\n EOF\n\nPerhaps your shell has a broken here-text?\n"},{"id":"106473","messageId":"alpine.LNX.2.00.0902271341440.19082@suse104.zenez.com","threadId":"18046","inReplyTo":"7vwsbbir1j.fsf@gitster.siamese.dyndns.org","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2009-02-27T20:44:03Z","receivedAt":"2009-02-27T20:44:03Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 27 Feb 2009, Junio C Hamano wrote:\n> Boyd Lynn Gerber writes:\n>> Does the test suite use bash as it's shell? I seem to have to use\n>> bash now to run the test. I do not remember having to use bash on\n>> earlier 1.6.0\n>\n> If your /bin/sh is not POSIX enough, you may be using a different shell\n> when building the scripted commands in the main Makefile by setting\n> SHELL_PATH. The tests are supposed to use the same one as that.\n>\n>> I have to use bash to run the test or I get\n>>\n>> $ ./t4034-diff-words.sh\n>> ./t4034-diff-words.sh: syntax error at line 52: `(' unexpected\n>\n> The open parenthesis on line 52 is the one between h and 4 here:\n>\n> cat > expect <<\\EOF\n> diff --git a/pre b/post\n> index 330b04f..5ed8eff 100644\n> --- a/pre\n> +++ b/post\n> @@ -1,3 +1,7 @@\n> h(4)h(4),hh[44]\n> \n> a = b + c\n>\n> aa = a\n>\n> aeff = aeff * ( aaa )\n> EOF\n>\n> Perhaps your shell has a broken here-text?\n\nOn OpenServer 6.0.6 /u95/bin/sh /u95/bin/ksh /u95/bin/bash are POSIX \ncompliant shells. The /bin/ shells are the stand SCO has had finx XENIX. \nThey use system 5v3. POSIX is System 5v4.\n\nThanks,\n\n-- \nBoyd Gerber 801 849-0213\nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"106475","messageId":"alpine.LNX.2.00.0902271348360.19082@suse104.zenez.com","threadId":"18046","inReplyTo":"alpine.LNX.2.00.0902271341440.19082@suse104.zenez.com","subject":"Re: git-1.6.2-rc2 problems on t4034-diff-words.sh","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2009-02-27T20:49:10Z","receivedAt":"2009-02-27T20:49:10Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:\n> On Fri, 27 Feb 2009, Junio C Hamano wrote:\n>> Boyd Lynn Gerber writes:\n>>> Does the test suite use bash as it's shell? I seem to have to use\n>>> bash now to run the test. I do not remember having to use bash on\n>>> earlier 1.6.0\n>> \n>> If your /bin/sh is not POSIX enough, you may be using a different shell\n>> when building the scripted commands in the main Makefile by setting\n>> SHELL_PATH. The tests are supposed to use the same one as that.\n>> \n>>> I have to use bash to run the test or I get\n>>> \n>>> $ ./t4034-diff-words.sh\n>>> ./t4034-diff-words.sh: syntax error at line 52: `(' unexpected\n>> \n>> The open parenthesis on line 52 is the one between h and 4 here:\n>>\n>> cat > expect <<\\EOF\n>> diff --git a/pre b/post\n>> index 330b04f..5ed8eff 100644\n>> --- a/pre\n>> +++ b/post\n>> @@ -1,3 +1,7 @@\n>> h(4)h(4),hh[44]\n>> \n>> a = b + c\n>>\n>> aa = a\n>>\n>> aeff = aeff * ( aaa )\n>> EOF\n>> \n>> Perhaps your shell has a broken here-text?\n>\n> On OpenServer 6.0.6 /u95/bin/sh /u95/bin/ksh /u95/bin/bash are POSIX \n> compliant shells. The /bin/ shells are the stand SCO has had finx XENIX. \n> They use system 5v3. POSIX is System 5v4.\n\nThat should have been OpenServer 6.0 MP4.\n\n-- \nBoyd Gerber 801 849-0213\nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"}]}