{"thread":{"id":"17977","subject":"[EGIT] [PATCH v1 1/1] Add an ignored icon","startedAt":"2009-02-23T19:03:43Z","lastAt":"2009-02-24T09:28:35Z","messageCount":9,"participants":["Ferry Huberts","Tor Arne Vestbø","Ferry Huberts (Pelagic)","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"105933","messageId":"cover.1235415747.git.ferry.huberts@pelagic.nl","threadId":"17977","inReplyTo":null,"subject":"[EGIT] [PATCH v1 0/1] Add an ignored icon","fromName":"Ferry Huberts","fromEmail":"ferry.huberts@pelagic.nl","sentAt":"2009-02-23T19:03:43Z","receivedAt":"2009-02-23T19:03:43Z","isPatch":true,"sender":{"key":"ferry.huberts@pelagic.nl","avatar":"https://gravatar.com/avatar/9f63c0289ad23cbdef0f7609a0af85ff0f4b3babfd066de9ff58f62d48cfd6f2?d=mp&s=160"},"body":"Add an ignored icon to the label decorations page and make\nsure that it is actually decorated: from now on do not ignore\nignored resources during decoration.\n\nFerry Huberts (1):\n  Add an ignored icon\n\n org.spearce.egit.ui/icons/ovr/ignored.gif          |  Bin 0 -> 102 bytes\n .../egit/ui/PluginPreferenceInitializer.java       |    1 +\n .../src/org/spearce/egit/ui/UIIcons.java           |    4 ++++\n .../src/org/spearce/egit/ui/UIPreferences.java     |    2 ++\n .../src/org/spearce/egit/ui/UIText.java            |    3 +++\n .../decorators/GitLightweightDecorator.java        |   11 ++++++++---\n .../preferences/GitDecoratorPreferencePage.java    |   12 ++++++++++++\n .../src/org/spearce/egit/ui/uitext.properties      |    1 +\n 8 files changed, 31 insertions(+), 3 deletions(-)\n create mode 100644 org.spearce.egit.ui/icons/ovr/ignored.gif\n"},{"id":"105932","messageId":"ec97c536d418f465befba2a7f30f82f0d75004f8.1235415747.git.ferry.huberts@pelagic.nl","threadId":"17977","inReplyTo":"cover.1235415747.git.ferry.huberts@pelagic.nl","subject":"[EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Ferry Huberts","fromEmail":"ferry.huberts@pelagic.nl","sentAt":"2009-02-23T19:03:44Z","receivedAt":"2009-02-23T19:03:44Z","isPatch":true,"sender":{"key":"ferry.huberts@pelagic.nl","avatar":"https://gravatar.com/avatar/9f63c0289ad23cbdef0f7609a0af85ff0f4b3babfd066de9ff58f62d48cfd6f2?d=mp&s=160"},"body":"Add an ignored icon to the label decorations page and make\nsure that it is actually decorated: from now on do not ignore\nignored resources during decoration.\n\nSigned-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>\n---\n org.spearce.egit.ui/icons/ovr/ignored.gif          |  Bin 0 -> 102 bytes\n .../egit/ui/PluginPreferenceInitializer.java       |    1 +\n .../src/org/spearce/egit/ui/UIIcons.java           |    4 ++++\n .../src/org/spearce/egit/ui/UIPreferences.java     |    2 ++\n .../src/org/spearce/egit/ui/UIText.java            |    3 +++\n .../decorators/GitLightweightDecorator.java        |   11 ++++++++---\n .../preferences/GitDecoratorPreferencePage.java    |   12 ++++++++++++\n .../src/org/spearce/egit/ui/uitext.properties      |    1 +\n 8 files changed, 31 insertions(+), 3 deletions(-)\n create mode 100644 org.spearce.egit.ui/icons/ovr/ignored.gif\n\ndiff --git a/org.spearce.egit.ui/icons/ovr/ignored.gif b/org.spearce.egit.ui/icons/ovr/ignored.gif\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..509e706b3c847697c8fab379bc8bacdc66d21f3c\nGIT binary patch\nliteral 102\nzcmZ?wbhEHb<Y3@nc+AJ}>(@D15q3p!E=^fpC2=k-SzZ$rK|38WV-+D!6DfNgu|P{%\nzPh+VN3xoe)p!k!8k%57qL5BedKxQzo2!Gh?Hha$0M=_26udo+g4fC2Q!pL9^04%B;\nA)&Kwi\n\nliteral 0\nHcmV?d00001\n\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/PluginPreferenceInitializer.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/PluginPreferenceInitializer.java\nindex 8d617e9..f76b6e1 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/PluginPreferenceInitializer.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/PluginPreferenceInitializer.java\n@@ -46,6 +46,7 @@ public void initializeDefaultPreferences() {\n \t\t\t\tUIText.DecoratorPreferencesPage_projectFormatDefault);\n \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_TRACKED_ICON, true);\n \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON, true);\n+\t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_IGNORED_ICON, true);\n \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_STAGED_ICON, true);\n \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_CONFLICTS_ICON, true);\n \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_ASSUME_VALID_ICON, true);\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIIcons.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIIcons.java\nindex 952816c..5bc1eaf 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIIcons.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIIcons.java\n@@ -31,6 +31,9 @@\n \t/** Decoration for resource not being tracked by Git */\n \tpublic static final ImageDescriptor OVR_UNTRACKED;\n \n+\t/** Decoration for resource ignored by Git */\n+\tpublic static final ImageDescriptor OVR_IGNORED;\n+\n \t/** Decoration for tracked resource with a merge conflict.  */\n \tpublic static final ImageDescriptor OVR_CONFLICT;\n \n@@ -92,6 +95,7 @@\n \t\tOVR_STAGED_ADD = map(\"ovr/staged_added.gif\");\n \t\tOVR_STAGED_REMOVE = map(\"ovr/staged_removed.gif\");\n \t\tOVR_UNTRACKED = map(\"ovr/untracked.gif\");\n+\t\tOVR_IGNORED = map(\"ovr/ignored.gif\");\n \t\tOVR_CONFLICT = map(\"ovr/conflict.gif\");\n \t\tOVR_ASSUMEVALID = map(\"ovr/assume_valid.gif\");\n \t\tELCL16_FIND = map(\"elcl16/find.gif\");\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIPreferences.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIPreferences.java\nindex bbc36be..cdf9ab4 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIPreferences.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIPreferences.java\n@@ -67,6 +67,8 @@\n \t/** */\n \tpublic final static String DECORATOR_SHOW_UNTRACKED_ICON = \"decorator_show_untracked_icon\";\n \t/** */\n+\tpublic final static String DECORATOR_SHOW_IGNORED_ICON = \"decorator_show_ignored_icon\";\n+\t/** */\n \tpublic final static String DECORATOR_SHOW_STAGED_ICON = \"decorator_show_staged_icon\";\n \t/** */\n \tpublic final static String DECORATOR_SHOW_CONFLICTS_ICON = \"decorator_show_conflicts_icon\";\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIText.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIText.java\nindex 0740f09..85bb50b 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/UIText.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/UIText.java\n@@ -1013,6 +1013,9 @@\n \tpublic static String DecoratorPreferencesPage_iconsShowUntracked;\n \n \t/** */\n+\tpublic static String DecoratorPreferencesPage_iconsShowIgnored;\n+\n+\t/** */\n \tpublic static String DecoratorPreferencesPage_iconsShowStaged;\n \n \t/** */\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitLightweightDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitLightweightDecorator.java\nindex 6f69c80..06c10e1 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitLightweightDecorator.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitLightweightDecorator.java\n@@ -224,6 +224,8 @@ public ImageData getImageData() {\n \n \t\tprivate static ImageDescriptor untrackedImage;\n \n+\t\tprivate static ImageDescriptor ignoredImage;\n+\n \t\tprivate static ImageDescriptor stagedImage;\n \n \t\tprivate static ImageDescriptor stagedAddedImage;\n@@ -238,6 +240,7 @@ public ImageData getImageData() {\n \t\t\ttrackedImage = new CachedImageDescriptor(TeamImages\n \t\t\t\t\t.getImageDescriptor(ISharedImages.IMG_CHECKEDIN_OVR));\n \t\t\tuntrackedImage = new CachedImageDescriptor(UIIcons.OVR_UNTRACKED);\n+\t\t\tignoredImage = new CachedImageDescriptor(UIIcons.OVR_IGNORED);\n \t\t\tstagedImage = new CachedImageDescriptor(UIIcons.OVR_STAGED);\n \t\t\tstagedAddedImage = new CachedImageDescriptor(UIIcons.OVR_STAGED_ADD);\n \t\t\tstagedRemovedImage = new CachedImageDescriptor(\n@@ -269,9 +272,6 @@ public DecorationHelper(IPreferenceStore preferencesStore) {\n \t\t */\n \t\tpublic void decorate(IDecoration decoration,\n \t\t\t\tIDecoratableResource resource) {\n-\t\t\tif (resource.isIgnored())\n-\t\t\t\treturn;\n-\n \t\t\tdecorateText(decoration, resource);\n \t\t\tdecorateIcons(decoration, resource);\n \t\t}\n@@ -335,6 +335,11 @@ else if (staged == Staged.REMOVED)\n \t\t\t\t\t\t&& resource.hasConflicts())\n \t\t\t\t\toverlay = conflictImage;\n \n+\t\t\t} else if (resource.isIgnored()) {\n+\t\t\t\tif (store\n+\t\t\t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_IGNORED_ICON)) {\n+\t\t\t\t\toverlay = ignoredImage;\n+\t\t\t\t}\n \t\t\t} else if (store\n \t\t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON)) {\n \t\t\t\toverlay = untrackedImage;\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitDecoratorPreferencePage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitDecoratorPreferencePage.java\nindex eca2277..8c950cf 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitDecoratorPreferencePage.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitDecoratorPreferencePage.java\n@@ -99,6 +99,8 @@\n \n \tprivate Button showUntracked;\n \n+\tprivate Button showIgnored;\n+\n \tprivate Preview preview;\n \n \tprivate Button showStaged;\n@@ -308,6 +310,8 @@ private Control createIconDecoratorPage(Composite parent) {\n \t\t\t\tUIText.DecoratorPreferencesPage_iconsShowTracked);\n \t\tshowUntracked = SWTUtils.createCheckBox(imageGroup,\n \t\t\t\tUIText.DecoratorPreferencesPage_iconsShowUntracked);\n+\t\tshowIgnored = SWTUtils.createCheckBox(imageGroup,\n+\t\t\t\tUIText.DecoratorPreferencesPage_iconsShowIgnored);\n \t\tshowStaged = SWTUtils.createCheckBox(imageGroup,\n \t\t\t\tUIText.DecoratorPreferencesPage_iconsShowStaged);\n \t\tshowConflicts = SWTUtils.createCheckBox(imageGroup,\n@@ -376,6 +380,8 @@ private void initializeValues() {\n \t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_TRACKED_ICON));\n \t\tshowUntracked.setSelection(store\n \t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON));\n+\t\tshowIgnored.setSelection(store\n+\t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_IGNORED_ICON));\n \t\tshowStaged.setSelection(store\n \t\t\t\t.getBoolean(UIPreferences.DECORATOR_SHOW_STAGED_ICON));\n \t\tshowConflicts.setSelection(store\n@@ -391,6 +397,7 @@ public void widgetSelected(SelectionEvent e) {\n \n \t\tshowTracked.addSelectionListener(selectionListener);\n \t\tshowUntracked.addSelectionListener(selectionListener);\n+\t\tshowIgnored.addSelectionListener(selectionListener);\n \t\tshowStaged.addSelectionListener(selectionListener);\n \t\tshowConflicts.addSelectionListener(selectionListener);\n \t\tshowAssumeValid.addSelectionListener(selectionListener);\n@@ -447,6 +454,8 @@ private boolean performOk(IPreferenceStore store) {\n \t\t\t\t.getSelection());\n \t\tstore.setValue(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON,\n \t\t\t\tshowUntracked.getSelection());\n+\t\tstore.setValue(UIPreferences.DECORATOR_SHOW_IGNORED_ICON,\n+\t\t\t\tshowIgnored.getSelection());\n \t\tstore.setValue(UIPreferences.DECORATOR_SHOW_STAGED_ICON, showStaged\n \t\t\t\t.getSelection());\n \t\tstore.setValue(UIPreferences.DECORATOR_SHOW_CONFLICTS_ICON,\n@@ -485,6 +494,9 @@ protected void performDefaults() {\n \t\tshowUntracked\n \t\t\t\t.setSelection(store\n \t\t\t\t\t\t.getDefaultBoolean(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON));\n+\t\tshowIgnored\n+\t\t\t\t.setSelection(store\n+\t\t\t\t\t\t.getDefaultBoolean(UIPreferences.DECORATOR_SHOW_IGNORED_ICON));\n \t\tshowStaged.setSelection(store\n \t\t\t\t.getDefaultBoolean(UIPreferences.DECORATOR_SHOW_STAGED_ICON));\n \t\tshowConflicts\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/uitext.properties b/org.spearce.egit.ui/src/org/spearce/egit/ui/uitext.properties\nindex 847cb2c..932c75c 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/uitext.properties\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/uitext.properties\n@@ -376,6 +376,7 @@ DecoratorPreferencesPage_textLabel=T&ext Decorations\n DecoratorPreferencesPage_iconLabel=&Icon Decorations\n DecoratorPreferencesPage_iconsShowTracked=Tracked resources\n DecoratorPreferencesPage_iconsShowUntracked=Untracked resources\n+DecoratorPreferencesPage_iconsShowIgnored=Ignored resources\n DecoratorPreferencesPage_iconsShowStaged=Staged resources\n DecoratorPreferencesPage_iconsShowConflicts=Conflicting resources\n DecoratorPreferencesPage_iconsShowAssumeValid=Assumed unchanged resources\n-- \n1.6.0.6\n"},{"id":"105945","messageId":"49A33862.90507@gmail.com","threadId":"17977","inReplyTo":"ec97c536d418f465befba2a7f30f82f0d75004f8.1235415747.git.ferry.huberts@pelagic.nl","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Tor Arne Vestbø","fromEmail":"torarnv@gmail.com","sentAt":"2009-02-23T23:59:30Z","receivedAt":"2009-02-23T23:59:30Z","isPatch":true,"sender":{"key":"torarnv@gmail.com","avatar":"https://gravatar.com/avatar/847af0150a5a28ad86d9db1556a48aba04e7642c6a29a5a767f8c2bdf1720321?d=mp&s=160"},"body":"Ferry Huberts wrote:\n> Add an ignored icon to the label decorations page and make\n> sure that it is actually decorated: from now on do not ignore\n> ignored resources during decoration.\n\nThe reason this was not added in the original series was because that's\nkind of the point of ignoring a resource -- you don't want any\ninformation about it. Also, none of the other team plugins provide\ndecorations for ignored resources-\n\nOn the other hand, since the decorators are now user configurable,\nadding the option to allow users to enable decoration of ignored\nresources if they really feel it's useful to them is admittedly in line\nwith the whole customization idea.\n\nThough I'm not sure if this particular case of customization would cause\nmore confusion than good, for example in terms of which doors we open by\nallowing ignored resources to actually not be ignored (i.e what other\nfeatures would you expect to work for ignored resources?).\n\n>  \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON, true);\n> +\t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_IGNORED_ICON, true);\n>  \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_STAGED_ICON, true);\n\nIf applied, I would argue that the option should be _off_ by default, to\nmatch the behavior of the other team plugins and the normal logical\naction of ignoring a resource.\n\n> +\t/** Decoration for resource ignored by Git */\n> +\tpublic static final ImageDescriptor OVR_IGNORED;\n> +\n\nSide-note: the current decoration implementation only uses Eclipse's\nconcept of an ignored resource -- not .gitignore et al. since we don't\nhave a standard way of reading those yet.\n\nTor Arne\n"},{"id":"105973","messageId":"49A38282.8020308@pelagic.nl","threadId":"17977","inReplyTo":"49A33862.90507@gmail.com","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Ferry Huberts (Pelagic)","fromEmail":"ferry.huberts@pelagic.nl","sentAt":"2009-02-24T05:15:46Z","receivedAt":"2009-02-24T05:15:46Z","isPatch":true,"sender":{"key":"ferry.huberts@pelagic.nl","avatar":"https://gravatar.com/avatar/9f63c0289ad23cbdef0f7609a0af85ff0f4b3babfd066de9ff58f62d48cfd6f2?d=mp&s=160"},"body":"Tor Arne Vestbø wrote:\n> Ferry Huberts wrote:\n>> Add an ignored icon to the label decorations page and make\n>> sure that it is actually decorated: from now on do not ignore\n>> ignored resources during decoration.\n> \n> The reason this was not added in the original series was because that's\n> kind of the point of ignoring a resource -- you don't want any\n> information about it. Also, none of the other team plugins provide\n> decorations for ignored resources-\n> \n\nI could also argue that I want everything to be explicit, even the\nstatus of ignored files :-)\n\nIf you look at (for example) TortoiseSVN then you'll see that it does\nprovide an ignore icon. My icon was sort of 'inspired' by that one.\nDon't know if it's on by default though, will have to check that.\n\n> On the other hand, since the decorators are now user configurable,\n> adding the option to allow users to enable decoration of ignored\n> resources if they really feel it's useful to them is admittedly in line\n> with the whole customization idea.\n> \n> Though I'm not sure if this particular case of customization would cause\n> more confusion than good, for example in terms of which doors we open by\n> allowing ignored resources to actually not be ignored (i.e what other\n> features would you expect to work for ignored resources?).\n> \n>>  \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_UNTRACKED_ICON, true);\n>> +\t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_IGNORED_ICON, true);\n>>  \t\tprefs.setDefault(UIPreferences.DECORATOR_SHOW_STAGED_ICON, true);\n> \n> If applied, I would argue that the option should be _off_ by default, to\n> match the behavior of the other team plugins and the normal logical\n> action of ignoring a resource.\n\nnot my preference (hey I wrote the patch) but reasonable.\n\n> \n>> +\t/** Decoration for resource ignored by Git */\n>> +\tpublic static final ImageDescriptor OVR_IGNORED;\n>> +\n> \n> Side-note: the current decoration implementation only uses Eclipse's\n> concept of an ignored resource -- not .gitignore et al. since we don't\n> have a standard way of reading those yet.\n> \n> Tor Arne\n> \nI've started work on that, see the issue on the issue tracker. The plan\nis to hook in on change events and then parse all gitignore files, and\ntell eclipse about the contents of the ignores.\n\nFerry\n"},{"id":"105980","messageId":"42268.77.61.241.211.1235455860.squirrel@hupie.xs4all.nl","threadId":"17977","inReplyTo":"49A38282.8020308@pelagic.nl","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Ferry Huberts (Pelagic)","fromEmail":"ferry.huberts@pelagic.nl","sentAt":"2009-02-24T06:11:00Z","receivedAt":"2009-02-24T06:11:00Z","isPatch":true,"sender":{"key":"ferry.huberts@pelagic.nl","avatar":"https://gravatar.com/avatar/9f63c0289ad23cbdef0f7609a0af85ff0f4b3babfd066de9ff58f62d48cfd6f2?d=mp&s=160"},"body":"On Tue, February 24, 2009 06:15, Ferry Huberts (Pelagic) wrote:\n> Tor Arne Vestbø wrote:\n>> Ferry Huberts wrote:\n>>> Add an ignored icon to the label decorations page and make\n>>> sure that it is actually decorated: from now on do not ignore\n>>> ignored resources during decoration.\n>>\n>> The reason this was not added in the original series was because that's\n>> kind of the point of ignoring a resource -- you don't want any\n>> information about it. Also, none of the other team plugins provide\n>> decorations for ignored resources-\n>>\n>\n> I could also argue that I want everything to be explicit, even the\n> status of ignored files :-)\n>\n> If you look at (for example) TortoiseSVN then you'll see that it does\n> provide an ignore icon. My icon was sort of 'inspired' by that one.\n> Don't know if it's on by default though, will have to check that.\n\nI just checked, TortoiseSVN has the overlay for ignored items on by default\n"},{"id":"105990","messageId":"200902240806.38710.robin.rosenberg.lists@dewire.com","threadId":"17977","inReplyTo":"49A33862.90507@gmail.com","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2009-02-24T07:06:38Z","receivedAt":"2009-02-24T07:06:38Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"tisdag 24 februari 2009 00:59:30 skrev Tor Arne Vestbø <torarnv@gmail.com>:\n> Ferry Huberts wrote:\n> > Add an ignored icon to the label decorations page and make\n> > sure that it is actually decorated: from now on do not ignore\n> > ignored resources during decoration.\n> \n> The reason this was not added in the original series was because that's\n> kind of the point of ignoring a resource -- you don't want any\n> information about it. Also, none of the other team plugins provide\n> decorations for ignored resources-\n\n\"Ignored\" in this context does not mean unimportant.  It means we will\nnot track it in git, which is quite important.\n\n-- robin\n"},{"id":"106011","messageId":"13520.77.61.241.211.1235467365.squirrel@hupie.xs4all.nl","threadId":"17977","inReplyTo":"49A3BCA3.8010201@gmail.com","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Ferry Huberts (Pelagic)","fromEmail":"ferry.huberts@pelagic.nl","sentAt":"2009-02-24T09:22:45Z","receivedAt":"2009-02-24T09:22:45Z","isPatch":true,"sender":{"key":"ferry.huberts@pelagic.nl","avatar":"https://gravatar.com/avatar/9f63c0289ad23cbdef0f7609a0af85ff0f4b3babfd066de9ff58f62d48cfd6f2?d=mp&s=160"},"body":">> I just checked, TortoiseSVN has the overlay for ignored items on by default\n>\n> The difference is TortoiseSVN does not come with a set of global default\n> ignored files (as far as I know). Eclipse does, see Team->Ignored...\n>\n> So, a globally ignored file such as foobar.BAK would show up as\n> non-decorated if shared using the CVS or SVN plugins, but with an icon\n> if shared with Git. That might be confusing to users, especially since\n> the minus-sign icon does not have any history in Eclipse as something\n> being \"ignored\" (it actually breaks the convention of using\n> non-decoration -- meaning no \"untracked\"-icon -- to signal ignored).\n>\n> So, I would still argue that we should leave it off by default.\n>\n\nFor now I think that's acceptable. However, when I complete the work\non the ignores then we should switch it on:\nI plan to let EGit NOT look at the Eclipse global ignore list because\nthe ignores are defined by .gitignore files for git repositories.\nAt that point it totally makes sense to decorate ignored resources\nbecause these are configured in .gitignore files\n"},{"id":"106009","messageId":"49A3BCA3.8010201@gmail.com","threadId":"17977","inReplyTo":"42268.77.61.241.211.1235455860.squirrel@hupie.xs4all.nl","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Tor Arne Vestbø","fromEmail":"torarnv@gmail.com","sentAt":"2009-02-24T09:23:47Z","receivedAt":"2009-02-24T09:23:47Z","isPatch":true,"sender":{"key":"torarnv@gmail.com","avatar":"https://gravatar.com/avatar/847af0150a5a28ad86d9db1556a48aba04e7642c6a29a5a767f8c2bdf1720321?d=mp&s=160"},"body":"Ferry Huberts (Pelagic) wrote:\n> On Tue, February 24, 2009 06:15, Ferry Huberts (Pelagic) wrote:\n>> Tor Arne Vestbø wrote:\n>>> Ferry Huberts wrote:\n>>>> Add an ignored icon to the label decorations page and make\n>>>> sure that it is actually decorated: from now on do not ignore\n>>>> ignored resources during decoration.\n>>> The reason this was not added in the original series was because that's\n>>> kind of the point of ignoring a resource -- you don't want any\n>>> information about it. Also, none of the other team plugins provide\n>>> decorations for ignored resources-\n>>>\n>> I could also argue that I want everything to be explicit, even the\n>> status of ignored files :-)\n\nThat's a reasonable argument :) I'm not really opposed to the feature -- \nI was just trying to think of reasons why it might not be such as good \nidea, just to be safe and have that discussion. But you are right.\n\nAcked-by: Tor Arne Vestbø <torarnv@gmail.com>\n\n>> If you look at (for example) TortoiseSVN then you'll see that it does\n>> provide an ignore icon. My icon was sort of 'inspired' by that one.\n>> Don't know if it's on by default though, will have to check that.\n> \n> I just checked, TortoiseSVN has the overlay for ignored items on by default\n\nThe difference is TortoiseSVN does not come with a set of global default \nignored files (as far as I know). Eclipse does, see Team->Ignored...\n\nSo, a globally ignored file such as foobar.BAK would show up as \nnon-decorated if shared using the CVS or SVN plugins, but with an icon \nif shared with Git. That might be confusing to users, especially since \nthe minus-sign icon does not have any history in Eclipse as something \nbeing \"ignored\" (it actually breaks the convention of using \nnon-decoration -- meaning no \"untracked\"-icon -- to signal ignored).\n\nSo, I would still argue that we should leave it off by default.\n\nTor Arne\n"},{"id":"106010","messageId":"49A3BDC3.8030809@gmail.com","threadId":"17977","inReplyTo":"200902240806.38710.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT] [PATCH v1 1/1] Add an ignored icon","fromName":"Tor Arne Vestbø","fromEmail":"torarnv@gmail.com","sentAt":"2009-02-24T09:28:35Z","receivedAt":"2009-02-24T09:28:35Z","isPatch":true,"sender":{"key":"torarnv@gmail.com","avatar":"https://gravatar.com/avatar/847af0150a5a28ad86d9db1556a48aba04e7642c6a29a5a767f8c2bdf1720321?d=mp&s=160"},"body":"Robin Rosenberg wrote:\n> tisdag 24 februari 2009 00:59:30 skrev Tor Arne Vestbø <torarnv@gmail.com>:\n>> Ferry Huberts wrote:\n>>> Add an ignored icon to the label decorations page and make\n>>> sure that it is actually decorated: from now on do not ignore\n>>> ignored resources during decoration.\n>> The reason this was not added in the original series was because that's\n>> kind of the point of ignoring a resource -- you don't want any\n>> information about it. Also, none of the other team plugins provide\n>> decorations for ignored resources-\n> \n> \"Ignored\" in this context does not mean unimportant.  It means we will\n> not track it in git, which is quite important.\n\nTrue, it's important. Untracked already has a decoration (the '?'), and \ntracked files have the yellow database icon. I'm just saying the \nconvention so far in Eclipse has been to use non-decoration (no ? or \nyellow db icon) to signal ignored resources.\n\nTor Arne\n"}]}