{"thread":{"id":"17894","subject":"[PATCH 6/6] Mention to the user that they can reorder commits","startedAt":"2009-02-19T07:37:01Z","lastAt":"2009-02-19T10:24:03Z","messageCount":4,"participants":["John Tapsell","Pieter de Bie","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"105405","messageId":"200902190737.01121.johnflux@gmail.com","threadId":"17894","inReplyTo":null,"subject":"[PATCH 6/6] Mention to the user that they can reorder commits","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-02-19T07:37:01Z","receivedAt":"2009-02-19T07:37:01Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"Signed-off-by: John Tapsell \n---\n git-rebase--interactive.sh | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\nindex 3dc659d..2f58922 100755\n--- a/git-rebase--interactive.sh\n+++ b/git-rebase--interactive.sh\n@@ -733,6 +733,7 @@ first and then run 'git rebase --continue' again.\"\n #\n # If you remove a line here THAT COMMIT WILL BE LOST.\n # However, if you remove everything, the rebase will be aborted.\n+# You can reorder the lines to reorder the commits.\n #\n EOF\n \n-- \n1.6.2.rc1.3.g7d31b.dirty\n"},{"id":"105414","messageId":"53F7BA4C-6F63-4993-A959-E67E4FB4F456@frim.nl","threadId":"17894","inReplyTo":"200902190737.01121.johnflux@gmail.com","subject":"Re: [PATCH 6/6] Mention to the user that they can reorder commits","fromName":"Pieter de Bie","fromEmail":"pieter@frim.nl","sentAt":"2009-02-19T09:13:49Z","receivedAt":"2009-02-19T09:13:49Z","isPatch":true,"sender":{"key":"pieter@frim.nl","avatar":null},"body":"\nOn 19 feb 2009, at 07:37, John Tapsell wrote:\n\n> Signed-off-by: John Tapsell \n> ---\n\nYes, this has been raised many times in #git now, so it makes\nsense to include it.\n\n- Pieter\n"},{"id":"105431","messageId":"20090219101638.GA20707@neumann","threadId":"17894","inReplyTo":"53F7BA4C-6F63-4993-A959-E67E4FB4F456@frim.nl","subject":"Re: [PATCH 6/6] Mention to the user that they can reorder commits","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-02-19T10:16:38Z","receivedAt":"2009-02-19T10:16:38Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Thu, Feb 19, 2009 at 09:13:49AM +0000, Pieter de Bie wrote:\n>\n> On 19 feb 2009, at 07:37, John Tapsell wrote:\n>\n>> Signed-off-by: John Tapsell \n>> ---\n>\n> Yes, this has been raised many times in #git now, so it makes\n> sense to include it.\n\nA similar idea came around last week, and in turn Dscho explained why\nsuch a change is not a good idea. I think he is fully right here.\n\n\n\nhttp://article.gmane.org/gmane.comp.version-control.git/109136\n\n On Mon, Feb 09, 2009 at 10:31:56PM +0100, Johannes Schindelin wrote:\n > If we start along those lines, we also have to add documentation how\n > to\n > \n > - split commit,\n > \n > - change authorship of commits,\n > \n > - deal with commits where --cherry-pick did not detect that they were \n > applied already,\n > \n > - deal with merge commits, and\n > \n > - possibly a lot more.\n > \n > I do not think that this is a good way to spend valuable screen\n > estate; I \n > think that is what the man page should cover.\n > \n > I only made an exception for the deletion of lines, as people were \n > actively burnt. Yes, they should have read the man page. But the \n > consequences of not doing so were bad.\n\n\nRegards,\nGábor\n"},{"id":"105434","messageId":"43d8ce650902190224g71c821f1p5b9f07d61f417aab@mail.gmail.com","threadId":"17894","inReplyTo":"20090219101638.GA20707@neumann","subject":"Re: [PATCH 6/6] Mention to the user that they can reorder commits","fromName":"John Tapsell","fromEmail":"johnflux@gmail.com","sentAt":"2009-02-19T10:24:03Z","receivedAt":"2009-02-19T10:24:03Z","isPatch":true,"sender":{"key":"johnflux@gmail.com","avatar":"https://gravatar.com/avatar/25f70d4c0f96396b84a2e34bcd9bdc233462c7b4be29b5fdca8266fc53f30b0c?d=mp&s=160"},"body":"2009/2/19 SZEDER Gábor :\n> On Thu, Feb 19, 2009 at 09:13:49AM +0000, Pieter de Bie wrote:\n>>\n>> On 19 feb 2009, at 07:37, John Tapsell wrote:\n>>\n>>> Signed-off-by: John Tapsell \n>>> ---\n>>\n>> Yes, this has been raised many times in #git now, so it makes\n>> sense to include it.\n>\n> A similar idea came around last week, and in turn Dscho explained why\n> such a change is not a good idea. I think he is fully right here.\n>\n>\n> \n> http://article.gmane.org/gmane.comp.version-control.git/109136\n>\n> On Mon, Feb 09, 2009 at 10:31:56PM +0100, Johannes Schindelin wrote:\n> > If we start along those lines, we also have to add documentation how\n> > to\n> >\n> > - split commit,\n\nThat can be done from the \"git rebase -i\" screen? I'm guessing you\nmean choosing 'edit' and doing it from there.\n\nSame for all the other comments. How many of these can actually be\ndone from the \"git rebase -i\" screen?\n\n> > - change authorship of commits,\n> >\n> > - deal with commits where --cherry-pick did not detect that they were applied already,\n> >\n> > - deal with merge commits, and\n> >\n> > - possibly a lot more.\n> >\n> > I do not think that this is a good way to spend valuable screen\n> > estate; I\n> > think that is what the man page should cover.\n> >\n> > I only made an exception for the deletion of lines, as people were\n> > actively burnt. Yes, they should have read the man page. But the\n> > consequences of not doing so were bad.\n>\n>\n> Regards,\n> Gábor\n>\n>\n"}]}