{"thread":{"id":"17844","subject":"[PATCH v2] filter-branch -d: Export GIT_DIR earlier","startedAt":"2009-02-17T08:31:46Z","lastAt":"2009-02-19T00:53:38Z","messageCount":10,"participants":["Lars Noschinski","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"105096","messageId":"20090217083146.GA7338@lars.home.noschinski.de","threadId":"17844","inReplyTo":null,"subject":"[PATCH v2] filter-branch -d: Export GIT_DIR earlier","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2009-02-17T08:31:46Z","receivedAt":"2009-02-17T08:31:46Z","isPatch":true,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"The improved error handling catches a bug in filter-branch when using\n-d pointing to a path outside any git repository:\n\n$ mkdir foo\n$ cd foo\n$ git init\n$ touch bar\n$ git add bar\n$ git commit -m bar\n$ cd ..\n$ git clone --bare foo\n$ cd foo.git\n$ git filter-branch -d /tmp/filter master\nfatal: Not a git repository (or any of the parent directories): .git\n\nThis error message comes from git for-each-ref in line 224. GIT_DIR is\nset correctly by git-sh-setup (to the foo.git repository), but not\nexported (yet).\n---\n\nThe tests copies backup-ref into another directory and checks\nthat it contains a branch from the rewritten repository.\n\n  git-filter-branch.sh     |   12 ++++++------\n  t/t7003-filter-branch.sh |    9 +++++++++\n  2 files changed, 15 insertions(+), 6 deletions(-)\n\ndiff --git a/git-filter-branch.sh b/git-filter-branch.sh\nindex 27b57b8..9a09ba1 100755\n--- a/git-filter-branch.sh\n+++ b/git-filter-branch.sh\n@@ -220,6 +220,12 @@ die \"\"\n  # Remove tempdir on exit\n  trap 'cd ../..; rm -rf \"$tempdir\"' 0\n  \n+ORIG_GIT_DIR=\"$GIT_DIR\"\n+ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n+ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n+GIT_WORK_TREE=.\n+export GIT_DIR GIT_WORK_TREE\n+\n  # Make sure refs/original is empty\n  git for-each-ref > \"$tempdir\"/backup-refs || exit\n  while read sha1 type name\n@@ -234,12 +240,6 @@ do\n  \tesac\n  done < \"$tempdir\"/backup-refs\n  \n-ORIG_GIT_DIR=\"$GIT_DIR\"\n-ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n-ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n-GIT_WORK_TREE=.\n-export GIT_DIR GIT_WORK_TREE\n-\n  # The refs should be updated if their heads were rewritten\n  git rev-parse --no-flags --revs-only --symbolic-full-name \\\n  \t--default HEAD \"$@\" > \"$tempdir\"/raw-heads || exit\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 56b5ecc..446700b 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -48,6 +48,15 @@ test_expect_success 'result is really identical' '\n  \ttest $H = $(git rev-parse HEAD)\n  '\n  \n+TRASHDIR=$(pwd)\n+test_expect_success 'correct GIT_DIR while using -d' '\n+        mkdir drepo && cd drepo && git init && make_commit drepo &&\n+        git filter-branch -d \"$TRASHDIR/dfoo\" \\\n+            --index-filter \"cp \\\"$TRASHDIR\\\"/dfoo/backup-refs \\\"$TRASHDIR\\\"\" &&\n+        cd .. &&\n+        grep drepo \"$TRASHDIR/backup-refs\"\n+'\n+\n  test_expect_success 'Fail if commit filter fails' '\n  \ttest_must_fail git filter-branch -f --commit-filter \"exit 1\" HEAD\n  '\n-- \n1.6.1.3\n"},{"id":"105103","messageId":"20090217085301.GA7446@lars.home.noschinski.de","threadId":"17844","inReplyTo":"20090217083146.GA7338@lars.home.noschinski.de","subject":"Re: [PATCH v2] filter-branch -d: Export GIT_DIR earlier","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2009-02-17T08:53:01Z","receivedAt":"2009-02-17T08:53:01Z","isPatch":true,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"* Lars Noschinski <lars@public.noschinski.de> [09-02-17 09:31]:\n>The improved error handling catches a bug in filter-branch when using\n>-d pointing to a path outside any git repository:\n>\n>$ mkdir foo\n>$ cd foo\n>$ git init\n>$ touch bar\n>$ git add bar\n>$ git commit -m bar\n>$ cd ..\n>$ git clone --bare foo\n>$ cd foo.git\n>$ git filter-branch -d /tmp/filter master\n>fatal: Not a git repository (or any of the parent directories): .git\n>\n>This error message comes from git for-each-ref in line 224. GIT_DIR is\n>set correctly by git-sh-setup (to the foo.git repository), but not\n>exported (yet).\n\nOps, forgot the\n\nSigned-off-by: Lars Noschinski <lars@public.noschinski.de>\n\nFeel free to add it. I can also resend the patch.\n\n   - Lars\n"},{"id":"105131","messageId":"alpine.DEB.1.00.0902171327270.6185@intel-tinevez-2-302","threadId":"17844","inReplyTo":"20090217083146.GA7338@lars.home.noschinski.de","subject":"Re: [PATCH v2] filter-branch -d: Export GIT_DIR earlier","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-17T12:44:01Z","receivedAt":"2009-02-17T12:44:01Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 17 Feb 2009, Lars Noschinski wrote:\n\n> The improved error handling catches a bug in filter-branch when using\n> -d pointing to a path outside any git repository:\n> \n> $ mkdir foo\n> $ cd foo\n> $ git init\n> $ touch bar\n> $ git add bar\n> $ git commit -m bar\n> $ cd ..\n> $ git clone --bare foo\n> $ cd foo.git\n> $ git filter-branch -d /tmp/filter master\n> fatal: Not a git repository (or any of the parent directories): .git\n\nThis could be written as\n\n\t$ cd .git\n\t$ git filter-branch -d /tmp/bla master\n\nRight?\n\n\t\n>  git-filter-branch.sh     |   12 ++++++------\n>  t/t7003-filter-branch.sh |    9 +++++++++\n>  2 files changed, 15 insertions(+), 6 deletions(-)\n\nFunny, git am -3 reports:\n\n\tDid you hand edit your patch?\n\tIt does not apply to blobs recorded in its index.\n\tCannot fall back to three-way merge.\n\nAfter realizing that the common lines were prefixed with a double space, \nand applying my l33t patch m0nkey ski77z, I could verify that it works as \nexpected (in addition to looking at the patch and deeming it correct).\n\n> diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\n> index 56b5ecc..446700b 100755\n> --- a/t/t7003-filter-branch.sh\n> +++ b/t/t7003-filter-branch.sh\n> @@ -48,6 +48,15 @@ test_expect_success 'result is really identical' '\n>  \ttest $H = $(git rev-parse HEAD)\n>  '\n>  \n> +TRASHDIR=$(pwd)\n> +test_expect_success 'correct GIT_DIR while using -d' '\n> +        mkdir drepo && cd drepo && git init && make_commit drepo &&\n\nI usually prefer those to be on one line, each.\n\n> +        git filter-branch -d \"$TRASHDIR/dfoo\" \\\n> +            --index-filter \"cp \\\"$TRASHDIR\\\"/dfoo/backup-refs \\\"$TRASHDIR\\\"\"\n> &&\n> +        cd .. &&\n\nWe try to avoid cd'ing back, by using constructs like this:\n\n\t(cd drepo &&\n\t ...\n\t) &&\n\nAfter those two (maybe three) changes and your SOB: ACK.\n\nBTW the reason I wanted to test this thing is that I suspected that you \nmeant test_commit instead of make_commit.  But then, I realized that there \nexists a make_commit in t7003... which shares the shortcoming of our \nprevious implementation of test_commit in that it adds ambiguities on \ncase-insensitive filesystems.\n\nSo I _had_ to look who introduced make_commit:\n\n\t$ git blame -L '/make_commit/,/}/' t/t7003*\n\nMaking a fool out of yourself -- priceless.\n\nCiao,\nDscho\n"},{"id":"105191","messageId":"20090217175959.GA3564@lars.home.noschinski.de","threadId":"17844","inReplyTo":"alpine.DEB.1.00.0902171327270.6185@intel-tinevez-2-302","subject":"Re: [PATCH v2] filter-branch -d: Export GIT_DIR earlier","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2009-02-17T17:59:59Z","receivedAt":"2009-02-17T17:59:59Z","isPatch":true,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"* Johannes Schindelin <Johannes.Schindelin@gmx.de> [09-02-17 16:08]:\n>On Tue, 17 Feb 2009, Lars Noschinski wrote:\n>> The improved error handling catches a bug in filter-branch when using\n>> -d pointing to a path outside any git repository:\n>> \n>> $ mkdir foo\n>> $ cd foo\n>> $ git init\n>> $ touch bar\n>> $ git add bar\n>> $ git commit -m bar\n>> $ cd ..\n>> $ git clone --bare foo\n>> $ cd foo.git\n>> $ git filter-branch -d /tmp/filter master\n>> fatal: Not a git repository (or any of the parent directories): .git\n>\n>This could be written as\n>\n>\t$ cd .git\n>\t$ git filter-branch -d /tmp/bla master\n\nDoes not work, as we get another (slightly misleading) error message:\n\n/tmp/foo/.git$ git filter-branch -d /tmp/bar master\nfatal: This operation must be run in a work tree\nCannot rewrite branch(es) with a dirty working directory.\n\nBut we do not need a bare repository at all to demonstrate this bug, so\nwe can skip even the 'cd .git'.\n\n>Funny, git am -3 reports:\n>\n>\tDid you hand edit your patch?\n>\tIt does not apply to blobs recorded in its index.\n>\tCannot fall back to three-way merge.\n\nHm, for some reason, format=flowed was enabled. I wonder, that it has\nnot bitten me earlier.\n\n>We try to avoid cd'ing back, by using constructs like this:\n>\n>\t(cd drepo &&\n>\t ...\n>\t) &&\n\nOk, can do.\n\n>After those two (maybe three) changes and your SOB: ACK.\n>\n>BTW the reason I wanted to test this thing is that I suspected that you \n>meant test_commit instead of make_commit.  But then, I realized that there \n>exists a make_commit in t7003... which shares the shortcoming of our \n>previous implementation of test_commit in that it adds ambiguities on \n>case-insensitive filesystems.\n\nYeah, I used make_commit to stay consistent with the rest of the file.\nI'll change it to test_commit. I think as it does not bite us, it would\nbe unnecessary code churn to remove the remaining usage of make_commit?\n\n>So I _had_ to look who introduced make_commit:\n>\n>\t$ git blame -L '/make_commit/,/}/' t/t7003*\n>\n>Making a fool out of yourself -- priceless.\n\n:)\n\n  - Lars.\n"},{"id":"105195","messageId":"20090217180540.GB3564@lars.home.noschinski.de","threadId":"17844","inReplyTo":"20090217175959.GA3564@lars.home.noschinski.de","subject":"Re: [PATCH v3] filter-branch -d: Export GIT_DIR earlier","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2009-02-17T18:05:40Z","receivedAt":"2009-02-17T18:05:40Z","isPatch":true,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"The improved error handling catches a bug in filter-branch when using\n-d pointing to a path outside any git repository:\n\n$ mkdir foo\n$ cd foo\n$ git init\n$ touch bar\n$ git add bar\n$ git commit -m bar\n$ git filter-branch -d /tmp/filter master\nfatal: Not a git repository (or any of the parent directories): .git\n\nThis error message comes from git for-each-ref in line 224. GIT_DIR is\nset correctly by git-sh-setup (to the foo.git repository), but not\nexported (yet).\n\nSigned-off-by: Lars Noschinski <lars@public.noschinski.de>\n---\n  git-filter-branch.sh     |   12 ++++++------\n  t/t7003-filter-branch.sh |   12 ++++++++++++\n  2 files changed, 18 insertions(+), 6 deletions(-)\n\ndiff --git a/git-filter-branch.sh b/git-filter-branch.sh\nindex 27b57b8..9a09ba1 100755\n--- a/git-filter-branch.sh\n+++ b/git-filter-branch.sh\n@@ -220,6 +220,12 @@ die \"\"\n  # Remove tempdir on exit\n  trap 'cd ../..; rm -rf \"$tempdir\"' 0\n  \n+ORIG_GIT_DIR=\"$GIT_DIR\"\n+ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n+ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n+GIT_WORK_TREE=.\n+export GIT_DIR GIT_WORK_TREE\n+\n  # Make sure refs/original is empty\n  git for-each-ref > \"$tempdir\"/backup-refs || exit\n  while read sha1 type name\n@@ -234,12 +240,6 @@ do\n  \tesac\n  done < \"$tempdir\"/backup-refs\n  \n-ORIG_GIT_DIR=\"$GIT_DIR\"\n-ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n-ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n-GIT_WORK_TREE=.\n-export GIT_DIR GIT_WORK_TREE\n-\n  # The refs should be updated if their heads were rewritten\n  git rev-parse --no-flags --revs-only --symbolic-full-name \\\n  \t--default HEAD \"$@\" > \"$tempdir\"/raw-heads || exit\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 56b5ecc..329c851 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -48,6 +48,18 @@ test_expect_success 'result is really identical' '\n  \ttest $H = $(git rev-parse HEAD)\n  '\n  \n+TRASHDIR=$(pwd)\n+test_expect_success 'correct GIT_DIR while using -d' '\n+\tmkdir drepo &&\n+\t( cd drepo &&\n+\tgit init &&\n+\ttest_commit drepo &&\n+\tgit filter-branch -d \"$TRASHDIR/dfoo\" \\\n+\t\t--index-filter \"cp \\\"$TRASHDIR\\\"/dfoo/backup-refs \\\"$TRASHDIR\\\"\" \\\n+\t) &&\n+\tgrep drepo \"$TRASHDIR/backup-refs\"\n+'\n+\n  test_expect_success 'Fail if commit filter fails' '\n  \ttest_must_fail git filter-branch -f --commit-filter \"exit 1\" HEAD\n  '\n-- \n1.6.2.rc0.91.g0bb0.dirty\n"},{"id":"105234","messageId":"alpine.DEB.1.00.0902172359210.10279@pacific.mpi-cbg.de","threadId":"17844","inReplyTo":"20090217175959.GA3564@lars.home.noschinski.de","subject":"Re: [PATCH v2] filter-branch -d: Export GIT_DIR earlier","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-17T23:01:41Z","receivedAt":"2009-02-17T23:01:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 17 Feb 2009, Lars Noschinski wrote:\n\n> I'll change [make_commit] to test_commit.\n\nOops, sorry, I actually was not trying to suggest that, but relate a story \nthat I found funny ;-)\n\n> I think as it does not bite us, it would be unnecessary code churn to \n> remove the remaining usage of make_commit?\n\nProbably.  I mean, every cleanup bears a very real possibility of \nintroducing a regression, so it better be worth it.  As t7003 seems to \nwork on (case) insensitive filesystems, let's leave it.\n\nCiao,\nDscho\n"},{"id":"105235","messageId":"alpine.DEB.1.00.0902180002090.10279@pacific.mpi-cbg.de","threadId":"17844","inReplyTo":"20090217180540.GB3564@lars.home.noschinski.de","subject":"Re: [PATCH v3] filter-branch -d: Export GIT_DIR earlier","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-17T23:03:16Z","receivedAt":"2009-02-17T23:03:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 17 Feb 2009, Lars Noschinski wrote:\n\n> The improved error handling catches a bug in filter-branch when using\n> -d pointing to a path outside any git repository:\n> \n> $ mkdir foo\n> $ cd foo\n> $ git init\n> $ touch bar\n> $ git add bar\n> $ git commit -m bar\n> $ git filter-branch -d /tmp/filter master\n> fatal: Not a git repository (or any of the parent directories): .git\n> \n> This error message comes from git for-each-ref in line 224. GIT_DIR is\n> set correctly by git-sh-setup (to the foo.git repository), but not\n> exported (yet).\n> \n> Signed-off-by: Lars Noschinski <lars@public.noschinski.de>\n> ---\n\nLet me quickly add my ACK before Junio can apply the patch without it.  \n(Even I had the impression that you wanted to trim down the commit \nmessage, but it really does not matter to me all that much.)\n\nCiao,\nDscho\n"},{"id":"105278","messageId":"20090218083535.GA5466@lars.home.noschinski.de","threadId":"17844","inReplyTo":"alpine.DEB.1.00.0902180002090.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH v4] filter-branch -d: Export GIT_DIR earlier","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2009-02-18T08:35:36Z","receivedAt":"2009-02-18T08:35:36Z","isPatch":true,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"The improved error handling catches a bug in filter-branch when using\n-d pointing to a path outside any git repository:\n\n$ git filter-branch -d /tmp/foo master\nfatal: Not a git repository (or any of the parent directories): .git\n\nThis error message comes from git for-each-ref in line 224. GIT_DIR is\nset correctly by git-sh-setup (to the foo.git repository), but not\nexported (yet).\n\nSigned-off-by: Lars Noschinski <lars@public.noschinski.de>\nAcked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n---\n\nLast iteration :)\n\n git-filter-branch.sh     |   12 ++++++------\n t/t7003-filter-branch.sh |   12 ++++++++++++\n 2 files changed, 18 insertions(+), 6 deletions(-)\n\ndiff --git a/git-filter-branch.sh b/git-filter-branch.sh\nindex 27b57b8..9a09ba1 100755\n--- a/git-filter-branch.sh\n+++ b/git-filter-branch.sh\n@@ -220,6 +220,12 @@ die \"\"\n # Remove tempdir on exit\n trap 'cd ../..; rm -rf \"$tempdir\"' 0\n \n+ORIG_GIT_DIR=\"$GIT_DIR\"\n+ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n+ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n+GIT_WORK_TREE=.\n+export GIT_DIR GIT_WORK_TREE\n+\n # Make sure refs/original is empty\n git for-each-ref > \"$tempdir\"/backup-refs || exit\n while read sha1 type name\n@@ -234,12 +240,6 @@ do\n \tesac\n done < \"$tempdir\"/backup-refs\n \n-ORIG_GIT_DIR=\"$GIT_DIR\"\n-ORIG_GIT_WORK_TREE=\"$GIT_WORK_TREE\"\n-ORIG_GIT_INDEX_FILE=\"$GIT_INDEX_FILE\"\n-GIT_WORK_TREE=.\n-export GIT_DIR GIT_WORK_TREE\n-\n # The refs should be updated if their heads were rewritten\n git rev-parse --no-flags --revs-only --symbolic-full-name \\\n \t--default HEAD \"$@\" > \"$tempdir\"/raw-heads || exit\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 56b5ecc..329c851 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -48,6 +48,18 @@ test_expect_success 'result is really identical' '\n \ttest $H = $(git rev-parse HEAD)\n '\n \n+TRASHDIR=$(pwd)\n+test_expect_success 'correct GIT_DIR while using -d' '\n+\tmkdir drepo &&\n+\t( cd drepo &&\n+\tgit init &&\n+\ttest_commit drepo &&\n+\tgit filter-branch -d \"$TRASHDIR/dfoo\" \\\n+\t\t--index-filter \"cp \\\"$TRASHDIR\\\"/dfoo/backup-refs \\\"$TRASHDIR\\\"\" \\\n+\t) &&\n+\tgrep drepo \"$TRASHDIR/backup-refs\"\n+'\n+\n test_expect_success 'Fail if commit filter fails' '\n \ttest_must_fail git filter-branch -f --commit-filter \"exit 1\" HEAD\n '\n-- \n1.6.1.3\n"},{"id":"105288","messageId":"alpine.DEB.1.00.0902181125410.6274@intel-tinevez-2-302","threadId":"17844","inReplyTo":"20090218083535.GA5466@lars.home.noschinski.de","subject":"Re: [PATCH v4] filter-branch -d: Export GIT_DIR earlier","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-18T10:25:53Z","receivedAt":"2009-02-18T10:25:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 18 Feb 2009, Lars Noschinski wrote:\n\n> The improved error handling catches a bug in filter-branch when using\n> -d pointing to a path outside any git repository:\n> \n> $ git filter-branch -d /tmp/foo master\n> fatal: Not a git repository (or any of the parent directories): .git\n> \n> This error message comes from git for-each-ref in line 224. GIT_DIR is\n> set correctly by git-sh-setup (to the foo.git repository), but not\n> exported (yet).\n> \n> Signed-off-by: Lars Noschinski <lars@public.noschinski.de>\n> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n> ---\n> \n> Last iteration :)\n\nYep, I like it.\n\nThanks,\nDscho\n"},{"id":"105365","messageId":"7v1vtvs0vh.fsf@gitster.siamese.dyndns.org","threadId":"17844","inReplyTo":"alpine.DEB.1.00.0902181125410.6274@intel-tinevez-2-302","subject":"Re: [PATCH v4] filter-branch -d: Export GIT_DIR earlier","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-19T00:53:38Z","receivedAt":"2009-02-19T00:53:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n>> Last iteration :)\n>\n> Yep, I like it.\n\nThanks.\n"}]}