{"thread":{"id":"17777","subject":"[PATCH] Remove redundant bit clears from diff_setup()","startedAt":"2009-02-13T17:33:34Z","lastAt":"2009-02-13T17:33:34Z","messageCount":1,"participants":["Keith Cascio"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"104531","messageId":"1234546414-4416-1-git-send-email-keith@cs.ucla.edu","threadId":"17777","inReplyTo":null,"subject":"[PATCH] Remove redundant bit clears from diff_setup()","fromName":"Keith Cascio","fromEmail":"keith@cs.ucla.edu","sentAt":"2009-02-13T17:33:34Z","receivedAt":"2009-02-13T17:33:34Z","isPatch":true,"sender":{"key":"keith@cs.ucla.edu","avatar":"https://gravatar.com/avatar/c5ec3a8f1cd1f449fdf8bdb7125fdbfd10b729507f32cbf0aa4ad07b4f7127ae?d=mp&s=160"},"body":"All bits already clear after memset(0).\n---\n diff.c |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex be3859e..006aa01 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -2319,29 +2319,26 @@ static void run_checkdiff(struct diff_filepair *p, struct diff_options *o)\n void diff_setup(struct diff_options *options)\n {\n \tmemset(options, 0, sizeof(*options));\n \n \toptions->file = stdout;\n \n \toptions->line_termination = '\\n';\n \toptions->break_opt = -1;\n \toptions->rename_limit = -1;\n \toptions->dirstat_percent = 3;\n-\tDIFF_OPT_CLR(options, DIRSTAT_CUMULATIVE);\n \toptions->context = 3;\n \n \toptions->change = diff_change;\n \toptions->add_remove = diff_addremove;\n \tif (diff_use_color_default > 0)\n \t\tDIFF_OPT_SET(options, COLOR_DIFF);\n-\telse\n-\t\tDIFF_OPT_CLR(options, COLOR_DIFF);\n \toptions->detect_rename = diff_detect_rename_default;\n \n \tif (!diff_mnemonic_prefix) {\n \t\toptions->a_prefix = \"a/\";\n \t\toptions->b_prefix = \"b/\";\n \t}\n }\n \n int diff_setup_done(struct diff_options *options)\n {\n-- \n1.6.1\n"}]}