{"thread":{"id":"17733","subject":"[PATCH] git-svn: Fix for rewriteRoot URL containing username.","startedAt":"2009-02-11T23:14:02Z","lastAt":"2009-02-16T00:55:25Z","messageCount":2,"participants":["Dévai Tamás","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"104313","messageId":"1234394042-11577-1-git-send-email-devait@mailbox.sk","threadId":"17733","inReplyTo":null,"subject":"[PATCH] git-svn: Fix for rewriteRoot URL containing username.","fromName":"Dévai Tamás","fromEmail":"devait@mailbox.sk","sentAt":"2009-02-11T23:14:02Z","receivedAt":"2009-02-11T23:14:02Z","isPatch":true,"sender":{"key":"devait@mailbox.sk","avatar":null},"body":"If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option\n(or by the --rewrite-root option to 'git svn init') contains a username\n(such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find\nthe repository URL, because the URL contained in the commit message does have\nthe username removed.\n\nSigned-off-by: Dévai Tamás <devait@mailbox.sk>\n---\n git-svn.perl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 001a1d8..83cb36f 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional\n \t\t\tmy $prefix = '';\n \t\t\tif ($rwr) {\n \t\t\t\t$z = $rwr;\n+\t\t\t\tremove_username($z);\n \t\t\t} elsif (defined $svm) {\n \t\t\t\t$z = $svm->{source};\n \t\t\t\t$prefix = $svm->{replace};\n-- \n1.6.1.2\n"},{"id":"104871","messageId":"20090216005525.GA20625@untitled","threadId":"17733","inReplyTo":"1234394042-11577-1-git-send-email-devait@mailbox.sk","subject":"Re: [PATCH] git-svn: Fix for rewriteRoot URL containing username.","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-02-16T00:55:25Z","receivedAt":"2009-02-16T00:55:25Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Dévai Tamás <devait@mailbox.sk> wrote:\n> If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option\n> (or by the --rewrite-root option to 'git svn init') contains a username\n> (such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find\n> the repository URL, because the URL contained in the commit message does have\n> the username removed.\n> \n> Signed-off-by: Dévai Tamás <devait@mailbox.sk>\n\nThanks Dévai,\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n> ---\n>  git-svn.perl |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 001a1d8..83cb36f 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional\n>  \t\t\tmy $prefix = '';\n>  \t\t\tif ($rwr) {\n>  \t\t\t\t$z = $rwr;\n> +\t\t\t\tremove_username($z);\n>  \t\t\t} elsif (defined $svm) {\n>  \t\t\t\t$z = $svm->{source};\n>  \t\t\t\t$prefix = $svm->{replace};\n> -- \n> 1.6.1.2\n"}]}