{"thread":{"id":"17720","subject":"[PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","startedAt":"2009-02-11T09:51:30Z","lastAt":"2009-02-11T11:30:13Z","messageCount":6,"participants":["Alex Riesen","Junio C Hamano","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"104161","messageId":"81b0412b0902110151x35fbbb4esb9efefae2e1fe90a@mail.gmail.com","threadId":"17720","inReplyTo":null,"subject":"[PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-02-11T09:51:30Z","receivedAt":"2009-02-11T09:51:30Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen \n---\n\nI'm honestly sorry for my contributions. They seem to be exclusively\nin the \"make Git work in Windows\" area. Depressing.\n\n t/t3400-rebase.sh | 5 +++++\n 1 files changed, 5 insertions(+), 0 deletions(-)\n\n\nFrom f41b99bbdf10249c0dfcb54545709f0a8dd00484 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Wed, 11 Feb 2009 10:45:43 +0100\nSubject: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support\n\nSigned-off-by: Alex Riesen \n---\n t/t3400-rebase.sh | 5 +++++\n 1 files changed, 5 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh\nindex 8c0c5f5..a229276 100755\n--- a/t/t3400-rebase.sh\n+++ b/t/t3400-rebase.sh\n@@ -70,6 +70,10 @@ test_expect_success \\\n test 3 = $(git rev-list master.. | wc -l)\n '\n \n+if test \"$(git config --bool core.filemode)\" = false\n+then\n+ say 'skipping rebase filemode tests (no filesystem support)'\n+else\n test_expect_success 'rebase a single mode change' '\n git checkout master &&\n echo 1 > X &&\n@@ -94,5 +98,6 @@ test_expect_success 'Show verbose error when HEAD could not be detached' '\n test_must_fail git rebase topic 2> output.err > output.out &&\n grep \"Untracked working tree file .B. would be overwritten\" output.err\n '\n+fi\n \n test_done\n-- \n1.6.2.rc0.28.g1f0fe8\n\n"},{"id":"104164","messageId":"7v7i3xgu9v.fsf@gitster.siamese.dyndns.org","threadId":"17720","inReplyTo":"81b0412b0902110151x35fbbb4esb9efefae2e1fe90a@mail.gmail.com","subject":"Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-11T10:09:00Z","receivedAt":"2009-02-11T10:09:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen writes:\n\n> Signed-off-by: Alex Riesen \n> ---\n>\n> I'm honestly sorry for my contributions. They seem to be exclusively\n> in the \"make Git work in Windows\" area. Depressing.\n>\n> t/t3400-rebase.sh | 5 +++++\n> 1 files changed, 5 insertions(+), 0 deletions(-)\n\nI wonder if you should be fixing the tests with \"update-index --chmod\"\ninstead...\n"},{"id":"104165","messageId":"4992A3DF.4010707@viscovery.net","threadId":"17720","inReplyTo":"81b0412b0902110151x35fbbb4esb9efefae2e1fe90a@mail.gmail.com","subject":"Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2009-02-11T10:09:35Z","receivedAt":"2009-02-11T10:09:35Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Alex Riesen schrieb:\n> Signed-off-by: Alex Riesen \n> ---\n> \n> I'm honestly sorry for my contributions. They seem to be exclusively\n> in the \"make Git work in Windows\" area. Depressing.\n> \n> t/t3400-rebase.sh | 5 +++++\n> 1 files changed, 5 insertions(+), 0 deletions(-)\n\nVery interesting. This test works unmodified here. On the other hand, I\nhave to skip the entire t4129-apply-samemode.sh.\n\n-- Hannes\n"},{"id":"104171","messageId":"81b0412b0902110253g2288419eha4037f22f6286ea4@mail.gmail.com","threadId":"17720","inReplyTo":"4992A3DF.4010707@viscovery.net","subject":"Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-02-11T10:53:16Z","receivedAt":"2009-02-11T10:53:16Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2009/2/11 Johannes Sixt :\n> Alex Riesen schrieb:\n>>\n>> I'm honestly sorry for my contributions. They seem to be exclusively\n>> in the \"make Git work in Windows\" area. Depressing.\n>>\n>> t/t3400-rebase.sh | 5 +++++\n>> 1 files changed, 5 insertions(+), 0 deletions(-)\n>\n> Very interesting. This test works unmodified here. On the other hand, I\n> have to skip the entire t4129-apply-samemode.sh.\n>\n\nhmm... These seem to work here. I have to use Cygwin. Do you use the\nnative port?\n"},{"id":"104174","messageId":"81b0412b0902110305o5ca60708gc07cbc9ae1d89d1f@mail.gmail.com","threadId":"17720","inReplyTo":"7v7i3xgu9v.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-02-11T11:05:08Z","receivedAt":"2009-02-11T11:05:08Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2009/2/11 Junio C Hamano :\n> Alex Riesen writes:\n>\n>> Signed-off-by: Alex Riesen \n>> ---\n>>\n>> I'm honestly sorry for my contributions. They seem to be exclusively\n>> in the \"make Git work in Windows\" area. Depressing.\n>>\n>> t/t3400-rebase.sh | 5 +++++\n>> 1 files changed, 5 insertions(+), 0 deletions(-)\n>\n> I wonder if you should be fixing the tests with \"update-index --chmod\"\n> instead...\n>\n\nWell, mostly these should work independent of the filesystem (except\nfor the cases when the index is checked out later). They seem to, and\nthey look like they should, too. See t4014-format-patch, for one.\n\nBut you're right. I should have reviewed them earlier. Anyway, there is\nnot many tests which have \"--chmod\" in them:\nt4006-diff-mode.sh, t4014-format-patch.sh, t6031-merge-recursive.sh,\nand t9500-gitweb-standalone-no-errors.sh.\nThe t4006 does not bother to look at working tree (good),\nt4014 is good (looks like its ignoring modes altogether),\nt6031 uses --chmod to augment the chmod useless on FAT-like fs\n(seem to be an earlier fix for the same problem).\n\nWhat's more interesting is the use of chmod for index mode change purpose,\nwhich should be reviewed regularly (and I do that only when it breaks.\nLazy boom, I am...)\n"},{"id":"104178","messageId":"4992B6C5.3010609@viscovery.net","threadId":"17720","inReplyTo":"81b0412b0902110253g2288419eha4037f22f6286ea4@mail.gmail.com","subject":"Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2009-02-11T11:30:13Z","receivedAt":"2009-02-11T11:30:13Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Alex Riesen schrieb:\n> 2009/2/11 Johannes Sixt :\n>> Alex Riesen schrieb:\n>>> I'm honestly sorry for my contributions. They seem to be exclusively\n>>> in the \"make Git work in Windows\" area. Depressing.\n>>>\n>>> t/t3400-rebase.sh | 5 +++++\n>>> 1 files changed, 5 insertions(+), 0 deletions(-)\n>> Very interesting. This test works unmodified here. On the other hand, I\n>> have to skip the entire t4129-apply-samemode.sh.\n>>\n> \n> hmm... These seem to work here. I have to use Cygwin. Do you use the\n> native port?\n\nYes. And the reason why the test does not fail here is because the mode\nchange is outright ignored, and the test doesn't check whether the result\nmeets the expectations.\n\n-- Hannes\n"}]}