{"thread":{"id":"17703","subject":"[PATCH] fix the installation path for html documentation","startedAt":"2009-02-10T15:14:13Z","lastAt":"2009-02-11T18:39:52Z","messageCount":3,"participants":["Michael J Gruber","Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"104021","messageId":"1234278853-25452-1-git-send-email-git@drmicha.warpmail.net","threadId":"17703","inReplyTo":null,"subject":"[PATCH] fix the installation path for html documentation","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-10T15:14:13Z","receivedAt":"2009-02-10T15:14:13Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Since 026fa0d5ad9538ca76838070861531c037d7b9ba (Move computation of\nabsolute paths from Makefile to runtime (in preparation for\nRUNTIME_PREFIX) the installation of html doc was broken:\nDocumentation/Makefile does not know how to resolve relative dirs, which\nresults in html doc being installed in\n$(git-build-root)/Documentation/share/doc/git-doc.\n\nFix this by not exporting htmldir from Makefile since this allows\nDocumentation/Makefile to compute htmldir from prefix.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\nAn alternative would be to teach Documentation/Makefile to take the\nrelative htmldir and make it into an absolute path. But the approach I'm\ntaking with this patch as analogous to how mandir is handled, with the\nsame draw back. But all is well as long as the build monkey messes with\nprefix only.\n\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 27b9569..862b96c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -228,7 +228,7 @@ GITWEB_FAVICON = git-favicon.png\n GITWEB_SITE_HEADER =\n GITWEB_SITE_FOOTER =\n \n-export prefix bindir sharedir htmldir sysconfdir\n+export prefix bindir sharedir sysconfdir\n \n CC = gcc\n AR = ar\n-- \n1.6.1.2.253.ga34a\n"},{"id":"104070","messageId":"200902102125.05287.j6t@kdbg.org","threadId":"17703","inReplyTo":"1234278853-25452-1-git-send-email-git@drmicha.warpmail.net","subject":"Re: [PATCH] fix the installation path for html documentation","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-02-10T20:25:04Z","receivedAt":"2009-02-10T20:25:04Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Dienstag, 10. Februar 2009, Michael J Gruber wrote:\n> Since 026fa0d5ad9538ca76838070861531c037d7b9ba (Move computation of\n> absolute paths from Makefile to runtime (in preparation for\n> RUNTIME_PREFIX) the installation of html doc was broken:\n> Documentation/Makefile does not know how to resolve relative dirs, which\n> results in html doc being installed in\n> $(git-build-root)/Documentation/share/doc/git-doc.\n>\n> Fix this by not exporting htmldir from Makefile since this allows\n> Documentation/Makefile to compute htmldir from prefix.\n>\n> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n> ---\n> An alternative would be to teach Documentation/Makefile to take the\n> relative htmldir and make it into an absolute path. But the approach I'm\n> taking with this patch as analogous to how mandir is handled, with the\n> same draw back. But all is well as long as the build monkey messes with\n> prefix only.\n\nMakes sense. There is no point handling mandir and htmldir differently.\n\n-- Hannes\n"},{"id":"104257","messageId":"7vr624es1z.fsf@gitster.siamese.dyndns.org","threadId":"17703","inReplyTo":"200902102125.05287.j6t@kdbg.org","subject":"Re: [PATCH] fix the installation path for html documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-11T18:39:52Z","receivedAt":"2009-02-11T18:39:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt <j6t@kdbg.org> writes:\n\n> Makes sense. There is no point handling mandir and htmldir differently.\n\nThanks, both.\n"}]}