{"thread":{"id":"17646","subject":"[PATCH] Make tig call the correct git config command","startedAt":"2009-02-08T07:46:55Z","lastAt":"2009-02-18T11:29:14Z","messageCount":5,"participants":["Mikael Magnusson","Jonas Fonseca","Kris Shannon"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"103695","messageId":"237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com","threadId":"17646","inReplyTo":null,"subject":"[PATCH] Make tig call the correct git config command","fromName":"Mikael Magnusson","fromEmail":"mikachu@gmail.com","sentAt":"2009-02-08T07:46:55Z","receivedAt":"2009-02-08T07:46:55Z","isPatch":true,"sender":{"key":"mikachu@gmail.com","avatar":null},"body":"2009/2/7 Mikael Magnusson :\n> 2009/2/5 Jonas Fonseca :\n>> Hello,\n>>\n>> Here is a much needed update fixing multiple regressions from the\n>> introduction of the IO API in 0.13. Among improvements is the much\n>> requested ability to restore the position in the stage view when staging\n>> diff hunks. Also noteworthy is the many optimizations of the screen\n>> updating to make it work better across slow links. Finally, beware that\n>> a handful of incompatibilities can cause problems.\n>\n> I'm having a problem with tig taking 2 seconds to start up, which\n> seems to be related to the 'typo checking' feature of git. After\n> figuring out how to stop strace from helpfully saying\n> write(2, \"WARNING: You called a Git program\"..., 137) = 137\n> I got this (with -s 100):\n> [pid 29708] write(2, \"WARNING: You called a Git program named 'git\n> config', which does not exist.\\nContinuing under the assu\"..., 137) =\n> 137\n> [pid 29708] write(2, \"in 2.0 seconds automatically...\\n\"..., 32) = 32\n>\n> The output however also contains lots of git config strings, which is\n> confusing. Is tig running git config twice and failing one of the\n> times? (Running git config from the cmdline works fine).\n\nTurns out it was as simple as this:\n\ndiff --git a/configure.ac b/configure.ac\nindex b179389..bdea8de 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config\n GIT_CONFIG=\"repo-config\"\n git config --list >/dev/null && GIT_CONFIG=\"config\"\n AC_MSG_RESULT([$GIT_CONFIG])\n-AC_DEFINE_UNQUOTED(GIT_CONFIG,\"$GIT_CONFIG\",[git config subcommand])\n+AC_DEFINE_UNQUOTED(GIT_CONFIG,\"$GIT_CONFIG\",[config subcommand])\n\n AC_CHECK_PROGS(ASCIIDOC, [asciidoc false])\n AC_CHECK_PROGS(XMLTO, [xmlto false])\n\n-- \nMikael Magnusson\n"},{"id":"103696","messageId":"237967ef0902072349t784e1519m3561ef02545a72de@mail.gmail.com","threadId":"17646","inReplyTo":"237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com","subject":"Re: [PATCH] Make tig call the correct git config command","fromName":"Mikael Magnusson","fromEmail":"mikachu@gmail.com","sentAt":"2009-02-08T07:49:52Z","receivedAt":"2009-02-08T07:49:52Z","isPatch":true,"sender":{"key":"mikachu@gmail.com","avatar":null},"body":"As it turns out I'm an idiot, that's just the configure help message.\nRerunning autoconf + configure in fact generates a completely correct\ncommandline. Sorry about the noise.\n\n2009/2/8 Mikael Magnusson :\n> 2009/2/7 Mikael Magnusson :\n>> 2009/2/5 Jonas Fonseca :\n>>> Hello,\n>>>\n>>> Here is a much needed update fixing multiple regressions from the\n>>> introduction of the IO API in 0.13. Among improvements is the much\n>>> requested ability to restore the position in the stage view when staging\n>>> diff hunks. Also noteworthy is the many optimizations of the screen\n>>> updating to make it work better across slow links. Finally, beware that\n>>> a handful of incompatibilities can cause problems.\n>>\n>> I'm having a problem with tig taking 2 seconds to start up, which\n>> seems to be related to the 'typo checking' feature of git. After\n>> figuring out how to stop strace from helpfully saying\n>> write(2, \"WARNING: You called a Git program\"..., 137) = 137\n>> I got this (with -s 100):\n>> [pid 29708] write(2, \"WARNING: You called a Git program named 'git\n>> config', which does not exist.\\nContinuing under the assu\"..., 137) =\n>> 137\n>> [pid 29708] write(2, \"in 2.0 seconds automatically...\\n\"..., 32) = 32\n>>\n>> The output however also contains lots of git config strings, which is\n>> confusing. Is tig running git config twice and failing one of the\n>> times? (Running git config from the cmdline works fine).\n>\n> Turns out it was as simple as this:\n>\n> diff --git a/configure.ac b/configure.ac\n> index b179389..bdea8de 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config\n> GIT_CONFIG=\"repo-config\"\n> git config --list >/dev/null && GIT_CONFIG=\"config\"\n> AC_MSG_RESULT([$GIT_CONFIG])\n> -AC_DEFINE_UNQUOTED(GIT_CONFIG,\"$GIT_CONFIG\",[git config subcommand])\n> +AC_DEFINE_UNQUOTED(GIT_CONFIG,\"$GIT_CONFIG\",[config subcommand])\n>\n> AC_CHECK_PROGS(ASCIIDOC, [asciidoc false])\n> AC_CHECK_PROGS(XMLTO, [xmlto false])\n>\n> --\n> Mikael Magnusson\n>\n\n\n\n-- \nMikael Magnusson\n"},{"id":"103710","messageId":"2c6b72b30902080156u3b8ba41m736bffaa7b6f15e9@mail.gmail.com","threadId":"17646","inReplyTo":"237967ef0902072349t784e1519m3561ef02545a72de@mail.gmail.com","subject":"Re: [PATCH] Make tig call the correct git config command","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2009-02-08T09:56:59Z","receivedAt":"2009-02-08T09:56:59Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"On Sun, Feb 8, 2009 at 08:49, Mikael Magnusson wrote:\n> As it turns out I'm an idiot, that's just the configure help message.\n> Rerunning autoconf + configure in fact generates a completely correct\n> commandline. Sorry about the noise.\n\nThanks for checking anyway. The Makefile doesn't detect out-of-date\nconfigure scripts, which (after the move to use argv arrays and execv\nin tig-0.13) caused tig to run: \"'git' 'git config'\" on startup.\n\nI wonder if this check in configure should not be removed anyway,\nsince it is starting to be a long time since git-repo-config was\nrenamed.\n\n-- \nJonas Fonseca\n"},{"id":"105291","messageId":"e51f4f550902180312y3e1999e8x5ff119516cd9bbae@mail.gmail.com","threadId":"17646","inReplyTo":"2c6b72b30902080156u3b8ba41m736bffaa7b6f15e9@mail.gmail.com","subject":"Re: [PATCH] Make tig call the correct git config command","fromName":"Kris Shannon","fromEmail":"kris@shannon.id.au","sentAt":"2009-02-18T11:12:27Z","receivedAt":"2009-02-18T11:12:27Z","isPatch":true,"sender":{"key":"kris@shannon.id.au","avatar":"https://gravatar.com/avatar/13a7c0b3c50ffacf54f456e543023fd702898bb134165fa805f019930524151f?d=mp&s=160"},"body":"2009/2/8 Jonas Fonseca \n> I wonder if this check in configure should not be removed anyway,\n> since it is starting to be a long time since git-repo-config was\n> renamed.\n\nSpeaking from a packaging standpoint, as this is the only reason\ngit-core is a build dependency I would vote to get rid of it.\n\n(I currently already patch the configure so I can build without git-core\ninstalled)\n"},{"id":"105292","messageId":"20090218112914.GA7672@diku.dk","threadId":"17646","inReplyTo":"e51f4f550902180312y3e1999e8x5ff119516cd9bbae@mail.gmail.com","subject":"Re: [PATCH] Make tig call the correct git config command","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2009-02-18T11:29:14Z","receivedAt":"2009-02-18T11:29:14Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Kris Shannon wrote Wed, Feb 18, 2009:\n> 2009/2/8 Jonas Fonseca \n> > I wonder if this check in configure should not be removed anyway,\n> > since it is starting to be a long time since git-repo-config was\n> > renamed.\n> \n> Speaking from a packaging standpoint, as this is the only reason\n> git-core is a build dependency I would vote to get rid of it.\n> \n> (I currently already patch the configure so I can build without git-core\n> installed)\n\nWhere can I get your patch?\n\n-- \nJonas Fonseca\n"}]}