{"thread":{"id":"17642","subject":"[PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","startedAt":"2009-02-08T03:26:26Z","lastAt":"2009-02-12T10:07:15Z","messageCount":44,"participants":["Jeremy White","Boyd Stephen Smith Jr.","Johannes Schindelin","Michael J Gruber","Ben Bucksch","Brandon Casey","Junio C Hamano","Miles Bader"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"103683","messageId":"498E50E2.8050309@codeweavers.com","threadId":"17642","inReplyTo":null,"subject":"[PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-08T03:26:26Z","receivedAt":"2009-02-08T03:26:26Z","isPatch":true,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":"\nSigned-off-by: Jeremy White <jwhite@codeweavers.com>\n---\n  Documentation/git-format-patch.txt |    4 +++-\n  builtin-log.c                      |   15 +++++++++++++++\n  2 files changed, 18 insertions(+), 1 deletions(-)\n\n\n\n\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex 11a7d77..2e8e94e 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -174,7 +174,8 @@ CONFIGURATION\n -------------\n You can specify extra mail header lines to be added to each message\n in the repository configuration, new defaults for the subject prefix\n-and file suffix, and number patches when outputting more than one.\n+and file suffix, control attachements, and number patches when outputting\n+more than one.\n \n ------------\n [format]\n@@ -183,6 +184,7 @@ and file suffix, and number patches when outputting more than one.\n \tsuffix = .txt\n \tnumbered = auto\n \tcc = <email>\n+\tattach [ = mime-boundary-string ]\n ------------\n \n \ndiff --git a/builtin-log.c b/builtin-log.c\nindex 2ae39af..c79895c 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -428,6 +428,8 @@ static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n static int auto_number = 1;\n \n+static char *default_attach = NULL;\n+\n static char **extra_hdr;\n static int extra_hdr_nr;\n static int extra_hdr_alloc;\n@@ -488,6 +490,14 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\tauto_number = auto_number && numbered;\n \t\treturn 0;\n \t}\n+\tif (!strcmp(var, \"format.attach\")) {\n+\t\tif (value && *value)\n+\t\t\tdefault_attach = xstrdup(value);\n+\t\telse\n+\t\t\tdefault_attach = xstrdup(git_version_string);\n+\t\treturn 0;\n+\t}\n+\n \n \treturn git_log_config(var, value, cb);\n }\n@@ -787,6 +797,11 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)\n \n \trev.subject_prefix = fmt_patch_subject_prefix;\n \n+\tif (default_attach) {\n+\t\trev.mime_boundary = default_attach;\n+\t\trev.no_inline = 1;\n+\t}\n+\n \t/*\n \t * Parse the arguments before setup_revisions(), or something\n \t * like \"git format-patch -o a123 HEAD^..\" may fail; a123 is\n\n"},{"id":"103691","messageId":"200902072310.12764.bss@iguanasuicide.net","threadId":"17642","inReplyTo":"498E50E2.8050309@codeweavers.com","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Boyd Stephen Smith Jr.","fromEmail":"bss@iguanasuicide.net","sentAt":"2009-02-08T05:10:12Z","receivedAt":"2009-02-08T05:10:12Z","isPatch":true,"sender":{"key":"bss@iguanasuicide.net","avatar":"https://gravatar.com/avatar/84b95eeff194b816c1568b1339e63e4b229825298664a9037b9f1ec713ead1e3?d=mp&s=160"},"body":"For a minor style issue, see my reply to your original patch.\n\nAlso, please read Documentation/SubmittingPatches.  Particularly, the third \npoint under the \"Patch\" heading on the first page.  Also, since you appear to \nsympathize with Thunderbird users you might want to read the \"Thunderbird\" \nsection, and either improve it or petition the developers to make the \napplication more amenable to users needs in this case.\n-- \nBoyd Stephen Smith Jr.                   ,= ,-_-. =.\nbss@iguanasuicide.net                   ((_/)o o(\\_))\nICQ: 514984 YM/AIM: DaTwinkDaddy         `-'(. .)`-'\nhttp://iguanasuicide.net/                    \\_/\n\n"},{"id":"103759","messageId":"498F01C2.5080105@codeweavers.com","threadId":"17642","inReplyTo":"200902072310.12764.bss@iguanasuicide.net","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-08T16:01:06Z","receivedAt":"2009-02-08T16:01:06Z","isPatch":true,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":"Boyd Stephen Smith Jr. wrote:\n> For a minor style issue, see my reply to your original patch.\n\nSure, thanks.\n\n> \n> Also, please read Documentation/SubmittingPatches.  Particularly, the third \n> point under the \"Patch\" heading on the first page.  Also, since you appear to \n> sympathize with Thunderbird users you might want to read the \"Thunderbird\" \n> section, and either improve it or petition the developers to make the \n> application more amenable to users needs in this case.\n\nSorry about that; I allowed my pleasure at the cuteness of using my own\npatch to send the patch override the requested courtesy of this list.\n\nAs an aside, there is a long (and discouraging) read about the issue\nwith Thunderbird here:\n  https://bugzilla.mozilla.org/show_bug.cgi?id=141983\n\nEssentially, the problem is well understood - Thunderbird uses\nformat=flowed by default, which is what mangles the patches.  The author\nof the relevant code is unmoved by arguments that the default should\nswitch, and no one has yet been willing to create a simpler UI for\nswitching the setting.\n\nCheers,\n\nJeremy\n"},{"id":"103762","messageId":"alpine.DEB.1.00.0902081827140.10279@pacific.mpi-cbg.de","threadId":"17642","inReplyTo":"498F01C2.5080105@codeweavers.com","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-08T17:28:55Z","receivedAt":"2009-02-08T17:28:55Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 8 Feb 2009, Jeremy White wrote:\n\n> As an aside, there is a long (and discouraging) read about the issue\n> with Thunderbird here:\n>   https://bugzilla.mozilla.org/show_bug.cgi?id=141983\n> \n> Essentially, the problem is well understood - Thunderbird uses\n> format=flowed by default, which is what mangles the patches.  The author\n> of the relevant code is unmoved by arguments that the default should\n> switch, and no one has yet been willing to create a simpler UI for\n> switching the setting.\n\nI guess I'll start discouraging use of Thunderbird from now on.  Seems \nthat not even the opposition of a guy named Andrew Morton was clue bat \nenough.\n\nCiao,\nDscho\n"},{"id":"103835","messageId":"499022D3.3000200@drmicha.warpmail.net","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902081827140.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-09T12:34:27Z","receivedAt":"2009-02-09T12:34:27Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Johannes Schindelin venit, vidit, dixit 08.02.2009 18:28:\n> Hi,\n> \n> On Sun, 8 Feb 2009, Jeremy White wrote:\n> \n>> As an aside, there is a long (and discouraging) read about the issue\n>> with Thunderbird here:\n>>   https://bugzilla.mozilla.org/show_bug.cgi?id=141983\n>>\n>> Essentially, the problem is well understood - Thunderbird uses\n>> format=flowed by default, which is what mangles the patches.  The author\n>> of the relevant code is unmoved by arguments that the default should\n>> switch, and no one has yet been willing to create a simpler UI for\n>> switching the setting.\n> \n> I guess I'll start discouraging use of Thunderbird from now on. \n\n...specifically for patch submission, please ;)\nI'm a TB user who compiles the beast and writes extensions for it, and\nyet I found git-send-email the more reliable and practical solution for\nsending out patches. Put yourself in bcc and you'll have a copy in TB's\ninbox or another folder (use filters).\n\n> Seems \n> that not even the opposition of a guy named Andrew Morton was clue bat \n> enough.\n\n<sarcasm style=\"reality: exaggerated;\">\nIsn't that some Linux guy? How would he matter for Mozilla? Does he even\nknow how to send HTML mail...\n</sarcasm>\n\nMichael\n"},{"id":"103837","messageId":"49902EDC.6020901@beonex.com","threadId":"17642","inReplyTo":"499022D3.3000200@drmicha.warpmail.net","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T13:25:48Z","receivedAt":"2009-02-09T13:25:48Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 13:34, Michael J Gruber wrote:\n> Johannes Schindelin venit, vidit, dixit 08.02.2009 18:28:\n>    \n>> On Sun, 8 Feb 2009, Jeremy White wrote\n>>> Essentially, the problem is well understood - Thunderbird uses\n>>> format=flowed by default, which is what mangles the patches.\n>>>        \n>> I guess I'll start discouraging use of Thunderbird from now on.\n\nOr you could just publish:\n1. Prefs | Advanced | General | Config Editor...\n2. \"mailnews.send_plaintext_flowed\" = false\n\nThe defaults should be best for the average user, not the rare \nprogrammer, who has no problem changing prefs.\n\nf=f helps the normal user (and more importantly his recipient) by \nproperly flowing text, which allows me to read with line lengths which \nare comfortable to read for me. It harms only in rare cases where \nline-endings are very important, *but* are not explicitly marked so. I \nthink you can switch to \"preformat\" in the HTML editor and it would \nwork, because we then know it's not flowing text, but I haven't tried \nit, because I attach such documents as txt / diff files.\n\nAs inline attachments, they'll show up inline in the msg viewer as well \n(which means I can read and copy&paste them), but are clearly separated \nfrom the body (which is assumed to be human-created natural language \ntext), avoiding the problem mentioned here, and can easily be saved as \nfile, opened in an external app etc.. I don't know why you didn't choose \nthat way, but I assume you had your reasons. Just as we had our reasons \nfor choosing f=f.\n\n> I found git-send-email the more reliable and practical solution for \n> sending out patches. Put yourself in bcc and you'll have a copy in \n> TB's inbox or another folder (use filters).\n\nYup, I think that's the best way - git is using email only as protocol, \nso it's good to have special clients to that, as it's a really special use.\n\n> <sarcasm style=\"reality: exaggerated;\">\n> Isn't that some Linux guy? How would he matter for Mozilla? Does he even\n> know how to send HTML mail...\n> </sarcasm>\n>    \nI don't think it's a matter of clue, it's a matter of background and \nattitude.\n\nBen\n"},{"id":"103838","messageId":"alpine.DEB.1.00.0902091433270.10279@pacific.mpi-cbg.de","threadId":"17642","inReplyTo":"49902EDC.6020901@beonex.com","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-09T13:36:28Z","receivedAt":"2009-02-09T13:36:28Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Feb 2009, Ben Bucksch wrote:\n\n> On 09.02.2009 13:34, Michael J Gruber wrote:\n> > Johannes Schindelin venit, vidit, dixit 08.02.2009 18:28:\n> >    \n> > > On Sun, 8 Feb 2009, Jeremy White wrote\n> > > > Essentially, the problem is well understood - Thunderbird uses\n> > > > format=flowed by default, which is what mangles the patches.\n> > > >        \n> > > I guess I'll start discouraging use of Thunderbird from now on.\n> \n> Or you could just publish:\n> 1. Prefs | Advanced | General | Config Editor...\n> 2. \"mailnews.send_plaintext_flowed\" = false\n\nAh.  Mhm...\n\n> As inline attachments, they'll show up inline in the msg viewer as well \n\n... which is a moot point, as the responder has to do extra work to quote \nthe stuff.  Definitely not my type of friendliness.\n\n> > I found git-send-email the more reliable and practical solution for \n> > sending out patches. Put yourself in bcc and you'll have a copy in \n> > TB's inbox or another folder (use filters).\n> \n> Yup, I think that's the best way - git is using email only as protocol, so\n> it's good to have special clients to that, as it's a really special use.\n\nAha.  And putting extra comments in (manually) does not count.  'cause I \ndo not see send-email allowing that.\n\n> > <sarcasm style=\"reality: exaggerated;\">\n> > Isn't that some Linux guy? How would he matter for Mozilla? Does he even\n> > know how to send HTML mail...\n> > </sarcasm>\n> >    \n>\n> I don't think it's a matter of clue, it's a matter of background and \n> attitude.\n\nYeah, I think my background dictates that I stay by my word and recommend \nother mailers than Thunderbird.\n\nIt is one thing to be nice to the \"average\" user, but another one to be \nunfriendly to the people making the internet revolution possible.\n\nCiao,\nDscho\n"},{"id":"103839","messageId":"49903491.7000509@drmicha.warpmail.net","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902091433270.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-09T13:50:09Z","receivedAt":"2009-02-09T13:50:09Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Johannes Schindelin venit, vidit, dixit 09.02.2009 14:36:\n> Hi,\n> \n> On Mon, 9 Feb 2009, Ben Bucksch wrote:\n> \n>> On 09.02.2009 13:34, Michael J Gruber wrote:\n>>> Johannes Schindelin venit, vidit, dixit 08.02.2009 18:28:\n>>>    \n>>>> On Sun, 8 Feb 2009, Jeremy White wrote\n>>>>> Essentially, the problem is well understood - Thunderbird uses\n>>>>> format=flowed by default, which is what mangles the patches.\n>>>>>        \n>>>> I guess I'll start discouraging use of Thunderbird from now on.\n>> Or you could just publish:\n>> 1. Prefs | Advanced | General | Config Editor...\n>> 2. \"mailnews.send_plaintext_flowed\" = false\n> \n> Ah.  Mhm...\n> \n>> As inline attachments, they'll show up inline in the msg viewer as well \n> \n> ... which is a moot point, as the responder has to do extra work to quote \n> the stuff.  Definitely not my type of friendliness.\n> \n>>> I found git-send-email the more reliable and practical solution for \n>>> sending out patches. Put yourself in bcc and you'll have a copy in \n>>> TB's inbox or another folder (use filters).\n>> Yup, I think that's the best way - git is using email only as protocol, so\n>> it's good to have special clients to that, as it's a really special use.\n> \n> Aha.  And putting extra comments in (manually) does not count.  'cause I \n> do not see send-email allowing that.\n\nThere is this useful thingy called \"vim\" which lets you edit the 00*\nfiles... Come on, Dscho ;)\n\n>>> <sarcasm style=\"reality: exaggerated;\">\n>>> Isn't that some Linux guy? How would he matter for Mozilla? Does he even\n>>> know how to send HTML mail...\n>>> </sarcasm>\n>>>    \n>> I don't think it's a matter of clue, it's a matter of background and \n>> attitude.\n> \n> Yeah, I think my background dictates that I stay by my word and recommend \n> other mailers than Thunderbird.\n> \n> It is one thing to be nice to the \"average\" user, but another one to be \n> unfriendly to the people making the internet revolution possible.\n\nI think Ben made it clear why \"format flowed\" is the default, and there\nare numerous posts in the TB/moz community which make it clear why they\nspell it \"format flawed\".  The default will not change.\n\nI thought about writing an extension which let's you change the config\non a per message basis. (You can already do it per folder using mnenhy,\nI suppose.) But then I still have to navigate from TB to my repo and\ninclude the output of git-format-patch, or dump it to an mbox (or upload\nto an imap drafts folder).\n\nSo, even with f-f issues out of the way I would find git-send-email\n(+vim) to be the right tool for the job. Which is why I use it, for\nsending patches by e-mail, not for corresponding by e-mail.\n\nSo, let's be peaceful, and talk about Mozilla's choice of hg instead ;)\n[No, please don't!]\n\nMichael\n"},{"id":"103841","messageId":"49903501.7060308@beonex.com","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902091433270.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T13:52:01Z","receivedAt":"2009-02-09T13:52:01Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 14:36, Johannes Schindelin wrote:\n> On Mon, 9 Feb 2009, Ben Bucksch wrote:\n>    \n>> Or you could just publish:\n>> 1. Prefs | Advanced | General | Config Editor...\n>> 2. \"mailnews.send_plaintext_flowed\" = false\n>>      \n> Ah.  Mhm...\n>    \n>> As inline attachments, they'll show up inline in the msg viewer as well\n>>      \n> ... which is a moot point, as the responder has to do extra work to quote\n> the stuff.  Definitely not my type of friendliness.\n\nIn newer Thunderbirds, you can mark / select a text, and when you hit \nreply, it (and only that) will be quoted - called selective quote. You \ncan press Ctrl-A (for Select All) before hitting reply, and the inline \nattachment will be included in the quote.\n\n> I stay by my word and recommend other mailers than Thunderbird.\n>    \n\nPlease be sure to also cite the pref change I mentioned above as \nalternative.\n\n<diversion>\n> It is one thing to be nice to the \"average\" user, but another one to be\n> unfriendly to the people making the internet revolution possible.\n>    \nHey now!\n\nI hope you realize that Netscape / Mozilla had a really important role \nin making the Internet popular in the public in the first place (the \nalternatives were AOL and CompuServe back then), and that Mozilla is \n*the* most-used Open Source application. In fact, Firefox' market share \non Windows made a large contribution to Linux, by convincing web sites \nauthors to not assume IE, which is a big reason why Linux is usable at \nall. Imagine the web or email was only usable with IE or Outlook...\n</diversion>\n\nI use Linux myself everywhere, and recommend it to many people, and I \nthink it's technically excellent.\n\nBTW: I want to use this occasion to thank all you Linux programmers for \nyour awesome, technically superiour work. Thanks a lot, and keep it up! :-)\n\nBen\n"},{"id":"103842","messageId":"49903521.1060101@codeweavers.com","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902091433270.10279@pacific.mpi-cbg.de","subject":"Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-09T13:52:33Z","receivedAt":"2009-02-09T13:52:33Z","isPatch":true,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":"> Yeah, I think my background dictates that I stay by my word and recommend \n> other mailers than Thunderbird.\n> \n> It is one thing to be nice to the \"average\" user, but another one to be \n> unfriendly to the people making the internet revolution possible.\n\nGah!  With all due respect, I think this attitude is a part of the problem.\n\nIt is clear to me that Ben and all the Thunderbird devs are doing their level\nbest to make the best possible MUA.\n\nPatch senders are a tiny fraction of the Thunderbird user base, and it's\nreasonable to down prioritize our concerns.  Even so, Ben has spent a lot of time\non this issue.   One of my great frustrations on the bug I copied was that \nI thought that Robin was articulating some valid points, but then couldn't \nhelp flaming on, thereby making it much harder for any human Mozilla dev to want to help.\n\nI'd like to hope that there is a reasonable solution that \nworks both for us and for the general public.\n\nI spent some time with the git-format-patch code as well as the Thunderbird\ncode.  I discovered that if I just injected charset=iso-2022-jp, format=flowed\nwould stay off! <grin>\n\nBen, along those lines, we do have the ability to control the entire\nbody of a possible patch before Thunderbird sees it.  Would it be possible,\nor reasonable, for Thunderbird to look for and preserve a 'format=fixed'\nsetting inside a body that we generated?\n\nCheers,\n\nJeremy\n"},{"id":"103844","messageId":"49903B27.8070608@beonex.com","threadId":"17642","inReplyTo":"49903521.1060101@codeweavers.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T14:18:15Z","receivedAt":"2009-02-09T14:18:15Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 14:52, Jeremy White wrote:\n> I discovered that if I just injected charset=iso-2022-jp, format=flowed\n> would stay off!<grin>\n>    \n(This was a hack, caused by the different use of spaces in Japanese / \nCJK, which means a different kind of \"flow\".)\n\n> Ben, along those lines, we do have the ability to control the entire \n> body of a possible patch before Thunderbird sees it. Would it be \n> possible, or reasonable, for Thunderbird to look for and preserve a \n> 'format=fixed' setting inside a body that we generated?\n\nI don't know how you're injecting the email to Thunderbird. mailto:?\n\nWhat you propose is a header, not a body.\n(I'm a bit irritated that TB would react to a charset header *in the \nbody*, but maybe that's a hack specially for charsets, in some code part \nI don't know, given that they are unfortunately sometimes only marked in \ncontent.)\n\nI think it would most likely work easily if you inject HTML (read before \nyou scream):\nmailto:fred@example.com?html-body=Here's patch revision abc from repo \ndef:<p><pre>Patch: file ....<br>+++ bla<br>line 3<br></pre>\n(properly escaped, of course)\nIt should invoke the normal rich editor, with the patch properly marked \nas preformatted. Once you send it, it would send it as plaintext, \ndepending on your prefs. During the formatting, it would see the \npreformat section and should send it out with the lineendings as marked.\nI haven't tried the full chain, but it's something to play with.\n\nBen\n"},{"id":"103845","messageId":"200902090840.03344.bss@iguanasuicide.net","threadId":"17642","inReplyTo":"49903491.7000509@drmicha.warpmail.net","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Boyd Stephen Smith Jr.","fromEmail":"bss@iguanasuicide.net","sentAt":"2009-02-09T14:39:57Z","receivedAt":"2009-02-09T14:39:57Z","isPatch":true,"sender":{"key":"bss@iguanasuicide.net","avatar":"https://gravatar.com/avatar/84b95eeff194b816c1568b1339e63e4b229825298664a9037b9f1ec713ead1e3?d=mp&s=160"},"body":"On Monday 09 February 2009 07:50:09 Michael J Gruber wrote:\n> Johannes Schindelin venit, vidit, dixit 09.02.2009 14:36:\n> > On Mon, 9 Feb 2009, Ben Bucksch wrote:\n> >> On 09.02.2009 13:34, Michael J Gruber wrote:\n> >>> Johannes Schindelin venit, vidit, dixit 08.02.2009 18:28:\n> >>>> On Sun, 8 Feb 2009, Jeremy White wrote\n> >>>>> Essentially, the problem is well understood - Thunderbird uses\n> >>>>> format=flowed by default, which is what mangles the patches.\n> >>>> I guess I'll start discouraging use of Thunderbird from now on.\n> >> Or you could just publish:\n> >> 1. Prefs | Advanced | General | Config Editor...\n> >> 2. \"mailnews.send_plaintext_flowed\" = false\n> > Ah.  Mhm...\n> >> I don't think it's a matter of clue, it's a matter of background and\n> >> attitude.\n> > Yeah, I think my background dictates that I stay by my word and recommend\n> > other mailers than Thunderbird.\n> I think Ben made it clear why \"format flowed\" is the default.\n> The default will not change.\n\nFor the record, KMail does f=f by default, too.  And I think any client that \ndoesn't do format=flowed by default it probably doing a disservice to it's \nusers.  Luckily, in KMail it is easy to turn off for a particular message with \n\"Options -> Word Wrap\" in the composer window.  I think you can turn it off \nglobally, but patches aren't a big enough part of my workflow that I've \ninvestigated it too much.\n-- \nBoyd Stephen Smith Jr.                   ,= ,-_-. =.\nbss@iguanasuicide.net                   ((_/)o o(\\_))\nICQ: 514984 YM/AIM: DaTwinkDaddy         `-'(. .)`-'\nhttp://iguanasuicide.net/                    \\_/\n\n\n"},{"id":"103846","messageId":"alpine.DEB.1.00.0902091543380.10279@pacific.mpi-cbg.de","threadId":"17642","inReplyTo":"49903501.7060308@beonex.com","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-09T14:49:07Z","receivedAt":"2009-02-09T14:49:07Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Feb 2009, Ben Bucksch wrote:\n\n> In newer Thunderbirds, you can mark / select a text, and when you hit reply,\n> it (and only that) will be quoted - called selective quote.\n\nWhich would require the _recipient_ to choose Thunderbird, newer ones, as \ntheir mail program.\n\nHey, it is a free world, I like Firefox, for example, and you would have \nto rip it out of my dead, cold hands.\n\nI just do not care for Thunderbird, I started using pine a long time \nago, too long to change now, but that is just my choice, I guess.\n\nIt's just for that really important workflow -- sending patches as easily \ncommentable text that still works as input to GNU patch or git-apply -- \nthat I will recommend against using Thunderbird, as there are other \nmailers which can do it without much clickety-click.\n\nBTW in contrast to other people, I do not feel insulted that you chose Hg \nfor Mozilla; as I said, it is a free world (as long as we can keep it that \nway, at least).\n\nCiao,\nDscho\n"},{"id":"103850","messageId":"49904DE7.2080205@codeweavers.com","threadId":"17642","inReplyTo":"49903B27.8070608@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-09T15:38:15Z","receivedAt":"2009-02-09T15:38:15Z","isPatch":true,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":"> \n> I don't know how you're injecting the email to Thunderbird. mailto:?\n\nWe have a utility, git-imap-send, that sends the email into the drafts\nfolder.\n\n> \n> What you propose is a header, not a body.\n> (I'm a bit irritated that TB would react to a charset header *in the \n> body*, but maybe that's a hack specially for charsets, in some code part \n> I don't know, given that they are unfortunately sometimes only marked in \n> content.)\n\nAh, rats.  I figured that picking charset out of the body might be\nconsidered a bug; I was hoping it was a feature :-/.\n\n> \n> I think it would most likely work easily if you inject HTML (read before \n> you scream):\n\n/me carefully takes the nice coat with extra long sleeves out <grin>.\n\nI've tried this, and *shudder*, it appears to work.\n\nI'll cobble up an experimental patch to git-format-patch to see if\nthis is tractable.\n\nCheers,\n\nJeremy\n"},{"id":"103854","messageId":"49905071.6030805@drmicha.warpmail.net","threadId":"17642","inReplyTo":"49903B27.8070608@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-09T15:49:05Z","receivedAt":"2009-02-09T15:49:05Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Currently, git-notes barks when asked to show an empty (i.e.\nnon-existing) note. Change this to explicitly say there is none.\n\nSigned-off-by: Michael J Gruber \n---\n git-notes.sh     |    2 ++\n t/t3301-notes.sh |    2 +-\n 2 files changed, 3 insertions(+), 1 deletions(-)\n\n\nBen Bucksch venit, vidit, dixit 09.02.2009 15:18:\n> On 09.02.2009 14:52, Jeremy White wrote:\n>   \n>> I discovered that if I just injected charset=iso-2022-jp, format=flowed\n>> would stay off!<grin>\n>>    \n>>     \n> (This was a hack, caused by the different use of spaces in Japanese / \n> CJK, which means a different kind of \"flow\".)\n>\n>   \n>> Ben, along those lines, we do have the ability to control the entire \n>> body of a possible patch before Thunderbird sees it. Would it be \n>> possible, or reasonable, for Thunderbird to look for and preserve a \n>> 'format=fixed' setting inside a body that we generated?\n>>     \n>\n> I don't know how you're injecting the email to Thunderbird. mailto:?\n>\n>   \ngit comes with a contributed hint which suggests using the external\neditor extension. There's also a script which shuffles things around and\ninto place for TB to accept the header lines. Alternatively, call vim as\nthe external editor....\n> What you propose is a header, not a body.\n> (I'm a bit irritated that TB would react to a charset header *in the \n> body*, but maybe that's a hack specially for charsets, in some code part \n> I don't know, given that they are unfortunately sometimes only marked in \n> content.)\n>\n> I think it would most likely work easily if you inject HTML (read before \n> you scream):\n> mailto:fred@example.com?html-body=Here's patch revision abc from repo \n> def:<p><pre>Patch: file ....<br>+++ bla<br>line 3<br></pre>\n> (properly escaped, of course)\n> It should invoke the normal rich editor, with the patch properly marked \n> as preformatted. Once you send it, it would send it as plaintext, \n> depending on your prefs. During the formatting, it would see the \n> preformat section and should send it out with the lineendings as marked.\n> I haven't tried the full chain, but it's something to play with.\n>\n> Ben\n>   \nOK, for the first time in I don't know how many months/years I fire up\nthe HTML composer in TB. Please don't tell anyone from my git\nacquaintances, they'll give me an even tougher rub than usual on my next\npatch submission...\n\nI'll try and inline with <pre> a patch I sent resently... Now this looks\ninteresting after coming back from external editor (gvim -f). Kinda\ncute. We'll see what TB makes out of it (hopefully confirming Ben's\npre-theory, uhm).\n\nCheers,\nMichael\n\n\ndiff --git a/git-notes.sh b/git-notes.sh\nindex bfdbaa8..9cbad02 100755\n--- a/git-notes.sh\n+++ b/git-notes.sh\n@@ -58,6 +58,8 @@ edit)\n \t\t\"$GIT_NOTES_REF\" $NEW_HEAD $CURRENT_HEAD\n ;;\n show)\n+\tgit rev-parse -q --verify \"$GIT_NOTES_REF\":$COMMIT > /dev/null ||\n+\t\tdie \"No note for commit $COMMIT.\"\n \tgit show \"$GIT_NOTES_REF\":$COMMIT\n ;;\n *)\ndiff --git a/t/t3301-notes.sh b/t/t3301-notes.sh\nindex 7ef1c29..ff4ea05 100755\n--- a/t/t3301-notes.sh\n+++ b/t/t3301-notes.sh\n@@ -36,7 +36,7 @@ test_expect_success 'need valid notes ref' '\n '\n \n # 1 indicates caught gracefully by die, 128 means git-show barked\n-test_expect_failure 'handle empty notes gracefully' '\n+test_expect_success 'handle empty notes gracefully' '\n \tgit notes show ; test 1 = $?\n '\n \n-- \n1.6.1.2.253.ga34a\n"},{"id":"103856","messageId":"4990519C.8060601@drmicha.warpmail.net","threadId":"17642","inReplyTo":"49904DE7.2080205@codeweavers.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-09T15:54:04Z","receivedAt":"2009-02-09T15:54:04Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Jeremy White venit, vidit, dixit 09.02.2009 16:38:\n...\n> I've tried this, and *shudder*, it appears to work.\n> \n> I'll cobble up an experimental patch to git-format-patch to see if\n> this is tractable.\n\nPlease don't forget quoting of \"<,>\" as I did, see my other experimental\npost where the s-o-b address got lost in translation (from HTML to\ntext). I don't remember what else you need to quote within <pre></pre>.\n\nMichael\n"},{"id":"103859","messageId":"499058B4.4070009@beonex.com","threadId":"17642","inReplyTo":"4990519C.8060601@drmicha.warpmail.net","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T16:24:20Z","receivedAt":"2009-02-09T16:24:20Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 16:54, Michael J Gruber wrote:\n> I don't remember what else you need to quote within<pre></pre>.\n>    \n\nEscaping:\n\nWith mailto:, you send HTML (SGML) in a URL.\n\nSo, you first have to quote using HTML rules:\n<   -> &lt;\n >   -> &gt;\n&   -> &amp;\n\"   -> &quot;\n\nIf that's not done, TB/Mozilla may or may not fix it up: e.g. if you \nhave html tags in your source code, it would probably go wrong without \nquoting.\n\nAfter that, given that you put it in a URL, you need to escape it using \n\"URL component rules\" (same as you escape any URL GET parameter), using \nthe %charcode rule, e.g.\n(space)  ->   %20\n=   ->   %3D\n&   ->   %26\n#   ->   %23\n(Firefox does the URL escaping automatically when putting it in the \nURLbar, and you can also try it in JS using encodeURIComponent(), e.g. \nby opening the Firefox Error Console and writing \nencodeURIComponent(\"foo=bla&bar=baz bal\"); or starting the \nyourfirefoxdir/js runner.)\n\nE.g. \"<\" in original turns into \"mailto:?html-body=<pre>%26lt;<pre>\"\n\nSorry that it's non-trivial (I also hate escaping).\n"},{"id":"103865","messageId":"4990709B.90401@codeweavers.com","threadId":"17642","inReplyTo":"499058B4.4070009@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-09T18:06:19Z","receivedAt":"2009-02-09T18:06:19Z","isPatch":true,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":"> So, you first have to quote using HTML rules:\n> <   -> &lt;\n>  >   -> &gt;\n> &   -> &amp;\n> \"   -> &quot;\n\nThanks; that was helpful.\n\nI've sent an experimental patch for further discussion (I even sent it\nusing my patch + Thunderbird, and now I'm carefully studying my navel\n<grin>).\n\nCheers,\n\nJeremy\n"},{"id":"103870","messageId":"qXxPO6LuQr7-9QoWMdojOMbuADIJ55oaOVr5t_8eLGR9vvNpW72wyA@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"499058B4.4070009@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T18:54:11Z","receivedAt":"2009-02-09T18:54:11Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"\nI have an issue with Thunderbird that I'd like to describe while we have\nthe developers ear.\n\nI was sent a patch which had a sequence of control characters in it.\n\nTo save an emailed patch, I normally write click in the message body and\nchoose 'Save As...'.  Thunderbird populates the 'Name:' field for the\nname of the saved file with a name based on the subject, which I like.\n\nBut, in this case, Thunderbird corrupted the original message and saved\nsomething that was not equivalent to what was sent.  Naturally, the patch\ncould not be applied, and after investigating, it was determined that\nThunderbird was responsible.  If I instead choose View -> 'Message Source'\nand then in the window that pops up choose File -> 'Save Page As', and then\ngive it a name, I do indeed get the original uncorrupted message, but it\nis _not_ convenient.\n\nThis is Thunderbird v2.0.0.19.\nIs this a bug? Or is there something I can set or disable so that Thunderbird\nsaves the original contents when right clicking in the message body and\nselecting 'Save As...'?\n\nI will follow up with an example patch which has the control characters in\nit.\n\n-brandon\n"},{"id":"103874","messageId":"DeLj68ft_x4lptmQlhZ5lQ5LBbgPdNcz06DmtnLJcFKD5nu8axMNuOaPuPCY01o2T5l4qnB7a3o@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"499058B4.4070009@beonex.com","subject":"[PATCH] example patch corrupted by thunderbird","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T19:00:10Z","receivedAt":"2009-02-09T19:00:10Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"This is an example patch which is corrupted when saved using Thunderbird\nv2.0.0.19.\n\n---\ndiff --git a/autoconf.m4f b/autoconf.m4f\nnew file mode 100644\nindex 0000000..73283b5\n--- /dev/null\n+++ b/autoconf.m4f\n@@ -0,0 +1,6 @@\n+T31,23\n+m4_location(_AC_LIST_MEMBER_IF)autoconf/fortran.m4:115\n+T17,203\n+m4_cr_not_Letters\u0001\u0002\u0003\u0004\u0005\u0006\u0007\b\t\n+\u000b\f\r\u000e\u000f\u0010\u0011\u0012\u0013\u0014\u0015\u0016\u0017\u0018\u0019\u001a\u001b\u001c\u001d\u001e\u001f !\"#$%&'()*+,./0123456789:;<=>?@[\\]^_`{|}~€‚ƒ„…†‡ˆ‰Š‹ŒŽ‘’“”•–—˜™š›œžŸ ¡¢£¤¥¦§¨©ª«¬­®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõö÷øùúûüýþÿ-\n+T15,855\n-- \n1.6.1.239.gcf3bf\n"},{"id":"103873","messageId":"49907F75.2050100@beonex.com","threadId":"17642","inReplyTo":"qXxPO6LuQr7-9QoWMdojOMbuADIJ55oaOVr5t_8eLGR9vvNpW72wyA@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T19:09:41Z","receivedAt":"2009-02-09T19:09:41Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 19:54, Brandon Casey wrote:\n> I will follow up with an example patch which has the control characters in\n> it.\n>    \n\nI can only advise against sending patches in the bodies, sorry. Bodies \nare for human-language text. Attachments are for files like diffs, and \nare preserved. Attachments with \"Content-Disposition: inline\" are for \nattachments which are supposed to be read directly in the email reader, \nlike is the case here.\n\nI guess that other, console-based email software won't deal with inline \nattachments as nicely, but the major email clients do. Instead of trying \nto do something that's going to be fruitless - email bodies are never \ngoing to be character-to-character identical, because there are many \ndemands on formatting (up to graphical smiles) and from many different \nlanguages (charsets, like seems to be the problem here) on it by users \n-, I think your better route for success would be to use inline \nattachments and fix the software which can't deal with *that* properly, \nincluding display and quoting.\n\nSorry to brush you off, but I this is a battle we can't win, either way. \nToo many demands from too many sides.\n\nBen\n"},{"id":"103875","messageId":"alpine.DEB.1.00.0902092013260.10279@pacific.mpi-cbg.de","threadId":"17642","inReplyTo":"49907F75.2050100@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-09T19:14:22Z","receivedAt":"2009-02-09T19:14:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Feb 2009, Ben Bucksch wrote:\n\n> On 09.02.2009 19:54, Brandon Casey wrote:\n> > I will follow up with an example patch which has the control \n> > characters in it.\n\nYou can use a mailer such as Alpine, which has no problems with patches \nlike that whatsoever.\n\nEspecially the \"Save\" command will save the byte-identical body of the \nmail.\n\nCiao,\nDscho\n"},{"id":"103877","messageId":"4990820B.504@beonex.com","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902092013260.10279@pacific.mpi-cbg.de","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T19:20:43Z","receivedAt":"2009-02-09T19:20:43Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 20:14, Johannes Schindelin wrote:\n> On 09.02.2009 19:54, Brandon Casey wrote:\n>>> I will follow up with an example patch which has the control\n>>> characters in it.\n>>>        \n\n> Especially the \"Save\" command will save the byte-identical body of the\n> mail.\n>    \n\nI think Thunderbird will also save a byte-identical copy of the mail, if \nyou use File | Save... and use \".eml\" (for email = RFC822) file extension.\n\nThe dialog is sensitive to the file extension and determines the format \nbased on that, but is unfortunately not communicative about it.\n\nIf you save as HTML (.html) or plaintext (.txt), it runs it through the \nMIME converters and reformats it for display / human reading.\n"},{"id":"103879","messageId":"kzzjRvB2M5uliRiLEqrN04NicW1QU3nr34zZu0lEAhdLiv9YxvOrsw@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"49907F75.2050100@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T19:22:40Z","receivedAt":"2009-02-09T19:22:40Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 19:54, Brandon Casey wrote:\n>> I will follow up with an example patch which has the control\n>> characters in\n>> it.\n\n<snip>\n> email bodies are never\n> going to be character-to-character identical, because there are many\n> demands on formatting (up to graphical smiles) and from many different\n> languages (charsets, like seems to be the problem here) on it by users\n> -,\n\nI can understand that the display of the message would not be optimal, and\ncould be different from what the sender intended, but I expect that the\nsaved version would be identical to the original.\n\nIn the 'graphical smilie' example, you still save colon-close-parenthesis\nin the file don't you? and not the little smiley face bitmap?\n\n> I think your better route for success would be to use inline\n> attachments and fix the software which can't deal with *that* properly,\n> including display and quoting.\n\nIt's not the display part that causes a problem for me, it's the \"saving\" part.\nThe displayed gobledygook is fine.  The saved gobledygook is not.\n\nWhy doesn't Thunderbird just save out the raw message?\n\n-brandon\n"},{"id":"103880","messageId":"r57oMSnamWCJ1G1-r98G6mYQjX0YNpQz1OzEBHSrDifmBU_ir2P77A@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"4990820B.504@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T19:30:56Z","receivedAt":"2009-02-09T19:30:56Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 20:14, Johannes Schindelin wrote:\n>> On 09.02.2009 19:54, Brandon Casey wrote:\n>>>> I will follow up with an example patch which has the control\n>>>> characters in it.\n>>>>        \n> \n>> Especially the \"Save\" command will save the byte-identical body of the\n>> mail.\n>>    \n> \n> I think Thunderbird will also save a byte-identical copy of the mail, if\n> you use File | Save... and use \".eml\" (for email = RFC822) file extension.\n\nDid you try it with the message I sent titled\n'[PATCH] example patch corrupted by thunderbird'?\n\nThe body of the patch has 1 hunk which adds 6 lines.\n\nWhen I save with Thunderbird, part of what was on line 5 is now\non another line and the control-M is missing.  At least that is\nwhat is apparent to me.\n\n> The dialog is sensitive to the file extension and determines the format\n> based on that, but is unfortunately not communicative about it.\n\nI did not modify the suggested file name.  The saved file has a '.eml'\nextension.\n\n> If you save as HTML (.html) or plaintext (.txt), it runs it through the\n> MIME converters and reformats it for display / human reading.\n\nNope, '.eml' extension.\n\n-brandon\n"},{"id":"103881","messageId":"RD8dEuXN_TYvtiDHum-mdwL3m_eJP49xWrl9-YgiLfhOFN6weRXVhg@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902092013260.10279@pacific.mpi-cbg.de","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T19:33:21Z","receivedAt":"2009-02-09T19:33:21Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Johannes Schindelin wrote:\n> Hi,\n> \n> On Mon, 9 Feb 2009, Ben Bucksch wrote:\n> \n>> On 09.02.2009 19:54, Brandon Casey wrote:\n>>> I will follow up with an example patch which has the control \n>>> characters in it.\n> \n> You can use a mailer such as Alpine, which has no problems with patches \n> like that whatsoever.\n\nYes, that's my work-around.  Though it's pine, we're not modern enough to\nhave alpine.\n\n-brandon\n"},{"id":"103882","messageId":"49908927.2030408@beonex.com","threadId":"17642","inReplyTo":"r57oMSnamWCJ1G1-r98G6mYQjX0YNpQz1OzEBHSrDifmBU_ir2P77A@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T19:51:03Z","receivedAt":"2009-02-09T19:51:03Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 20:30, Brandon Casey wrote:\n> Did you try it with the message I sent titled\n> '[PATCH] example patch corrupted by thunderbird'?\n\nI tried now, and none of the editors/viewers I tried are displaying \nanything that would come close to readable to me, even if you count \nclearly marked hex character codes as readable. I tried less, e3 and \nkwrite. Therefore, a) I can't verify whether the result is correct or \nnot b) I declare this an edge case.\n\n> When I save with Thunderbird, part of what was on line 5 is now\n> on another line and the control-M is missing.\n> Nope, '.eml' extension.\n>    \n\nThat would be a bug. If you save as .eml, it should save exactly what's \nin your IMAP mailbox or what View as source | File | Save... saves. If \nit doesn't do that, it's a bug.\n\nThe View Source workaround may be inconvenient, but is a workaround for \nsuch a strong edgecase, until this bug is fixed. Don't hope for it, \nthough, because TB is working on completely different things, like a \nmessage database.\n\nYou're welcome to file a bug, but please without political statements or \nbroad generic demands. TB is geared towards comfortable writing and \nreading of human language text.\n\n---\n\nApart from that, I can only recommend that you re-consider sending \npatches as inline attachments (Content-Disposition: inline, which is an \nofficial Internet Standard since many years), which is IMHO correctly \nreflecting reality, and fixing the software which can't deal with \n*that*, including inline display and quoting.\n\nBen\n"},{"id":"103884","messageId":"49908B1A.7040101@beonex.com","threadId":"17642","inReplyTo":"49908927.2030408@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T19:59:22Z","receivedAt":"2009-02-09T19:59:22Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 20:51, Ben Bucksch wrote:\n> On 09.02.2009 20:30, Brandon Casey wrote:\n>> Did you try it with the message I sent titled\n>> '[PATCH] example patch corrupted by thunderbird'?\n>\n> I tried now, and none of the editors/viewers I tried are displaying \n> anything that would come close to readable to me, even if you count \n> clearly marked hex character codes as readable. I tried less, e3 and \n> kwrite. Therefore, a) I can't verify whether the result is correct or not\n\nI now compared the result of File | Save as.... (main menu, not context \nmenu) | \"1.eml\" with the email on the cyrus server, and they are \nidentical (diff and md5sum). So, TB *does* save it correctly, byte-for-byte.\n"},{"id":"103885","messageId":"alpine.DEB.1.00.0902092105230.10279@pacific.mpi-cbg.de","threadId":"17642","inReplyTo":"RD8dEuXN_TYvtiDHum-mdwL3m_eJP49xWrl9-YgiLfhOFN6weRXVhg@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-09T20:09:06Z","receivedAt":"2009-02-09T20:09:06Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Feb 2009, Brandon Casey wrote:\n\n> Johannes Schindelin wrote:\n> > Hi,\n> > \n> > On Mon, 9 Feb 2009, Ben Bucksch wrote:\n> > \n> >> On 09.02.2009 19:54, Brandon Casey wrote:\n> >>> I will follow up with an example patch which has the control \n> >>> characters in it.\n> > \n> > You can use a mailer such as Alpine, which has no problems with patches \n> > like that whatsoever.\n> \n> Yes, that's my work-around.  Though it's pine, we're not modern enough to\n> have alpine.\n\nBTW it seems that a few people misunderstood my comments.\n\nJust to clarify: I am happy if a lot of non-technical people use \nThunderbird.  I mean, I am happy for them.\n\nIf it is too complicated for Thunderbird to accomodate the workflow \nrequired on our mailing list, however, I will have to recommend another \ntool to the people who want to contribute to Git.\n\nI would not recommend emacs to a vim user, either.  Or vice versa.\n\nIn other words: use the right tool.  Or, as somebody put it at the \nGitTogether: to a hammer, everything looks like a nail.\n\nCiao,\nDscho\n"},{"id":"103898","messageId":"kCHkjagMqmrTXbd229odxLGt0neIkfVZDCJPnhpXGVU71q9GcXEmPw@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"49908B1A.7040101@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T21:03:06Z","receivedAt":"2009-02-09T21:03:06Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 20:51, Ben Bucksch wrote:\n>> On 09.02.2009 20:30, Brandon Casey wrote:\n>>> Did you try it with the message I sent titled\n>>> '[PATCH] example patch corrupted by thunderbird'?\n>>\n>> I tried now, and none of the editors/viewers I tried are displaying\n>> anything that would come close to readable to me, even if you count\n>> clearly marked hex character codes as readable. I tried less, e3 and\n>> kwrite. Therefore, a) I can't verify whether the result is correct or not\n\nYou could look to see whether there are 6 lines in the hunk or 7.\nThere should only be 6.\n\n  i.e. something like:\n\n  @@ -0,0 +1,6 @@\n  +T31,23\n  +m4_location(_AC_LIST_MEMBER_IF)autoconf/fortran.m4:115\n  +T17,203\n  +m4_cr_not_Letters<sequence_of_control_characters>\n  +<more_control_characters>\n  +T15,855\n  --\n\nI have attached the original patch.  The headers will be different, and in the\nattached patch they are only placeholders, but the content after the '---' should\nbe identical in all versions.\n\n> I now compared the result of File | Save as.... (main menu, not context\n> menu)\n\nmain menu or context menu both produce the same results for me.\nDo they produce different results for you?\n\n> | \"1.eml\" with the email on the cyrus server, and they are\n> identical (diff and md5sum). So, TB *does* save it correctly,\n> byte-for-byte.\n\nSorry, but I think you did your comparison wrong.  Possibly the tool\nwhich extracted the email from the cyrus server performed the same\ntransformation that Thunderbird does.\n\nYou can also make a comparison with what is saved when you do\n'View | Message Source' which pops up a new window, and then\nFile | Save Page As...\n\nFor me, they produce two different results. The one produced by\n'View | Message Source ..etc' has a message body which is identical to\nthe one saved by pine, and to the original which is attached.\n\n-brandon\n\n\n\nFrom 9ad60e2f109029f8c96fcdc111625017cb8f3ef2 Mon Sep 17 00:00:00 2001\nFrom: Brandon Casey <casey@nrlssc.navy.mil>\nDate: Wed, 14 Jan 2009 07:24:52 -0600\nSubject: [PATCH] example patch corrupted by thunderbird\n\nThis is an example patch which is corrupted when saved using Thunderbird\nv2.0.0.19.\n\n---\ndiff --git a/autoconf.m4f b/autoconf.m4f\nnew file mode 100644\nindex 0000000..73283b5\n--- /dev/null\n+++ b/autoconf.m4f\n@@ -0,0 +1,6 @@\n+T31,23\n+m4_location(_AC_LIST_MEMBER_IF)autoconf/fortran.m4:115\n+T17,203\n+m4_cr_not_Letters\u0001\u0002\u0003\u0004\u0005\u0006\u0007\b\t\n+\u000b\f\r\u000e\u000f\u0010\u0011\u0012\u0013\u0014\u0015\u0016\u0017\u0018\u0019\u001a\u001b\u001c\u001d\u001e\u001f !\"#$%&'()*+,./0123456789:;<=>?@[\\]^_`{|}~��������������������������������������������������������������������������������������������������������������������������������-\n+T15,855\n-- \n1.6.1.239.gcf3bf\n\n"},{"id":"103899","messageId":"ETlfXBMFfZL-7tLQFmhi6s6YyecTtgDf2lVB2bz_UJPJrilAieJmXw@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"kCHkjagMqmrTXbd229odxLGt0neIkfVZDCJPnhpXGVU71q9GcXEmPw@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T21:07:39Z","receivedAt":"2009-02-09T21:07:39Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Brandon Casey wrote:\n> Ben Bucksch wrote:\n\n>> | \"1.eml\" with the email on the cyrus server, and they are\n>> identical (diff and md5sum). So, TB *does* save it correctly,\n>> byte-for-byte.\n> \n> Sorry, but I think you did your comparison wrong.\n\nOr possibly (hopefully) there is something in my configuration that\nis causing this, and it can be unset or set, whichever is the case.\n\nThough my configuration is not much changed from the defaults.\n\n-brandon\n"},{"id":"103911","messageId":"4990A7D6.5090709@beonex.com","threadId":"17642","inReplyTo":"kCHkjagMqmrTXbd229odxLGt0neIkfVZDCJPnhpXGVU71q9GcXEmPw@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T22:01:58Z","receivedAt":"2009-02-09T22:01:58Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 22:03, Brandon Casey wrote:\n> > So, TB *does* save it correctly, byte-for-byte.\n>\n> Sorry, but I think you did your comparison wrong.  Possibly the tool\n> which extracted the email from the cyrus server performed the same\n> transformation that Thunderbird does.\n>    \n\nNo. Cyrus stores each mail in its own file. All I did was:\nTB | File | Save as.... | \"1.eml\"\nscp root@<imap server>:/<mailbox store path>/<mail folder path>/749\\. 2.eml\nmd5sum 1.eml 2.eml\nb98d288357e384b8f58fe332ed65748b  1.eml\nb98d288357e384b8f58fe332ed65748b  2.eml\n(the md5sum will be different for you, as my mail contains the Received: \nheaders from my server.)\nGiven that I don't think TB changes the email on the server, what TB \nsaved is exactly what I received, verbatim, on the wire.\n"},{"id":"103913","messageId":"1quO9vKdveU3UD9xhBB6YkuoBUyUsLvXylSjOkZKRByKfUxgId9fwQ@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"4990A7D6.5090709@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T22:13:36Z","receivedAt":"2009-02-09T22:13:36Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 22:03, Brandon Casey wrote:\n>> > So, TB *does* save it correctly, byte-for-byte.\n>>\n>> Sorry, but I think you did your comparison wrong.  Possibly the tool\n>> which extracted the email from the cyrus server performed the same\n>> transformation that Thunderbird does.\n>>    \n> \n> No. Cyrus stores each mail in its own file. All I did was:\n> TB | File | Save as.... | \"1.eml\"\n> scp root@<imap server>:/<mailbox store path>/<mail folder path>/749\\. 2.eml\n> md5sum 1.eml 2.eml\n> b98d288357e384b8f58fe332ed65748b  1.eml\n> b98d288357e384b8f58fe332ed65748b  2.eml\n> (the md5sum will be different for you, as my mail contains the Received:\n> headers from my server.)\n> Given that I don't think TB changes the email on the server, what TB\n> saved is exactly what I received, verbatim, on the wire.\n\nAny thoughts on why I get different results from\n\n  TB | File | Save as... | 1.eml\n\nand\n\n  TB | View | Message Source ... File | Save Page as | 2.eml\n\n-brandon\n"},{"id":"103917","messageId":"4990AD62.1030102@beonex.com","threadId":"17642","inReplyTo":"1quO9vKdveU3UD9xhBB6YkuoBUyUsLvXylSjOkZKRByKfUxgId9fwQ@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T22:25:38Z","receivedAt":"2009-02-09T22:25:38Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 23:13, Brandon Casey wrote:\n> Any thoughts on why I get different results from\n>    TB | File | Save as... | 1.eml\n>\n> and\n>\n>    TB | View | Message Source ... File | Save Page as | 2.eml\n>    \nNo. View source is expected to have pretty printing, at least in the \nbrowser (shared code), maybe that interferes.\n(Confirmed - the latter gives me a different result, too.)\nBut if the latter doesn't work, just don't use it :).\n"},{"id":"103918","messageId":"LPqf-HWrLRqzpr9F2D3QXUFfkpclYxx-y3jCNxZ6UAc@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"4990AD62.1030102@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-09T22:28:48Z","receivedAt":"2009-02-09T22:28:48Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 23:13, Brandon Casey wrote:\n>> Any thoughts on why I get different results from\n>>    TB | File | Save as... | 1.eml\n>>\n>> and\n>>\n>>    TB | View | Message Source ... File | Save Page as | 2.eml\n>>    \n> No. View source is expected to have pretty printing, at least in the\n> browser (shared code), maybe that interferes.\n> (Confirmed - the latter gives me a different result, too.)\n> But if the latter doesn't work, just don't use it :).\n\nBut it's the latter one that gives me the *correct* results. :b\n\n-brandon\n"},{"id":"103921","messageId":"4990B086.10804@beonex.com","threadId":"17642","inReplyTo":"49903521.1060101@codeweavers.com","subject":"Re: Thunderbird and patches","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T22:39:02Z","receivedAt":"2009-02-09T22:39:02Z","isPatch":false,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"Summary of proposed/possible solutions:\n\n    * TB | normal msg viewer | main menu | File | Save As | File |\n      \"foo.eml\" saves the verbatim, on the wire RFC822 mail\n      (that may include quoted printable etc., though, so verbatim may\n      not actually be what you want)\n    * You can turn off format=flowed during sending, if it disturbs you:\n         1. Prefs | Advanced | General | Config Editor...\n         2. \"mailnews.send_plaintext_flowed\" = false\n    * Jeremy White has a patch for git-imap-send to work around TB's\n      body reformatting, by inserting a preformatted (<pre>) section.\n\n(Other solutions, involves other software:)\n\n    * I strong suggest to send inline attachments (Content-Disposition:\n      inline, RFC 2183 [1], Internet Standard), because patches are\n      arguably files, and the body is for human language text.\n      Therefore, it's an attachment that you want to see inline,\n      therefore inline attachment is the IMHO correct solution.\n      If some mailers cannot handle this comfortably (display inline,\n      quote), maybe you can also advocate having *them* fixed.\n\n\n[1] <http://www.apps.ietf.org/rfc/rfc2183.html>\n"},{"id":"103923","messageId":"4990B24A.4000801@beonex.com","threadId":"17642","inReplyTo":"LPqf-HWrLRqzpr9F2D3QXUFfkpclYxx-y3jCNxZ6UAc@cipher.nrlssc.navy.mil","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T22:46:34Z","receivedAt":"2009-02-09T22:46:34Z","isPatch":true,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 23:28, Brandon Casey wrote:\n> But it's the latter one that gives me the *correct* results. :b\n>    \nOh. As I showed, File | Save As... in normal msg viewer works here.\nWhen I save in View Source, the file is different, and diff -u shows \nevery line different, and diff -uw shows no difference. Therefore, I \nthink it's the line ending.\n\nFWIW, I'm on Linux, in case TB adapts to the system line ending in one \ncase and not in the other, which may explain the difference between what \nwe see.\n\n/me just realizes that he's talking with the military.\n"},{"id":"103925","messageId":"4990B446.2070705@codeweavers.com","threadId":"17642","inReplyTo":"4990B086.10804@beonex.com","subject":"Re: Thunderbird and patches","fromName":"Jeremy White","fromEmail":"jwhite@codeweavers.com","sentAt":"2009-02-09T22:55:02Z","receivedAt":"2009-02-09T22:55:02Z","isPatch":false,"sender":{"key":"jwhite@codeweavers.com","avatar":"https://avatars.githubusercontent.com/u/1063742?v=4"},"body":">     * I strong suggest to send inline attachments (Content-Disposition:\n>       inline, RFC 2183 [1], Internet Standard), because patches are\n>       arguably files, and the body is for human language text.\n>       Therefore, it's an attachment that you want to see inline,\n>       therefore inline attachment is the IMHO correct solution.\n>       If some mailers cannot handle this comfortably (display inline,\n>       quote), maybe you can also advocate having *them* fixed.\n\n\nSo, I start an email in Thunderbird, and attach test.patch to it.\nI don't see a way to control things, but it seems to go across as\na multipart; the patch is disposition inline, type of text/x-patch.  I\nrename it to test.txt, and now it goes across as a multipart, both parts\nare text/plain.\n\nI get the patch, and I can see it.  Very nice.\n\nI click 'Reply', and I get no quoting in Thunderbird.  (A quick check\nwith mutt *does* show quoting.)\n\nI'm hazarding a guess that is not the expected result; am I doing it wrong?\n\nCheers,\n\nJeremy\n"},{"id":"103926","messageId":"4990B5DC.7070006@beonex.com","threadId":"17642","inReplyTo":"4990B446.2070705@codeweavers.com","subject":"Re: Thunderbird and patches","fromName":"Ben Bucksch","fromEmail":"ben.bucksch.news@beonex.com","sentAt":"2009-02-09T23:01:48Z","receivedAt":"2009-02-09T23:01:48Z","isPatch":false,"sender":{"key":"ben.bucksch.news@beonex.com","avatar":null},"body":"On 09.02.2009 23:55, Jeremy White wrote:\n> [inline attachments]\n>\n> I get the patch, and I can see it. Very nice.\n> I click 'Reply', and I get no quoting in Thunderbird.  (A quick check\n> with mutt *does* show quoting.)\n>    \nYeah. As mentioned before, you have to press Ctrl-A first (Select All, \nin combination with the new selective quoting feature in TB 3).\nYou can also select only a smaller portion of the patch, then only that \nwill be quoted.\nLast but not least, you can quote via copy & paste: select in view, then \nmenu | Edit | Paste as quotation.\n\nHTH,\n\nBen\n"},{"id":"103938","messageId":"Ce-i8YGodObEhlk_H5OxuxM3Cl-9xyMV3FsGyHWSuA3PTJS_jkfSig@cipher.nrlssc.navy.mil","threadId":"17642","inReplyTo":"4990B24A.4000801@beonex.com","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-02-10T01:00:05Z","receivedAt":"2009-02-10T01:00:05Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Ben Bucksch wrote:\n> On 09.02.2009 23:28, Brandon Casey wrote:\n>> But it's the latter one that gives me the *correct* results. :b\n>>    \n> Oh. As I showed, File | Save As... in normal msg viewer works here.\n> When I save in View Source, the file is different, and diff -u shows\n> every line different, and diff -uw shows no difference. Therefore, I\n> think it's the line ending.\n\nFor me diff -u shows a removal of one line and an insertion of two lines\nat the same location.  The ^M has been converted into a newline.\n\n> FWIW, I'm on Linux, in case TB adapts to the system line ending in one\n> case and not in the other, which may explain the difference between what\n> we see.\n\nAlso using linux here.\n\nWould Thunderbird possibly do a blind conversion of ^M to newline?\n\n-brandon\n"},{"id":"103941","messageId":"7v3aenrrtx.fsf@gitster.siamese.dyndns.org","threadId":"17642","inReplyTo":"498E50E2.8050309@codeweavers.com","subject":"Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-10T01:41:46Z","receivedAt":"2009-02-10T01:41:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeremy White <jwhite@codeweavers.com> writes:\n\n> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\n> index 11a7d77..2e8e94e 100644\n> --- a/Documentation/git-format-patch.txt\n> +++ b/Documentation/git-format-patch.txt\n> @@ -174,7 +174,8 @@ CONFIGURATION\n>  -------------\n>  You can specify extra mail header lines to be added to each message\n>  in the repository configuration, new defaults for the subject prefix\n> -and file suffix, and number patches when outputting more than one.\n> +and file suffix, control attachements, and number patches when outputting\n> +more than one.\n>  \n>  ------------\n>  [format]\n> @@ -183,6 +184,7 @@ and file suffix, and number patches when outputting more than one.\n>  \tsuffix = .txt\n>  \tnumbered = auto\n>  \tcc = <email>\n> +\tattach [ = mime-boundary-string ]\n>  ------------\n\nOnce you added this configuration, if you ever wanted to defeat it for a\nsingle invocation, how would you do so?  Edit the configuration file\nagain?\n\nNot that I am objecting to the patch, as I am unlikely to have such a\nconfiguration, but are there people who need to send attachment sometimes\nbut not other times?  They can say --attach from the command line without\nadding the configuraiton if they send their patch non-attached more often\nthan as an attachment, but if they most of the time need to attach but\nsometimes need to send in-line, they do not have an easy way to do so.\n"},{"id":"103960","messageId":"499151C9.7090502@drmicha.warpmail.net","threadId":"17642","inReplyTo":"alpine.DEB.1.00.0902092105230.10279@pacific.mpi-cbg.de","subject":"Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-10T10:07:05Z","receivedAt":"2009-02-10T10:07:05Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Johannes Schindelin venit, vidit, dixit 09.02.2009 21:09:\n> Hi,\n> \n> On Mon, 9 Feb 2009, Brandon Casey wrote:\n> \n>> Johannes Schindelin wrote:\n>>> Hi,\n>>>\n>>> On Mon, 9 Feb 2009, Ben Bucksch wrote:\n>>>\n>>>> On 09.02.2009 19:54, Brandon Casey wrote:\n>>>>> I will follow up with an example patch which has the control \n>>>>> characters in it.\n>>> You can use a mailer such as Alpine, which has no problems with patches \n>>> like that whatsoever.\n>> Yes, that's my work-around.  Though it's pine, we're not modern enough to\n>> have alpine.\n> \n> BTW it seems that a few people misunderstood my comments.\n> \n> Just to clarify: I am happy if a lot of non-technical people use \n> Thunderbird.  I mean, I am happy for them.\n> \n> If it is too complicated for Thunderbird to accomodate the workflow \n> required on our mailing list, however, I will have to recommend another \n> tool to the people who want to contribute to Git.\n> \n> I would not recommend emacs to a vim user, either.  Or vice versa.\n> \n> In other words: use the right tool.  Or, as somebody put it at the \n> GitTogether: to a hammer, everything looks like a nail.\n\nIt just seems that the workflow \"required\" here on the git list is the\nway it is because it caters for differently abled MUAs which can't\nhandle certain standards (inline disposition) efficiently. Mutt\nobviously can, so it's not a matter of John Doe's MUA versus geeky MUAs.\n\nThunderbird is differently abled also, of course, by way of definition,\nbut also because there's no easy way to directly feed an e-mail (or a\nbunch of them) into a shell command such as git-am, e.g. So it certainly\nwon't be a maintainer's MUA.\n\nWhen I joined the git community I adjusted my personal workflow, which\nrequired posting by e-mail rather than nntp (gmane) and avoiding the\nnatural way (attachments) for patch submission, even avoiding my main\nstandards compliant MUA; rather than arguing for a change to the better,\nmore standard conforming approach, and telling people here to use MUAs\nwhich can deal with it, i.e.: use the right tool. I know things won't\nchange here, just as certain people won't either.\n\nBut please don't take the status quo here as something setting global\nstandards. And don't take my conformance with the requirements here as\napproval.\n\nBen has shown remarkable willingness in helping get around the\nlimitations of sending out patch files plainly included in e-mails, when\nusing TB, so let's please focus on making that successful and keep the\nflame(r)s off this thread. Everyone will benefit, because it will keep\nthe number of misformed patches (i.e. not matching local requirements) low.\n\nMichael\n"},{"id":"104341","messageId":"buo4oz0e0dg.fsf@dhlpc061.dev.necel.com","threadId":"17642","inReplyTo":"499151C9.7090502@drmicha.warpmail.net","subject":"Re: Thunderbird and patches","fromName":"Miles Bader","fromEmail":"miles@gnu.org","sentAt":"2009-02-12T04:37:47Z","receivedAt":"2009-02-12T04:37:47Z","isPatch":false,"sender":{"key":"miles@gnu.org","avatar":"https://gravatar.com/avatar/01069b69593af7bff28e2f97afeb3644ae6fe2f5f56cb3a8cf34c5fb8c36efe5?d=mp&s=160"},"body":"Michael J Gruber <git@drmicha.warpmail.net> writes:\n>> In other words: use the right tool.  Or, as somebody put it at the \n>> GitTogether: to a hammer, everything looks like a nail.\n>\n> It just seems that the workflow \"required\" here on the git list is the\n> way it is because it caters for differently abled MUAs which can't\n> handle certain standards (inline disposition) efficiently.  Mutt\n> obviously can, so it's not a matter of John Doe's MUA versus geeky\n> MUAs.\n\nSo, since you decry flames later in your message, why did you feel it\nnecessary to throw in this rather creaky bit of flamebait?\n\n[The issue is apparently MUAs which munge messages when not wanted; that\nsays _nothing_ about what non-munging MUAs can or can not \"handle\".]\n\n-Miles\n\n-- \nMayonnaise, n. One of the sauces that serve the French in place of a state\nreligion.\n"},{"id":"104361","messageId":"4993F4D3.1060501@drmicha.warpmail.net","threadId":"17642","inReplyTo":"buo4oz0e0dg.fsf@dhlpc061.dev.necel.com","subject":"Re: Thunderbird and patches","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-02-12T10:07:15Z","receivedAt":"2009-02-12T10:07:15Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Miles Bader venit, vidit, dixit 12.02.2009 05:37:\n> Michael J Gruber <git@drmicha.warpmail.net> writes:\n>>> In other words: use the right tool.  Or, as somebody put it at the \n>>> GitTogether: to a hammer, everything looks like a nail.\n>> It just seems that the workflow \"required\" here on the git list is the\n>> way it is because it caters for differently abled MUAs which can't\n>> handle certain standards (inline disposition) efficiently.  Mutt\n>> obviously can, so it's not a matter of John Doe's MUA versus geeky\n>> MUAs.\n> \n> So, since you decry flames later in your message, why did you feel it\n> necessary to throw in this rather creaky bit of flamebait?\n> \n> [The issue is apparently MUAs which munge messages when not wanted; that\n> says _nothing_ about what non-munging MUAs can or can not \"handle\".]\n\nI think we all (all who participated so far) agreed that the MUAs we\ntalked about have different abilities, thus are differently abled (pun\nintended).\n\nBy now, all sides have worked constructively together to make things\nwork for all MUAs and all users. Dscho even cooked up a Thunderbird\nextension, Ben provided input for git-imap-send.\n\nIf you want to fuel the flames you're too late. If you want to\ncontribute you're welcome to.\n\nMichael\n"}]}