{"thread":{"id":"17579","subject":"[PATCH] Makefile: minor improvements for Mac OS X (Darwin)","startedAt":"2009-02-05T06:09:08Z","lastAt":"2009-02-05T06:50:15Z","messageCount":2,"participants":["Jay Soffian","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"103272","messageId":"1233814148-67700-1-git-send-email-jaysoffian@gmail.com","threadId":"17579","inReplyTo":null,"subject":"[PATCH] Makefile: minor improvements for Mac OS X (Darwin)","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2009-02-05T06:09:08Z","receivedAt":"2009-02-05T06:09:08Z","isPatch":true,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"1) Instead of requesting OLD_ICONV on all Mac OS X versions except for 10.5\n(which will break when 10.6 is released), exlicitly request it for versions\nolder than 10.5.\n\n2) NO_STRLCPY is not needed since Mac OS X 10.2. Noticed by Benjamin Kramer.\n\nNote that uname -r returns the underlying Darwin version, which can be mapped\nto Mac OS X version at http://www.opensource.apple.com/darwinsource/\n\nSigned-off-by: Jay Soffian <jaysoffian@gmail.com>\n---\nThis patch incorporates gmane 106991. Hopefully it was okay to squash in the\nother minor change as well.\n\n Makefile |    6 ++++--\n 1 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 830143e..77f1083 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -652,10 +652,12 @@ endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n-\tifneq ($(shell expr \"$(uname_R)\" : '9\\.'),2)\n+\tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n \t\tOLD_ICONV = UnfortunatelyYes\n \tendif\n-\tNO_STRLCPY = YesPlease\n+\tifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n+\t\tNO_STRLCPY = YesPlease\n+\tendif\n \tNO_MEMMEM = YesPlease\n \tTHREADED_DELTA_SEARCH = YesPlease\n endif\n-- \n1.6.1.2.331.g6c1bc\n"},{"id":"103278","messageId":"7viqnpidi0.fsf@gitster.siamese.dyndns.org","threadId":"17579","inReplyTo":"1233814148-67700-1-git-send-email-jaysoffian@gmail.com","subject":"Re: [PATCH] Makefile: minor improvements for Mac OS X (Darwin)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-05T06:50:15Z","receivedAt":"2009-02-05T06:50:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; will apply directly to master to see if anybody screams, as I do\nnot have access to any OSX machine.\n"}]}