{"thread":{"id":"17528","subject":"[PATCH] http-push: add back underscore separator before lock token","startedAt":"2009-02-03T13:07:26Z","lastAt":"2009-02-04T07:47:34Z","messageCount":2,"participants":["Tay Ray Chuan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"102957","messageId":"4988418E.4000808@gmail.com","threadId":"17528","inReplyTo":null,"subject":"[PATCH] http-push: add back underscore separator before lock token","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-02-03T13:07:26Z","receivedAt":"2009-02-03T13:07:26Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"The patch dated Sat, 31 Jan, \"[PATCH] http-push: refactor request url\ncreation\" inadvertently removed the underscore separator between the\nobject path and the appended lock token.\n\nThis patch adds it back.\n\nThis would be keeping in line with the aforementioned patch's objective\nof refactoring, without changing the behaviour and effect, of the code.\n\nThis would also be useful for testing if the lock token has been\nindeed appended to the object url.\n\nSigned-off-by: Tay Ray Chuan <rctay89@gmail.com>\n---\n\n http-push.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 54c62d4..eefd64c 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -557,6 +557,7 @@ static void start_put(struct transfer_request *request)\n \trequest->dest = strbuf_detach(&buf, NULL);\n\n \tappend_remote_object_url(&buf, remote->url, hex, 0);\n+\tstrbuf_addstr(&buf, \"_\");\n \tstrbuf_addstr(&buf, request->lock->token);\n \trequest->url = strbuf_detach(&buf, NULL);\n\n-- \n1.6.1.2.278.g9a9e.dirty\n"},{"id":"103078","messageId":"7vskmu3ap5.fsf@gitster.siamese.dyndns.org","threadId":"17528","inReplyTo":"4988418E.4000808@gmail.com","subject":"Re: [PATCH] http-push: add back underscore separator before lock token","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-04T07:47:34Z","receivedAt":"2009-02-04T07:47:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; I should have caught it while reviewing.\n"}]}