{"thread":{"id":"17479","subject":"[PATCH JGIT] fix typo","startedAt":"2009-01-31T14:26:07Z","lastAt":"2009-02-01T12:42:56Z","messageCount":3,"participants":["Yann Simon","Robin Rosenberg","Baz"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"102700","messageId":"1233411967.8213.4.camel@localhost","threadId":"17479","inReplyTo":null,"subject":"[PATCH JGIT] fix typo","fromName":"Yann Simon","fromEmail":"yann.simon.fr@gmail.com","sentAt":"2009-01-31T14:26:07Z","receivedAt":"2009-01-31T14:26:07Z","isPatch":true,"sender":{"key":"yann.simon.fr@gmail.com","avatar":"https://gravatar.com/avatar/2d926895d27ac988c5c8e591887e5a6a4c7036390403c74fce92519119b887a0?d=mp&s=160"},"body":"fix a little typo\nSigned-off-by: Yann Simon <yann.simon.fr@gmail.com>\n---\n .../src/org/spearce/jgit/lib/WindowedFile.java     |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\nb/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\nindex 5eb8465..1ff8caa 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n@@ -61,7 +61,7 @@\n  * before any single byte can be accessed.\n  * </p>\n  * <p>\n- * Using a specific MapMode will avoid the complete copy by mmaping in\nthe\n+ * Using a specific MapMode will avoid the complete copy by mapping in\nthe\n  * operating system's file buffers, however this may cause problems if\na large\n  * number of windows are being heavily accessed as the Java garbage\ncollector\n  * may not be able to unmap old windows fast enough to permit new\nwindows to be\n-- \n1.6.0.6\n"},{"id":"102704","messageId":"200901311745.16803.robin.rosenberg@dewire.com","threadId":"17479","inReplyTo":"1233411967.8213.4.camel@localhost","subject":"Re: [PATCH JGIT] fix typo","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-31T16:45:16Z","receivedAt":"2009-01-31T16:45:16Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"lördag 31 januari 2009 15:26:07 skrev Yann Simon:\n> fix a little typo\n> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>\n> ---\n>  .../src/org/spearce/jgit/lib/WindowedFile.java     |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n\nCleanups are nice too, but please try to follow the existing\nstyle when it comes to comments. I don't think we have\nstated these implicit rules anywhere.\n\n- New sentences start with a capital letter.\n- Don't repeat yourself You do not need a body in the comment \nif the first line says it all, except the SOB line which technically\nis part of the body.\n- Make sure there is an empty line before the SOB line.\n\nCheers,\n\t-- robin\n"},{"id":"102753","messageId":"2faad3050902010442v6f64b804l79689245c6a60ff4@mail.gmail.com","threadId":"17479","inReplyTo":"1233411967.8213.4.camel@localhost","subject":"Re: [PATCH JGIT] fix typo","fromName":"Baz","fromEmail":"brian.ewins@gmail.com","sentAt":"2009-02-01T12:42:56Z","receivedAt":"2009-02-01T12:42:56Z","isPatch":true,"sender":{"key":"brian.ewins@gmail.com","avatar":"https://gravatar.com/avatar/9ac03d89105e50a7151e695a1b4b1228151064ec3ac380a73b74ab397796baf7?d=mp&s=160"},"body":"2009/1/31 Yann Simon <yann.simon.fr@gmail.com>:\n> fix a little typo\n> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>\n> ---\n>  .../src/org/spearce/jgit/lib/WindowedFile.java     |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n> b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n> index 5eb8465..1ff8caa 100644\n> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n> @@ -61,7 +61,7 @@\n>  * before any single byte can be accessed.\n>  * </p>\n>  * <p>\n> - * Using a specific MapMode will avoid the complete copy by mmaping in\n> the\n> + * Using a specific MapMode will avoid the complete copy by mapping in\n\nIs this actually a typo? java.nio being used to mmap() files here (see\nthe later use of mmap in this class), its more informative and common\nto use the double m to describe that. I'd have said the typo was at\nthe end of the comment, ie \"fast enough to permit new windows to be\nmapped.\" should read \"fast enough to permit new windows to be\nmmapped.\"\n\n> the\n>  * operating system's file buffers, however this may cause problems if\n> a large\n>  * number of windows are being heavily accessed as the Java garbage\n> collector\n>  * may not be able to unmap old windows fast enough to permit new\n> windows to be\n> --\n> 1.6.0.6\n>\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n"}]}