{"thread":{"id":"17439","subject":"[PATCH] t3411: Fix test 1 for case-insensitive file systems","startedAt":"2009-01-29T16:00:16Z","lastAt":"2009-02-04T02:09:54Z","messageCount":17,"participants":["Brian Gernhardt","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"102471","messageId":"1233244816-67565-1-git-send-email-benji@silverinsanity.com","threadId":"17439","inReplyTo":null,"subject":"[PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-01-29T16:00:16Z","receivedAt":"2009-01-29T16:00:16Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"The call to \"git reset --hard B1\" failed on case-insensitive file\nsystems (such as the default settings for HFS+) because there was both\na tag \"B1\" and a file \"b1\".  Adding \"--\" to the command makes it\nclear that we mean commit B1.\n\nSigned-off-by: Brian Gernhardt <benji@silverinsanity.com>\n---\n t/t3411-rebase-preserve-around-merges.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t3411-rebase-preserve-around-merges.sh b/t/t3411-rebase-preserve-around-merges.sh\nindex 6533505..e544451 100755\n--- a/t/t3411-rebase-preserve-around-merges.sh\n+++ b/t/t3411-rebase-preserve-around-merges.sh\n@@ -24,7 +24,7 @@ test_expect_success 'setup' '\n \ttest_commit A1 &&\n \ttest_commit B1 &&\n \ttest_commit C1 &&\n-\tgit reset --hard B1 &&\n+\tgit reset --hard B1 -- &&\n \ttest_commit D1 &&\n \ttest_merge E1 C1 &&\n \ttest_commit F1\n-- \n1.6.1.2.418.gd79e6.dirty\n"},{"id":"102473","messageId":"alpine.DEB.1.00.0901291713140.3586@pacific.mpi-cbg.de","threadId":"17439","inReplyTo":"1233244816-67565-1-git-send-email-benji@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-01-29T16:13:30Z","receivedAt":"2009-01-29T16:13:30Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 29 Jan 2009, Brian Gernhardt wrote:\n\n> The call to \"git reset --hard B1\" failed on case-insensitive file\n> systems (such as the default settings for HFS+) because there was both\n> a tag \"B1\" and a file \"b1\".  Adding \"--\" to the command makes it\n> clear that we mean commit B1.\n> \n> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>\n\nSigh.\n\nACK and thanks,\nDscho\n"},{"id":"102477","messageId":"7vocxqf2sf.fsf@gitster.siamese.dyndns.org","threadId":"17439","inReplyTo":"1233244816-67565-1-git-send-email-benji@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-29T17:19:28Z","receivedAt":"2009-01-29T17:19:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brian Gernhardt <benji@silverinsanity.com> writes:\n\n> The call to \"git reset --hard B1\" failed on case-insensitive file\n> systems (such as the default settings for HFS+) because there was both\n> a tag \"B1\" and a file \"b1\".  Adding \"--\" to the command makes it\n> clear that we mean commit B1.\n>\n> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>\n> ---\n>  t/t3411-rebase-preserve-around-merges.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t3411-rebase-preserve-around-merges.sh b/t/t3411-rebase-preserve-around-merges.sh\n> index 6533505..e544451 100755\n> --- a/t/t3411-rebase-preserve-around-merges.sh\n> +++ b/t/t3411-rebase-preserve-around-merges.sh\n> @@ -24,7 +24,7 @@ test_expect_success 'setup' '\n>  \ttest_commit A1 &&\n>  \ttest_commit B1 &&\n>  \ttest_commit C1 &&\n> -\tgit reset --hard B1 &&\n> +\tgit reset --hard B1 -- &&\n>  \ttest_commit D1 &&\n>  \ttest_merge E1 C1 &&\n>  \ttest_commit F1\n\nIt is not just B1 that is ambiguous, even though that is the only\nambiguous one this particular test uses.\n\nIf we really wanted to care about case-folding file systems, shouldn't we\nmake test_commit shell function a bit more than the downcasing?  How about\nthis patch instead?\n\n t/test-lib.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git c/t/test-lib.sh w/t/test-lib.sh\nindex c1839f7..8066c25 100644\n--- c/t/test-lib.sh\n+++ w/t/test-lib.sh\n@@ -201,7 +201,7 @@ test_tick () {\n # Both <file> and <contents> default to <message>.\n \n test_commit () {\n-\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n+\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n \techo \"${3-$1}\" > \"$file\" &&\n \tgit add \"$file\" &&\n \ttest_tick &&\n"},{"id":"102479","messageId":"alpine.DEB.1.00.0901291831360.3586@pacific.mpi-cbg.de","threadId":"17439","inReplyTo":"7vocxqf2sf.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-01-29T17:33:56Z","receivedAt":"2009-01-29T17:33:56Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 29 Jan 2009, Junio C Hamano wrote:\n\n> Brian Gernhardt <benji@silverinsanity.com> writes:\n> \n> > The call to \"git reset --hard B1\" failed on case-insensitive file\n> > systems (such as the default settings for HFS+) because there was both\n> > a tag \"B1\" and a file \"b1\".  Adding \"--\" to the command makes it\n> > clear that we mean commit B1.\n> >\n> > Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>\n> > ---\n> >  t/t3411-rebase-preserve-around-merges.sh |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> >\n> > diff --git a/t/t3411-rebase-preserve-around-merges.sh b/t/t3411-rebase-preserve-around-merges.sh\n> > index 6533505..e544451 100755\n> > --- a/t/t3411-rebase-preserve-around-merges.sh\n> > +++ b/t/t3411-rebase-preserve-around-merges.sh\n> > @@ -24,7 +24,7 @@ test_expect_success 'setup' '\n> >  \ttest_commit A1 &&\n> >  \ttest_commit B1 &&\n> >  \ttest_commit C1 &&\n> > -\tgit reset --hard B1 &&\n> > +\tgit reset --hard B1 -- &&\n> >  \ttest_commit D1 &&\n> >  \ttest_merge E1 C1 &&\n> >  \ttest_commit F1\n> \n> It is not just B1 that is ambiguous, even though that is the only\n> ambiguous one this particular test uses.\n> \n> If we really wanted to care about case-folding file systems, shouldn't we\n> make test_commit shell function a bit more than the downcasing?  How about\n> this patch instead?\n> \n>  t/test-lib.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git c/t/test-lib.sh w/t/test-lib.sh\n> index c1839f7..8066c25 100644\n> --- c/t/test-lib.sh\n> +++ w/t/test-lib.sh\n> @@ -201,7 +201,7 @@ test_tick () {\n>  # Both <file> and <contents> default to <message>.\n>  \n>  test_commit () {\n> -\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n> +\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n\nOr\n\n\tfile=${2:-$1.file}\n\nbut I was not quite sure about the impact; I might have checked for \nspecific filenames.\n\nBrian, if you would have the time to go through the tests if an automatic \nfilename was used, that would be smashing!  (We cannot just run the tests \nand look at the failures, as absence of files could be tested; I don't \nremember, debugging zlib/valgrind currently turns my brain into tatties.)\n\nCiao,\nDscho\n"},{"id":"102492","messageId":"673CE949-5DF9-4970-A739-AA09FCD26D24@silverinsanity.com","threadId":"17439","inReplyTo":"7vocxqf2sf.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-01-29T19:10:41Z","receivedAt":"2009-01-29T19:10:41Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:\n\n> If we really wanted to care about case-folding file systems,  \n> shouldn't we\n> make test_commit shell function a bit more than the downcasing?  How  \n> about\n> this patch instead?\n\nThat's a good point.  Always good to prevent future issues.\n\n> test_commit () {\n> -\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n> +\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n> \techo \"${3-$1}\" > \"$file\" &&\n> \tgit add \"$file\" &&\n> \ttest_tick &&\n\nAdded this and ran through the tests.  Works for me. :-D\n\nTested-by: Brian Gernhardt <benji@silverinsanity.com> (HFS+ on Mac OS  \n10.5.6)\n"},{"id":"102969","messageId":"1E104E1B-BFCC-4CFC-9D53-CE89299C9600@silverinsanity.com","threadId":"17439","inReplyTo":"673CE949-5DF9-4970-A739-AA09FCD26D24@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-02-03T15:07:03Z","receivedAt":"2009-02-03T15:07:03Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"This change appears to have been forgotten, but does fix the problems  \nI was having.  Junio, can this make it into the official repo instead  \nof floating around in my local?  I'd send in a patch, but it was your  \ncode and I don't want to take credit for it.\n\n~~ Brian\n\nOn Jan 29, 2009, at 2:10 PM, Brian Gernhardt wrote:\n\n>\n> On Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:\n>\n>> If we really wanted to care about case-folding file systems,  \n>> shouldn't we\n>> make test_commit shell function a bit more than the downcasing?   \n>> How about\n>> this patch instead?\n>\n> That's a good point.  Always good to prevent future issues.\n>\n>> test_commit () {\n>> -\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n>> +\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n>> \techo \"${3-$1}\" > \"$file\" &&\n>> \tgit add \"$file\" &&\n>> \ttest_tick &&\n>\n> Added this and ran through the tests.  Works for me. :-D\n>\n> Tested-by: Brian Gernhardt <benji@silverinsanity.com> (HFS+ on Mac  \n> OS 10.5.6)\n"},{"id":"102985","messageId":"alpine.DEB.1.00.0902031752230.6573@intel-tinevez-2-302","threadId":"17439","inReplyTo":"1E104E1B-BFCC-4CFC-9D53-CE89299C9600@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-03T16:53:55Z","receivedAt":"2009-02-03T16:53:55Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 3 Feb 2009, Brian Gernhardt wrote:\n\n> This change appears to have been forgotten, but does fix the problems I \n> was having.  Junio, can this make it into the official repo instead of \n> floating around in my local?  I'd send in a patch, but it was your code \n> and I don't want to take credit for it.\n\n\n\nTop-poster!\n\n\nBesides, I think that my latest comment still stands there: testing is not \ngood enough, code inspection is required if something expects the file \nnames as they used to be.\n\nCiao,\nDscho\n"},{"id":"102992","messageId":"2D4586A6-ADAC-4B6E-8B42-2CBD76E0304C@silverinsanity.com","threadId":"17439","inReplyTo":"alpine.DEB.1.00.0902031752230.6573@intel-tinevez-2-302","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-02-03T17:11:01Z","receivedAt":"2009-02-03T17:11:01Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote:\n\n> On Tue, 3 Feb 2009, Brian Gernhardt wrote:\n>\n>> This change appears to have been forgotten, but does fix the  \n>> problems I\n>> was having.  Junio, can this make it into the official repo instead  \n>> of\n>> floating around in my local?  I'd send in a patch, but it was your  \n>> code\n>> and I don't want to take credit for it.\n>\n> Top-poster!\n\nWell, yes.  I wasn't replying to anything in the e-mail, I just wanted  \nto bring it back to attention.\n\n> Besides, I think that my latest comment still stands there: testing  \n> is not\n> good enough, code inspection is required if something expects the file\n> names as they used to be.\n\nAs far as I can tell, no test relies on the auto-generated name of the  \ntest file.  In fact, only t3411 uses that feature at all and it only  \nperforms operations on commits.  All other uses of test_commit give a  \nfilename (even though many of them don't appear to use the file).\n\n~~ Brian\n"},{"id":"102994","messageId":"alpine.DEB.1.00.0902031817260.6573@intel-tinevez-2-302","threadId":"17439","inReplyTo":"2D4586A6-ADAC-4B6E-8B42-2CBD76E0304C@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-03T17:18:50Z","receivedAt":"2009-02-03T17:18:50Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 3 Feb 2009, Brian Gernhardt wrote:\n\n> \n> On Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote:\n> \n> >On Tue, 3 Feb 2009, Brian Gernhardt wrote:\n> >\n> > >This change appears to have been forgotten, but does fix the problems \n> > >I was having.  Junio, can this make it into the official repo instead \n> > >of floating around in my local?  I'd send in a patch, but it was your \n> > >code and I don't want to take credit for it.\n> >\n> >Top-poster!\n> \n> Well, yes.  I wasn't replying to anything in the e-mail, I just wanted to\n> bring it back to attention.\n\nYou did, in fact, refer a little bit to the content of the thread you were \nreplying to.\n\n> >Besides, I think that my latest comment still stands there: testing is not\n> >good enough, code inspection is required if something expects the file\n> >names as they used to be.\n> \n> As far as I can tell, no test relies on the auto-generated name of the test\n> file.  In fact, only t3411 uses that feature at all and it only performs\n> operations on commits.  All other uses of test_commit give a filename (even\n> though many of them don't appear to use the file).\n\nYou did not look far.\n\nCiao,\nDscho\n"},{"id":"102997","messageId":"5FE034E8-422F-4692-AD37-5633C91A4B98@silverinsanity.com","threadId":"17439","inReplyTo":"alpine.DEB.1.00.0902031817260.6573@intel-tinevez-2-302","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-02-03T17:43:06Z","receivedAt":"2009-02-03T17:43:06Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Feb 3, 2009, at 12:18 PM, Johannes Schindelin wrote:\n\n> On Tue, 3 Feb 2009, Brian Gernhardt wrote:\n>\n>> On Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote:\n>>\n>>> Besides, I think that my latest comment still stands there:  \n>>> testing is not\n>>> good enough, code inspection is required if something expects the  \n>>> file\n>>> names as they used to be.\n>>\n>> As far as I can tell, no test relies on the auto-generated name of  \n>> the test\n>> file.  In fact, only t3411 uses that feature at all and it only  \n>> performs\n>> operations on commits.  All other uses of test_commit give a  \n>> filename (even\n>> though many of them don't appear to use the file).\n>\n> You did not look far.\n\nIf there's something I missed, could you perhaps say what it is  \ninstead of being cryptic?  I have a day job and am attempting to  \nsqueeze in searching for this between tasks.  This fix (or similar)  \nneeds to make it into master so that the tests can run on case- \ninsensitive file systems.\n\nI used git grep to find uses of test_commit in next, and the only uses  \nthat did not provide a file name argument were in t3411.  I read  \nthrough every test in the file, and the only operations I saw were  \ntest_commit, test_merge, checkout -b, reset without filenames, rebase,  \nand rev-parse.  All operations on commits, not files.\n\nThe tests all run properly, and I've run t3411 individually (since  \nit's apparently the only one using this feature) using -v to ensure  \nthat it was actually performing work and it seems to be.\n\nSo, based on the above, every usage of test_commit either provides a  \nfile name or does not care about the names of the files.  Unless you  \nhave something that says it isn't, I'd like to see the fix Junio gave  \napplied (repeated here as a reminder):\n\nOn Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:\n\n> diff --git c/t/test-lib.sh w/t/test-lib.sh\n> index c1839f7..8066c25 100644\n> --- c/t/test-lib.sh\n> +++ w/t/test-lib.sh\n> @@ -201,7 +201,7 @@ test_tick () {\n> # Both <file> and <contents> default to <message>.\n>\n> test_commit () {\n> -\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n> +\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n> \techo \"${3-$1}\" > \"$file\" &&\n> \tgit add \"$file\" &&\n> \ttest_tick &&\n"},{"id":"103008","messageId":"alpine.DEB.1.00.0902031918520.9822@pacific.mpi-cbg.de","threadId":"17439","inReplyTo":"5FE034E8-422F-4692-AD37-5633C91A4B98@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-03T18:19:58Z","receivedAt":"2009-02-03T18:19:58Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 3 Feb 2009, Brian Gernhardt wrote:\n\n> On Feb 3, 2009, at 12:18 PM, Johannes Schindelin wrote:\n> \n> >You did not look far.\n> \n> If there's something I missed, could you perhaps say what it is instead \n> of being cryptic?\n\n$ git grep -l test_commit junio/next -- t/\njunio/next:t/README\njunio/next:t/t1450-fsck.sh\njunio/next:t/t3410-rebase-preserve-dropped-merges.sh\njunio/next:t/t3411-rebase-preserve-around-merges.sh\njunio/next:t/t3412-rebase-root.sh\njunio/next:t/test-lib.sh\n\nBut I understood.  I will audit the code myself later this evening.\n\nCiao,\nDscho\n"},{"id":"103010","messageId":"34FE2049-0A81-4615-AE3D-46DE35A44011@silverinsanity.com","threadId":"17439","inReplyTo":"alpine.DEB.1.00.0902031918520.9822@pacific.mpi-cbg.de","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-02-03T18:42:03Z","receivedAt":"2009-02-03T18:42:03Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Feb 3, 2009, at 1:19 PM, Johannes Schindelin wrote:\n\n> $ git grep -l test_commit junio/next -- t/\n> junio/next:t/README\n> junio/next:t/t1450-fsck.sh\n> junio/next:t/t3410-rebase-preserve-dropped-merges.sh\n> junio/next:t/t3411-rebase-preserve-around-merges.sh\n> junio/next:t/t3412-rebase-root.sh\n> junio/next:t/test-lib.sh\n\nI examined all of those files.  I looked at every line that calls  \ntest_commit.  All of those files except for t34110-rebase-preserve- \naround-merges.sh provide a filename of their own and are therefore  \nunaffected by the change\n\nOn Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:\n\n> -\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z')}\n> +\tfile=${2:-$(echo \"$1\" | tr 'A-Z' 'a-z').t}\n\nUse \"git grep\" without the -l and you will see that all uses outside  \nof t3411 are of the form \"test_commit <commit> <filename>\".  Only  \nt3411 uses the form \"test_commit <commit>\" (without filename), which  \nis when this change would matter.  And t3411 does not use the  \ngenerated filename, only the resultant commits.\n\nI was irritated by your statement that I \"did not look far\" because _I  \nread all those files_.  I gave you the result of reading them which  \nyou seem to have completely ignored, as it was the part of my last e- \nmail that you did not quote.\n\nIf you want to double-check me, fine.  But do not claim I did not do  \nthe work.\n\n~~ Brian\n"},{"id":"103013","messageId":"7vy6wn9wdj.fsf@gitster.siamese.dyndns.org","threadId":"17439","inReplyTo":"34FE2049-0A81-4615-AE3D-46DE35A44011@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-03T19:02:48Z","receivedAt":"2009-02-03T19:02:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brian Gernhardt <benji@silverinsanity.com> writes:\n\n> I was irritated by your statement that I \"did not look far\" because _I\n> read all those files_.  I gave you the result of reading them which\n> you seem to have completely ignored, as it was the part of my last e-\n> mail that you did not quote.\n>\n> If you want to double-check me, fine.  But do not claim I did not do\n> the work.\n\nThanks, both, and let's not be unnecessarily un-nice to each other.\n\nI agree that Dscho's \"far enough\" comment was not the best way to say \"I\nreally want to make sure you did verify the way I would myself\", but\nplease just let it pass, pretend that he just expressed frustration on his\nlack of time to do the verification himself with that comment.  Ok?\n\nThe thing is, nobody active in git land is paid to work on git.  You\ndon't, Dscho doesn't and I neither.\n\nI'll try to find time myself to triple check if you two want to, even\nthough it is known that I often get tripped by the same kind of\nbrain-slippage as Dscho when Dscho does get tripped, so my auditing might\nnot add much to the collective confidence level ;-).\n"},{"id":"103015","messageId":"DB993E35-9F82-4451-B681-D1BFE3E9BD45@silverinsanity.com","threadId":"17439","inReplyTo":"7vy6wn9wdj.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-02-03T19:12:47Z","receivedAt":"2009-02-03T19:12:47Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Feb 3, 2009, at 2:02 PM, Junio C Hamano wrote:\n\n> Brian Gernhardt <benji@silverinsanity.com> writes:\n>\n>> I was irritated by your statement that I \"did not look far\" because  \n>> _I\n>> read all those files_.  I gave you the result of reading them which\n>> you seem to have completely ignored, as it was the part of my last e-\n>> mail that you did not quote.\n>>\n>> If you want to double-check me, fine.  But do not claim I did not do\n>> the work.\n>\n> Thanks, both, and let's not be unnecessarily un-nice to each other.\n>\n> I agree that Dscho's \"far enough\" comment was not the best way to  \n> say \"I\n> really want to make sure you did verify the way I would myself\", but\n> please just let it pass, pretend that he just expressed frustration  \n> on his\n> lack of time to do the verification himself with that comment.  Ok?\n\nFair enough.  My own word choice wasn't exactly wise, either.  This  \nhas been an especially frustrating day for me in many other respects  \nand it's affected my commentary here.\n\nDscho, my apologies.\n\n~~ Brian\n"},{"id":"103020","messageId":"alpine.DEB.1.00.0902032115570.9822@pacific.mpi-cbg.de","threadId":"17439","inReplyTo":"DB993E35-9F82-4451-B681-D1BFE3E9BD45@silverinsanity.com","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-03T20:16:13Z","receivedAt":"2009-02-03T20:16:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 3 Feb 2009, Brian Gernhardt wrote:\n\n> On Feb 3, 2009, at 2:02 PM, Junio C Hamano wrote:\n> \n> >Brian Gernhardt <benji@silverinsanity.com> writes:\n> >\n> > >I was irritated by your statement that I \"did not look far\" because _I\n> > >read all those files_.  I gave you the result of reading them which\n> > >you seem to have completely ignored, as it was the part of my last e-\n> > >mail that you did not quote.\n> > >\n> > >If you want to double-check me, fine.  But do not claim I did not do\n> > >the work.\n> >\n> >Thanks, both, and let's not be unnecessarily un-nice to each other.\n> >\n> >I agree that Dscho's \"far enough\" comment was not the best way to say \"I\n> >really want to make sure you did verify the way I would myself\", but\n> >please just let it pass, pretend that he just expressed frustration on his\n> >lack of time to do the verification himself with that comment.  Ok?\n> \n> Fair enough.  My own word choice wasn't exactly wise, either.  This has been\n> an especially frustrating day for me in many other respects and it's affected\n> my commentary here.\n> \n> Dscho, my apologies.\n\nAccepted, and mine to you.\n\nCiao,\nDscho\n"},{"id":"103021","messageId":"alpine.DEB.1.00.0902032132130.9822@pacific.mpi-cbg.de","threadId":"17439","inReplyTo":"7vy6wn9wdj.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-02-03T20:38:45Z","receivedAt":"2009-02-03T20:38:45Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 3 Feb 2009, Junio C Hamano wrote:\n\n> I'll try to find time myself to triple check if you two want to, even \n> though it is known that I often get tripped by the same kind of \n> brain-slippage as Dscho when Dscho does get tripped, so my auditing \n> might not add much to the collective confidence level ;-).\n\nThanks ;-)\n\nI inspected all files that git grep -p showed me, and I see that t3412 \nuses the file names, but passes explicit parameters to test_commit for \nthem.  So that is fine, too.\n\nJust as a matter of preference, I'd not downcase, but instead append a \n\".file\" in test_commit, but that's not a strong preference.  (I'd not \ndowncase, because that was done only to prevent the tag to have the same \nname as the file, but that did not work...)\n\nCiao,\nDscho\n"},{"id":"103061","messageId":"7v4ozb9clp.fsf@gitster.siamese.dyndns.org","threadId":"17439","inReplyTo":"alpine.DEB.1.00.0902032132130.9822@pacific.mpi-cbg.de","subject":"Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-02-04T02:09:54Z","receivedAt":"2009-02-04T02:09:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> I inspected all files that git grep -p showed me, and I see that t3412 \n> uses the file names, but passes explicit parameters to test_commit for \n> them.  So that is fine, too.\n>\n> Just as a matter of preference, I'd not downcase, but instead append a \n> \".file\" in test_commit, but that's not a strong preference.  (I'd not \n> downcase, because that was done only to prevent the tag to have the same \n> name as the file, but that did not work...)\n\nAgreed, there is no point to downcase the name.\n"}]}