{"thread":{"id":"1741","subject":"[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin","startedAt":"2005-09-07T03:08:55Z","lastAt":"2005-09-07T19:18:54Z","messageCount":4,"participants":["Mark Allen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"8159","messageId":"20050907030855.9278.qmail@web34313.mail.mud.yahoo.com","threadId":"1741","inReplyTo":null,"subject":"[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin","fromName":"Mark Allen","fromEmail":"mrallen1@yahoo.com","sentAt":"2005-09-07T03:08:55Z","receivedAt":"2005-09-07T03:08:55Z","isPatch":true,"sender":{"key":"mrallen1@yahoo.com","avatar":null},"body":"[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin \n\nThis trivial patch creates $(LIBS) and sets it to iconv in tools/Makefile because MacOS\n10.4 [gcc 4.0] gets cranky about libiconv routines referenced in mailinfo.c\n(convert_to_utf8) and no library pointer to link the symbols against.\n\nI haven't tested this on Linux yet (but I will tomorrow when I get into work).\n\nSigned-off-by: Mark Allen <mrallen1@yahoo.com>\n\n[PATCH] Add LIBS field and populate with iconv to tools/Makefile for Darwin \n\nOS X.4 [gcc 4.0] gets cranky about iconv data structures and no \nlibrary pointer to link the symbols against.\n\nSigned-off-by: Mark Allen <mrallen1@yahoo.com>\n---\n\n tools/Makefile |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\n44865be29a83e2b4b0bf65c6dae427203b7be9b9\ndiff --git a/tools/Makefile b/tools/Makefile\n--- a/tools/Makefile\n+++ b/tools/Makefile\n@@ -7,13 +7,14 @@ ALL_CFLAGS = $(CFLAGS)\n INSTALL=install\n prefix=$(HOME)\n bindir=$(prefix)/bin\n+LIBS=iconv\n # DESTDIR=\n \n PROGRAMS=git-mailsplit git-mailinfo\n SCRIPTS=git-applymbox git-applypatch\n \n git-%: %.c\n-\t$(CC) $(ALL_CFLAGS) -o $@ $(filter %.c,$^)\n+\t$(CC) $(ALL_CFLAGS) -l$(LIBS) -o $@ $(filter %.c,$^)\n \n all: $(PROGRAMS)\n \n"},{"id":"8160","messageId":"7v8xy9bfaj.fsf@assigned-by-dhcp.cox.net","threadId":"1741","inReplyTo":"20050907030855.9278.qmail@web34313.mail.mud.yahoo.com","subject":"Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-07T05:47:00Z","receivedAt":"2005-09-07T05:47:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Allen <mrallen1@yahoo.com> writes:\n\n> This trivial patch creates $(LIBS) and sets it to iconv in\n> tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about\n> libiconv routines referenced in mailinfo.c (convert_to_utf8)\n> and no library pointer to link the symbols against.\n\nI'd do this slightly differently.  Could you take a look at what\nI have in the \"proposed updates\" branch, especially \"Flatten\ntools/ directory\" commit?  What I am aiming for is to have\nplatform specific ifeq() thing in only one place.\n"},{"id":"8163","messageId":"20050907150103.11609.qmail@web34311.mail.mud.yahoo.com","threadId":"1741","inReplyTo":"7v8xy9bfaj.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin","fromName":"Mark Allen","fromEmail":"mrallen1@yahoo.com","sentAt":"2005-09-07T15:01:02Z","receivedAt":"2005-09-07T15:01:02Z","isPatch":true,"sender":{"key":"mrallen1@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> I'd do this slightly differently.  Could you take a look at what\n> I have in the \"proposed updates\" branch, especially \"Flatten\n> tools/ directory\" commit?  What I am aiming for is to have\n> platform specific ifeq() thing in only one place.\n\nLooks good to me, Junio.  There's a very small typo in your commit though. :-)\n\nCheers,\n\n--Mark\n\n---\n\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -149,7 +149,7 @@ else\n        MOZILLA_SHA1=1\n        OPENSSL_LIBSSL=\n endif\n-ifdef NEEDS_SSL_WITH_CRIPTO\n+ifdef NEEDS_SSL_WITH_CRYPTO\n        LIB_4_CRYPTO = -lcrypto -lssl\n else\n        LIB_4_CRYPTO = -lcrypto\n"},{"id":"8170","messageId":"7vd5nk6601.fsf@assigned-by-dhcp.cox.net","threadId":"1741","inReplyTo":"20050907150103.11609.qmail@web34311.mail.mud.yahoo.com","subject":"Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-07T19:18:54Z","receivedAt":"2005-09-07T19:18:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Allen <mrallen1@yahoo.com> writes:\n\n> Looks good to me, Junio.  There's a very small typo in your\n> commit though. :-)\n\nThanks.\n"}]}