{"thread":{"id":"17356","subject":"[EGIT PATCH 2/4] Cleanup ui plugin.xml, replace deprecated elements and attributes","startedAt":"2009-01-25T18:52:15Z","lastAt":"2009-01-25T18:52:18Z","messageCount":4,"participants":["Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"101855","messageId":"1232909538-3279-1-git-send-email-robin.rosenberg@dewire.com","threadId":"17356","inReplyTo":null,"subject":"[EGIT PATCH 1/4] Cleanup ui plugin.xml, refer to interface IResource, not Resource","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-25T18:52:15Z","receivedAt":"2009-01-25T18:52:15Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n org.spearce.egit.ui/plugin.xml |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/plugin.xml b/org.spearce.egit.ui/plugin.xml\nindex e6e3762..0b18f15 100644\n--- a/org.spearce.egit.ui/plugin.xml\n+++ b/org.spearce.egit.ui/plugin.xml\n@@ -170,7 +170,7 @@\n             </adapter>\n          </factory>\n          <factory\n-               adaptableType=\"org.eclipse.core.internal.resources.Resource\"\n+\t       adaptableType=\"org.eclipse.core.resources.IResource\"\n                class=\"org.spearce.egit.ui.internal.factories.GitAdapterFactory\">\n             <adapter\n                   type=\"org.eclipse.team.ui.history.IHistoryPageSource\">\n-- \n1.6.1.285.g35d8b\n"},{"id":"101854","messageId":"1232909538-3279-2-git-send-email-robin.rosenberg@dewire.com","threadId":"17356","inReplyTo":"1232909538-3279-1-git-send-email-robin.rosenberg@dewire.com","subject":"[EGIT PATCH 2/4] Cleanup ui plugin.xml, replace deprecated elements and attributes","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-25T18:52:16Z","receivedAt":"2009-01-25T18:52:16Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n org.spearce.egit.ui/plugin.xml |    9 +++++++--\n 1 files changed, 7 insertions(+), 2 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/plugin.xml b/org.spearce.egit.ui/plugin.xml\nindex 0b18f15..e5c81e5 100644\n--- a/org.spearce.egit.ui/plugin.xml\n+++ b/org.spearce.egit.ui/plugin.xml\n@@ -196,11 +196,16 @@\n \n    <extension point=\"org.eclipse.ui.propertyPages\">\n       <page\n-            objectClass=\"org.eclipse.core.resources.IProject\"\n-            adaptable=\"true\"\n             name=\"%Git\"\n             class=\"org.spearce.egit.ui.internal.preferences.GitProjectPropertyPage\"\n             id=\"org.spearce.egit.ui.preferences.GitProjectPropertyPage\">\n+\t    <enabledWhen>\n+\t\t<adapt type=\"org.eclipse.core.resources.IProject\">\n+\t\t\t<test\n+\t\t    property=\"projectPersistentProperty org.eclipse.team.core.repository\" value=\"org.spearce.egit.core.GitProvider\">\n+\t\t\t</test>\n+\t\t</adapt>\n+\t    </enabledWhen>\n          <filter\n                name=\"projectPersistentProperty\"\n                value=\"org.eclipse.team.core.repository=org.spearce.egit.core.GitProvider\">\n-- \n1.6.1.285.g35d8b\n"},{"id":"101856","messageId":"1232909538-3279-3-git-send-email-robin.rosenberg@dewire.com","threadId":"17356","inReplyTo":"1232909538-3279-2-git-send-email-robin.rosenberg@dewire.com","subject":"[EGIT PATCH 3/4] Add the keyword \"Git\" to the git preferences pages.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-25T18:52:17Z","receivedAt":"2009-01-25T18:52:17Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"If the users searches for \"Git\" in the workspaces preferences, all\ngit related preferences pages will now be found.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n org.spearce.egit.ui/plugin.xml |   20 ++++++++++++++++++--\n 1 files changed, 18 insertions(+), 2 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/plugin.xml b/org.spearce.egit.ui/plugin.xml\nindex e5c81e5..c2b82fd 100644\n--- a/org.spearce.egit.ui/plugin.xml\n+++ b/org.spearce.egit.ui/plugin.xml\n@@ -187,11 +187,19 @@\n       <page name=\"%GitPreferences_HistoryPreferencePage_name\"\n             category=\"org.eclipse.team.ui.TeamPreferences/org.spearce.egit.ui.GitPreferences\"\n             class=\"org.spearce.egit.ui.internal.preferences.HistoryPreferencePage\"\n-            id=\"org.spearce.egit.ui.internal.preferences.HistoryPreferencePage\" />\n+\t    id=\"org.spearce.egit.ui.internal.preferences.HistoryPreferencePage\" >\n+\t    <keywordReference\n+\t\t  id=\"org.spearce.egit.ui.keyword.git\">\n+\t    </keywordReference>\n+\t    </page>\n       <page name=\"%GitPreferences_WindowCachePreferencePage_name\"\n             category=\"org.eclipse.team.ui.TeamPreferences/org.spearce.egit.ui.GitPreferences\"\n             class=\"org.spearce.egit.ui.internal.preferences.WindowCachePreferencePage\"\n-            id=\"org.spearce.egit.ui.internal.preferences.WindowCachePreferencePage\" />\n+\t    id=\"org.spearce.egit.ui.internal.preferences.WindowCachePreferencePage\" >\n+\t    <keywordReference\n+\t\t  id=\"org.spearce.egit.ui.keyword.git\">\n+\t    </keywordReference>\n+      </page>\n    </extension>\n \n    <extension point=\"org.eclipse.ui.propertyPages\">\n@@ -212,6 +220,14 @@\n          </filter>\n       </page>\n    </extension>\n+\n+   <extension point=\"org.eclipse.ui.keywords\">\n+\t  <keyword\n+\t\t\tid=\"org.spearce.egit.ui.keyword.git\"\n+\t\t\tlabel=\"git\">\n+\t  </keyword>\n+   </extension>\n+\n    <extension point=\"org.eclipse.ui.decorators\">\n       <decorator\n             lightweight=\"true\"\n-- \n1.6.1.285.g35d8b\n"},{"id":"101857","messageId":"1232909538-3279-4-git-send-email-robin.rosenberg@dewire.com","threadId":"17356","inReplyTo":"1232909538-3279-3-git-send-email-robin.rosenberg@dewire.com","subject":"[EGIT PATCH 4/4] Retain Eclipse Git preferences page hierarchy without warnings in plugin.xml","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-25T18:52:18Z","receivedAt":"2009-01-25T18:52:18Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n org.spearce.egit.ui/plugin.xml |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/plugin.xml b/org.spearce.egit.ui/plugin.xml\nindex c2b82fd..869108c 100644\n--- a/org.spearce.egit.ui/plugin.xml\n+++ b/org.spearce.egit.ui/plugin.xml\n@@ -185,7 +185,7 @@\n             id=\"org.spearce.egit.ui.GitPreferences\" />\n \n       <page name=\"%GitPreferences_HistoryPreferencePage_name\"\n-            category=\"org.eclipse.team.ui.TeamPreferences/org.spearce.egit.ui.GitPreferences\"\n+\t    category=\"org.spearce.egit.ui.GitPreferences\"\n             class=\"org.spearce.egit.ui.internal.preferences.HistoryPreferencePage\"\n \t    id=\"org.spearce.egit.ui.internal.preferences.HistoryPreferencePage\" >\n \t    <keywordReference\n@@ -193,7 +193,7 @@\n \t    </keywordReference>\n \t    </page>\n       <page name=\"%GitPreferences_WindowCachePreferencePage_name\"\n-            category=\"org.eclipse.team.ui.TeamPreferences/org.spearce.egit.ui.GitPreferences\"\n+\t    category=\"org.spearce.egit.ui.GitPreferences\"\n             class=\"org.spearce.egit.ui.internal.preferences.WindowCachePreferencePage\"\n \t    id=\"org.spearce.egit.ui.internal.preferences.WindowCachePreferencePage\" >\n \t    <keywordReference\n-- \n1.6.1.285.g35d8b\n"}]}