{"thread":{"id":"17338","subject":"[PATCH] Makefile: Use libc strlcpy on OSX","startedAt":"2009-01-24T15:41:30Z","lastAt":"2009-01-24T18:51:53Z","messageCount":3,"participants":["Benjamin Kramer","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"101745","messageId":"7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com","threadId":"17338","inReplyTo":null,"subject":"[PATCH] Makefile: Use libc strlcpy on OSX","fromName":"Benjamin Kramer","fromEmail":"benny.kra@googlemail.com","sentAt":"2009-01-24T15:41:30Z","receivedAt":"2009-01-24T15:41:30Z","isPatch":true,"sender":{"key":"benny.kra@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/16542?v=4"},"body":"OSX supports strlcpy(3) since 10.2 so we don't need\nto use our own.\n\nSigned-off-by: Benjamin Kramer <benny.kra@gmail.com>\n---\n Makefile |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex b4d9cb4..4c9aab5 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)\n \tifneq ($(shell expr \"$(uname_R)\" : '9\\.'),2)\n \t\tOLD_ICONV = UnfortunatelyYes\n \tendif\n-\tNO_STRLCPY = YesPlease\n \tNO_MEMMEM = YesPlease\n \tTHREADED_DELTA_SEARCH = YesPlease\n endif\n-- \n1.6.1.285.g3454\n"},{"id":"101759","messageId":"7vfxj8o8fq.fsf@gitster.siamese.dyndns.org","threadId":"17338","inReplyTo":"7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com","subject":"Re: [PATCH] Makefile: Use libc strlcpy on OSX","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-24T18:39:05Z","receivedAt":"2009-01-24T18:39:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Benjamin Kramer <benny.kra@googlemail.com> writes:\n\n> OSX supports strlcpy(3) since 10.2 so we don't need\n> to use our own.\n\nHow does your patch to Makefile refrain from kicking in for people with\nOSX older than 10.2, so that their builds are not broken?\n\n>\n> Signed-off-by: Benjamin Kramer <benny.kra@gmail.com>\n> ---\n>  Makefile |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index b4d9cb4..4c9aab5 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)\n>  \tifneq ($(shell expr \"$(uname_R)\" : '9\\.'),2)\n>  \t\tOLD_ICONV = UnfortunatelyYes\n>  \tendif\n> -\tNO_STRLCPY = YesPlease\n>  \tNO_MEMMEM = YesPlease\n>  \tTHREADED_DELTA_SEARCH = YesPlease\n>  endif\n"},{"id":"101763","messageId":"7f978c810901241051m752a0b97s8ce76c3d2ece0695@mail.gmail.com","threadId":"17338","inReplyTo":"7vfxj8o8fq.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Makefile: Use libc strlcpy on OSX","fromName":"Benjamin Kramer","fromEmail":"benny.kra@googlemail.com","sentAt":"2009-01-24T18:51:53Z","receivedAt":"2009-01-24T18:51:53Z","isPatch":true,"sender":{"key":"benny.kra@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/16542?v=4"},"body":"On Sat, Jan 24, 2009 at 19:39, Junio C Hamano <gitster@pobox.com> wrote:\n> How does your patch to Makefile refrain from kicking in for people with\n> OSX older than 10.2, so that their builds are not broken?\n\nI'm not even sure anyone uses <= 10.1 nowadays. But of course you're right,\nI'll write a better patch.\n\n-- Benjamin\n"}]}