{"thread":{"id":"17331","subject":"[PATCH v2] Change octal literals to be XEmacs friendly","startedAt":"2009-01-23T23:20:52Z","lastAt":"2009-01-26T22:59:47Z","messageCount":7,"participants":["Vassili Karpov","Junio C Hamano","Kalle Olavi Niemitalo","malc@pulsesoft.com","Alexandre Julliard"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"101707","messageId":"Pine.LNX.4.64.0901240219530.19590@linmac.oyster.ru","threadId":"17331","inReplyTo":null,"subject":"[PATCH v2] Change octal literals to be XEmacs friendly","fromName":"Vassili Karpov","fromEmail":"av1474@comtv.ru","sentAt":"2009-01-23T23:20:52Z","receivedAt":"2009-01-23T23:20:52Z","isPatch":true,"sender":{"key":"av1474@comtv.ru","avatar":null},"body":"\nThe type-of ?\\octal in XEmacs is character while in FSF Emacs it is\ninteger. Case expression using this syntax will not work correctly on\nXEmacs. #ooctal syntax on the other hand produces integers everywhere.\n\nSigned-off-by: Vassili Karpov \n---\n contrib/emacs/git.el | 30 +++++++++++++++---------------\n 1 files changed, 15 insertions(+), 15 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex 09e8bae..715580a 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -562,29 +562,29 @@ the process output as a string, or nil if the git \ncommand failed.\"\n (let* ((old-type (lsh (or old-perm 0) -9))\n \t (new-type (lsh (or new-perm 0) -9))\n \t (str (case new-type\n-\t\t(?\\100 ;; file\n+\t\t(#o100 ;; file\n \t\t (case old-type\n-\t\t (?\\100 nil)\n-\t\t (?\\120 \" (type change symlink -> file)\")\n-\t\t (?\\160 \" (type change subproject -> file)\")))\n-\t\t (?\\120 ;; symlink\n+\t\t (#o100 nil)\n+\t\t (#o120 \" (type change symlink -> file)\")\n+\t\t (#o160 \" (type change subproject -> file)\")))\n+\t\t (#o120 ;; symlink\n \t\t (case old-type\n-\t\t (?\\100 \" (type change file -> symlink)\")\n-\t\t (?\\160 \" (type change subproject -> symlink)\")\n+\t\t (#o100 \" (type change file -> symlink)\")\n+\t\t (#o160 \" (type change subproject -> symlink)\")\n \t\t (t \" (symlink)\")))\n-\t\t (?\\160 ;; subproject\n+\t\t (#o160 ;; subproject\n \t\t (case old-type\n-\t\t (?\\100 \" (type change file -> subproject)\")\n-\t\t (?\\120 \" (type change symlink -> subproject)\")\n+\t\t (#o100 \" (type change file -> subproject)\")\n+\t\t (#o120 \" (type change symlink -> subproject)\")\n \t\t (t \" (subproject)\")))\n- (?\\110 nil) ;; directory (internal, not a real git \nstate)\n-\t\t (?\\000 ;; deleted or unknown\n+ (#o110 nil) ;; directory (internal, not a real git \nstate)\n+\t\t (#o000 ;; deleted or unknown\n \t\t (case old-type\n-\t\t (?\\120 \" (symlink)\")\n-\t\t (?\\160 \" (subproject)\")))\n+\t\t (#o120 \" (symlink)\")\n+\t\t (#o160 \" (subproject)\")))\n \t\t (t (format \" (unknown type %o)\" new-type)))))\n (cond (str (propertize str 'face 'git-status-face))\n- ((eq new-type ?\\110) \"/\")\n+ ((eq new-type #o110) \"/\")\n (t \"\"))))\n\n (defun git-rename-as-string (info)\n-- \n1.6.0.2.GIT\n\n\n\n-- \nmailto:av1474@comtv.ru\n"},{"id":"101717","messageId":"7vocxxpk0z.fsf@gitster.siamese.dyndns.org","threadId":"17331","inReplyTo":"Pine.LNX.4.64.0901240219530.19590@linmac.oyster.ru","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-24T01:31:08Z","receivedAt":"2009-01-24T01:31:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Vassili Karpov writes:\n\nPlease don't use \"format=flowed\"; your patch is whitespace damaged and\ndoes not apply.\n\n> The type-of ?\\octal in XEmacs is character while in FSF Emacs it is\n> integer. Case expression using this syntax will not work correctly on\n> XEmacs. #ooctal syntax on the other hand produces integers everywhere.\n>\n> Signed-off-by: Vassili Karpov \n> ---\n> contrib/emacs/git.el | 30 +++++++++++++++---------------\n> 1 files changed, 15 insertions(+), 15 deletions(-)\n>\n> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\n> index 09e8bae..715580a 100644\n> --- a/contrib/emacs/git.el\n> +++ b/contrib/emacs/git.el\n> @@ -562,29 +562,29 @@ the process output as a string, or nil if the\n> git command failed.\"\n> (let* ((old-type (lsh (or old-perm 0) -9))\n> \t (new-type (lsh (or new-perm 0) -9))\n> \t (str (case new-type\n> -\t\t(?\\100 ;; file\n> +\t\t(#o100 ;; file\n> \t\t (case old-type\n> -\t\t (?\\100 nil)\n> -\t\t (?\\120 \" (type change symlink -> file)\")\n> -\t\t (?\\160 \" (type change subproject -> file)\")))\n> -\t\t (?\\120 ;; symlink\n> +\t\t (#o100 nil)\n> +\t\t (#o120 \" (type change symlink -> file)\")\n> +\t\t (#o160 \" (type change subproject -> file)\")))\n> +\t\t (#o120 ;; symlink\n> \t\t (case old-type\n> -\t\t (?\\100 \" (type change file -> symlink)\")\n> -\t\t (?\\160 \" (type change subproject -> symlink)\")\n> +\t\t (#o100 \" (type change file -> symlink)\")\n> +\t\t (#o160 \" (type change subproject -> symlink)\")\n> \t\t (t \" (symlink)\")))\n> -\t\t (?\\160 ;; subproject\n> +\t\t (#o160 ;; subproject\n> \t\t (case old-type\n> -\t\t (?\\100 \" (type change file -> subproject)\")\n> -\t\t (?\\120 \" (type change symlink -> subproject)\")\n> +\t\t (#o100 \" (type change file -> subproject)\")\n> +\t\t (#o120 \" (type change symlink -> subproject)\")\n> \t\t (t \" (subproject)\")))\n> - (?\\110 nil) ;; directory (internal, not a real git\n> state)\n> -\t\t (?\\000 ;; deleted or unknown\n> + (#o110 nil) ;; directory (internal, not a real git\n> state)\n> +\t\t (#o000 ;; deleted or unknown\n> \t\t (case old-type\n> -\t\t (?\\120 \" (symlink)\")\n> -\t\t (?\\160 \" (subproject)\")))\n> +\t\t (#o120 \" (symlink)\")\n> +\t\t (#o160 \" (subproject)\")))\n> \t\t (t (format \" (unknown type %o)\" new-type)))))\n> (cond (str (propertize str 'face 'git-status-face))\n> - ((eq new-type ?\\110) \"/\")\n> + ((eq new-type #o110) \"/\")\n> (t \"\"))))\n>\n> (defun git-rename-as-string (info)\n> -- \n> 1.6.0.2.GIT\n>\n>\n>\n> -- \n> mailto:av1474@comtv.ru\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"101721","messageId":"874ozp79y4.fsf@Astalo.kon.iki.fi","threadId":"17331","inReplyTo":"Pine.LNX.4.64.0901240219530.19590@linmac.oyster.ru","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"Kalle Olavi Niemitalo","fromEmail":"kon@iki.fi","sentAt":"2009-01-24T01:46:11Z","receivedAt":"2009-01-24T01:46:11Z","isPatch":true,"sender":{"key":"kon@iki.fi","avatar":null},"body":"Vassili Karpov writes:\n\n> #ooctal syntax on the other hand produces integers everywhere.\n\nGNU Emacs 20.7 doesn't support #o, but neither does it include\nthe ewoc and log-edit libraries required by the current git.el.\n\nIt would be nice to have a comment in git.el saying which\nversions of Emacs and XEmacs it is supposed to support, but I\nguess people wouldn't bother testing those on every commit.\n"},{"id":"101723","messageId":"878wp1mphq.fsf@linmac.oyster.ru","threadId":"17331","inReplyTo":"874ozp79y4.fsf@Astalo.kon.iki.fi","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"","fromEmail":"malc@pulsesoft.com","sentAt":"2009-01-24T02:01:21Z","receivedAt":"2009-01-24T02:01:21Z","isPatch":true,"sender":{"key":"malc@pulsesoft.com","avatar":null},"body":"Kalle Olavi Niemitalo writes:\n\n> Vassili Karpov writes:\n>\n>> #ooctal syntax on the other hand produces integers everywhere.\n>\n> GNU Emacs 20.7 doesn't support #o, but neither does it include\n\nBummer\n\n> the ewoc and log-edit libraries required by the current git.el.\n\newoc and log-edit are not part of XEmacs 21.4.20 (the version i am\nusing), furthermore make-temp-file is not available either, but those\nproblems, unlike the case/eql/literals issue, can be resolved without\ntouching git.el (One might argue that case can be fixed with defadvice\nor other hackery, but that's a bit too much)\n\n> It would be nice to have a comment in git.el saying which\n> versions of Emacs and XEmacs it is supposed to support, but I\n> guess people wouldn't bother testing those on every commit.\n\nWell it doesn't \"support\" XEmacs at all.\n\n-- \nmailto:av1474@comtv.ru\n"},{"id":"101728","messageId":"7v3af9p9lq.fsf@gitster.siamese.dyndns.org","threadId":"17331","inReplyTo":"878wp1mphq.fsf@linmac.oyster.ru","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-24T05:16:17Z","receivedAt":"2009-01-24T05:16:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"malc@pulsesoft.com writes:\n\n> Kalle Olavi Niemitalo writes:\n>\n>> Vassili Karpov writes:\n>>\n>>> #ooctal syntax on the other hand produces integers everywhere.\n>>\n>> GNU Emacs 20.7 doesn't support #o, but neither does it include\n>\n> Bummer\n\nTo be portable you could certainly spell them in decimal integers, no?\n"},{"id":"101743","messageId":"873af8okic.fsf@linmac.oyster.ru","threadId":"17331","inReplyTo":"7v3af9p9lq.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"","fromEmail":"malc@pulsesoft.com","sentAt":"2009-01-24T14:18:19Z","receivedAt":"2009-01-24T14:18:19Z","isPatch":true,"sender":{"key":"malc@pulsesoft.com","avatar":null},"body":"Junio C Hamano writes:\n\n> malc@pulsesoft.com writes:\n>\n>> Kalle Olavi Niemitalo writes:\n>>\n>>> Vassili Karpov writes:\n>>>\n>>>> #ooctal syntax on the other hand produces integers everywhere.\n>>>\n>>> GNU Emacs 20.7 doesn't support #o, but neither does it include\n>>\n>> Bummer\n>\n> To be portable you could certainly spell them in decimal integers, no?\n\nSure.\n\n-- \nmailto:av1474@comtv.ru\n"},{"id":"102068","messageId":"877i4had24.fsf@wine.dyndns.org","threadId":"17331","inReplyTo":"874ozp79y4.fsf@Astalo.kon.iki.fi","subject":"Re: [PATCH v2] Change octal literals to be XEmacs friendly","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2009-01-26T22:59:47Z","receivedAt":"2009-01-26T22:59:47Z","isPatch":true,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"Kalle Olavi Niemitalo writes:\n\n> Vassili Karpov writes:\n>\n>> #ooctal syntax on the other hand produces integers everywhere.\n>\n> GNU Emacs 20.7 doesn't support #o, but neither does it include\n> the ewoc and log-edit libraries required by the current git.el.\n>\n> It would be nice to have a comment in git.el saying which\n> versions of Emacs and XEmacs it is supposed to support, but I\n> guess people wouldn't bother testing those on every commit.\n\nI try to make sure that it still works with Emacs 21, but for older\nversions you're on your own. Of course if you find problems patches are\nwelcome...\n\n-- \nAlexandre Julliard\njulliard@winehq.org\n"}]}