{"thread":{"id":"17289","subject":"[PATCH] Change octal literals to be XEmacs friendly","startedAt":"2009-01-21T17:02:39Z","lastAt":"2009-01-23T20:13:26Z","messageCount":4,"participants":["malc@pulsesoft.com","Junio C Hamano","malc"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"101417","messageId":"871vuwbnio.fsf@linmac.oyster.ru","threadId":"17289","inReplyTo":null,"subject":"[PATCH] Change octal literals to be XEmacs friendly","fromName":"","fromEmail":"malc@pulsesoft.com","sentAt":"2009-01-21T17:02:39Z","receivedAt":"2009-01-21T17:02:39Z","isPatch":true,"sender":{"key":"malc@pulsesoft.com","avatar":null},"body":"\ncase uses eql and (eql ?\\001 1) evaluates to nil under XEmacs\n(probably because some internal type of ?\\001 is char)\n\nSigned-off-by: Vassili Karpov \n---\n contrib/emacs/git.el | 30 +++++++++++++++---------------\n 1 files changed, 15 insertions(+), 15 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex 09e8bae..715580a 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -562,29 +562,29 @@ the process output as a string, or nil if the git command failed.\"\n (let* ((old-type (lsh (or old-perm 0) -9))\n (new-type (lsh (or new-perm 0) -9))\n (str (case new-type\n- (?\\100 ;; file\n+ (#o100 ;; file\n (case old-type\n- (?\\100 nil)\n- (?\\120 \" (type change symlink -> file)\")\n- (?\\160 \" (type change subproject -> file)\")))\n- (?\\120 ;; symlink\n+ (#o100 nil)\n+ (#o120 \" (type change symlink -> file)\")\n+ (#o160 \" (type change subproject -> file)\")))\n+ (#o120 ;; symlink\n (case old-type\n- (?\\100 \" (type change file -> symlink)\")\n- (?\\160 \" (type change subproject -> symlink)\")\n+ (#o100 \" (type change file -> symlink)\")\n+ (#o160 \" (type change subproject -> symlink)\")\n (t \" (symlink)\")))\n- (?\\160 ;; subproject\n+ (#o160 ;; subproject\n (case old-type\n- (?\\100 \" (type change file -> subproject)\")\n- (?\\120 \" (type change symlink -> subproject)\")\n+ (#o100 \" (type change file -> subproject)\")\n+ (#o120 \" (type change symlink -> subproject)\")\n (t \" (subproject)\")))\n- (?\\110 nil) ;; directory (internal, not a real git state)\n- (?\\000 ;; deleted or unknown\n+ (#o110 nil) ;; directory (internal, not a real git state)\n+ (#o000 ;; deleted or unknown\n (case old-type\n- (?\\120 \" (symlink)\")\n- (?\\160 \" (subproject)\")))\n+ (#o120 \" (symlink)\")\n+ (#o160 \" (subproject)\")))\n (t (format \" (unknown type %o)\" new-type)))))\n (cond (str (propertize str 'face 'git-status-face))\n- ((eq new-type ?\\110) \"/\")\n+ ((eq new-type #o110) \"/\")\n (t \"\"))))\n \n (defun git-rename-as-string (info)\n\n-- \nmailto:av1474@comtv.ru\n"},{"id":"101630","messageId":"7vbpty1m1r.fsf@gitster.siamese.dyndns.org","threadId":"17289","inReplyTo":"871vuwbnio.fsf@linmac.oyster.ru","subject":"Re: [PATCH] Change octal literals to be XEmacs friendly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-23T08:09:04Z","receivedAt":"2009-01-23T08:09:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"malc@pulsesoft.com writes:\n\n> case uses eql and (eql ?\\001 1) evaluates to nil under XEmacs\n> (probably because some internal type of ?\\001 is char)\n\nAnd I presume the new way to spell is compatible with non XEmacs emacs?\nIt may be obvious to you, but please spell it out. Parenthesized\n\"probably\" does not help building the confidence in the patch either.\n\n> Signed-off-by: Vassili Karpov \n\nHow are the (nameless) author of the patch malc@pulsesoft.com and Vassili\nKarpov, the person who signed off, related?\n\nNext time, please spend a few minutes to see if there are active\ndevelopers who are familiar in the area you are touching, and Cc your\npatch to ask their input.\n\n git blame -L562,+29 contrib/emacs/git.el\n\ntells me that most of this came from 40f162b (git.el: Display file types\nand type changes., 2008-01-06) by Alexandre, so I am Cc'ing him.\n\n> ---\n> contrib/emacs/git.el | 30 +++++++++++++++---------------\n> 1 files changed, 15 insertions(+), 15 deletions(-)\n>\n> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\n> index 09e8bae..715580a 100644\n> --- a/contrib/emacs/git.el\n> +++ b/contrib/emacs/git.el\n> @@ -562,29 +562,29 @@ the process output as a string, or nil if the git command failed.\"\n> (let* ((old-type (lsh (or old-perm 0) -9))\n> (new-type (lsh (or new-perm 0) -9))\n> (str (case new-type\n> - (?\\100 ;; file\n> + (#o100 ;; file\n> (case old-type\n> - (?\\100 nil)\n> - (?\\120 \" (type change symlink -> file)\")\n> - (?\\160 \" (type change subproject -> file)\")))\n> - (?\\120 ;; symlink\n> + (#o100 nil)\n> + (#o120 \" (type change symlink -> file)\")\n> + (#o160 \" (type change subproject -> file)\")))\n> + (#o120 ;; symlink\n> (case old-type\n> - (?\\100 \" (type change file -> symlink)\")\n> - (?\\160 \" (type change subproject -> symlink)\")\n> + (#o100 \" (type change file -> symlink)\")\n> + (#o160 \" (type change subproject -> symlink)\")\n> (t \" (symlink)\")))\n> - (?\\160 ;; subproject\n> + (#o160 ;; subproject\n> (case old-type\n> - (?\\100 \" (type change file -> subproject)\")\n> - (?\\120 \" (type change symlink -> subproject)\")\n> + (#o100 \" (type change file -> subproject)\")\n> + (#o120 \" (type change symlink -> subproject)\")\n> (t \" (subproject)\")))\n> - (?\\110 nil) ;; directory (internal, not a real git state)\n> - (?\\000 ;; deleted or unknown\n> + (#o110 nil) ;; directory (internal, not a real git state)\n> + (#o000 ;; deleted or unknown\n> (case old-type\n> - (?\\120 \" (symlink)\")\n> - (?\\160 \" (subproject)\")))\n> + (#o120 \" (symlink)\")\n> + (#o160 \" (subproject)\")))\n> (t (format \" (unknown type %o)\" new-type)))))\n> (cond (str (propertize str 'face 'git-status-face))\n> - ((eq new-type ?\\110) \"/\")\n> + ((eq new-type #o110) \"/\")\n> (t \"\"))))\n> \n> (defun git-rename-as-string (info)\n>\n> -- \n> mailto:av1474@comtv.ru\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"101689","messageId":"Pine.LNX.4.64.0901232158290.2186@linmac.oyster.ru","threadId":"17289","inReplyTo":"7vbpty1m1r.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Change octal literals to be XEmacs friendly","fromName":"malc","fromEmail":"av1474@comtv.ru","sentAt":"2009-01-23T19:53:31Z","receivedAt":"2009-01-23T19:53:31Z","isPatch":true,"sender":{"key":"av1474@comtv.ru","avatar":null},"body":"On Fri, 23 Jan 2009, Junio C Hamano wrote:\n\n> malc@pulsesoft.com writes:\n>\n>> case uses eql and (eql ?\\001 1) evaluates to nil under XEmacs\n>> (probably because some internal type of ?\\001 is char)\n>\n> And I presume the new way to spell is compatible with non XEmacs emacs?\n> It may be obvious to you, but please spell it out. Parenthesized\n> \"probably\" does not help building the confidence in the patch either.\n\nFair enough.\n\nXEmacs:\n(type-of ?\\1) yields character\n\nFSF Emacs:\n(type-of ?\\1) yields integer\n\n>\n>> Signed-off-by: Vassili Karpov \n>\n> How are the (nameless) author of the patch malc@pulsesoft.com and Vassili\n> Karpov, the person who signed off, related?\n\nBoth are my e-mail address used in ~/.gitconfig and ~/.emacs (and used\nby GNUS which was used to post the message via gmane's nntp interface)\nrespectively.\n\n> Next time, please spend a few minutes to see if there are active\n> developers who are familiar in the area you are touching, and Cc your\n> patch to ask their input.\n>\n> git blame -L562,+29 contrib/emacs/git.el\n>\n\nOkay.\n\n> tells me that most of this came from 40f162b (git.el: Display file types\n> and type changes., 2008-01-06) by Alexandre, so I am Cc'ing him.\n>\n\n[..snip..]\n\n-- \nmailto:av1474@comtv.ru\n"},{"id":"101686","messageId":"7vvds5u6ft.fsf@gitster.siamese.dyndns.org","threadId":"17289","inReplyTo":"Pine.LNX.4.64.0901232158290.2186@linmac.oyster.ru","subject":"Re: [PATCH] Change octal literals to be XEmacs friendly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-23T20:13:26Z","receivedAt":"2009-01-23T20:13:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"malc writes:\n\n> On Fri, 23 Jan 2009, Junio C Hamano wrote:\n>\n>> malc@pulsesoft.com writes:\n>>\n>>> case uses eql and (eql ?\\001 1) evaluates to nil under XEmacs\n>>> (probably because some internal type of ?\\001 is char)\n>>\n>> And I presume the new way to spell is compatible with non XEmacs emacs?\n>> It may be obvious to you, but please spell it out. Parenthesized\n>> \"probably\" does not help building the confidence in the patch either.\n>\n> Fair enough.\n>\n> XEmacs:\n> (type-of ?\\1) yields character\n>\n> FSF Emacs:\n> (type-of ?\\1) yields integer\n\nNo use explaining that to me _here_. Please use that knowledge to write a\nbetter description in an updated commit log message when sending your v2\npatch.\n\n>>> Signed-off-by: Vassili Karpov \n>>\n>> How are the (nameless) author of the patch malc@pulsesoft.com and Vassili\n>> Karpov, the person who signed off, related?\n>\n> Both are my e-mail address used in ~/.gitconfig and ~/.emacs (and used\n> by GNUS which was used to post the message via gmane's nntp interface)\n> respectively.\n\nAssuming that you would want to be known as Vassili, please have that name\non From: line of the message -- the patch acceptance tool takes the author\nname from there.\n\nIf you can't for whatever reason use the name on From: line of the e-mail\nmessage, you can begin the body of the message with\n\n\tFrom: Vassili Karpov \n\n(without indentation) and a blank line. This trick can also be used when\nyou are forwarding a patch somebody else wrote.\n"}]}