{"thread":{"id":"17261","subject":"[PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler","startedAt":"2009-01-19T23:41:18Z","lastAt":"2009-01-20T03:04:53Z","messageCount":2,"participants":["Markus Heidelberg","David Aguilar"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"101184","messageId":"200901200041.18793.markus.heidelberg@web.de","threadId":"17261","inReplyTo":null,"subject":"[PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-01-19T23:41:18Z","receivedAt":"2009-01-19T23:41:18Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"When interrupting git-difftool with Ctrl-C, the output of this echo\ncommand led to having the cursor at the beginning of the line below the\nshell prompt.\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n\n\tDavid, have you intentionally added this 'echo', did it fix\n\tanything for you?\n\n contrib/difftool/git-difftool-helper |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper\nindex a2eb59b..0c48506 100755\n--- a/contrib/difftool/git-difftool-helper\n+++ b/contrib/difftool/git-difftool-helper\n@@ -32,7 +32,6 @@ cleanup_temp_files () {\n \n # This is called when users Ctrl-C out of git-difftool-helper\n sigint_handler () {\n-\techo\n \tcleanup_temp_files\n \texit 1\n }\n-- \n1.6.1.216.g3acd\n"},{"id":"101205","messageId":"402731c90901191904l217d6bdenf33f02033519c731@mail.gmail.com","threadId":"17261","inReplyTo":"200901200041.18793.markus.heidelberg@web.de","subject":"Re: [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2009-01-20T03:04:53Z","receivedAt":"2009-01-20T03:04:53Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Mon, Jan 19, 2009 at 3:41 PM, Markus Heidelberg\n<markus.heidelberg@web.de> wrote:\n> When interrupting git-difftool with Ctrl-C, the output of this echo\n> command led to having the cursor at the beginning of the line below the\n> shell prompt.\n>\n> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n> ---\n>\n>        David, have you intentionally added this 'echo', did it fix\n>        anything for you?\n\n\nI think you're right in that we're better off without the echo.  There\nwasn't really any reason for it to be there.\n\n\n\n\n>\n>  contrib/difftool/git-difftool-helper |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper\n> index a2eb59b..0c48506 100755\n> --- a/contrib/difftool/git-difftool-helper\n> +++ b/contrib/difftool/git-difftool-helper\n> @@ -32,7 +32,6 @@ cleanup_temp_files () {\n>\n>  # This is called when users Ctrl-C out of git-difftool-helper\n>  sigint_handler () {\n> -       echo\n>        cleanup_temp_files\n>        exit 1\n>  }\n> --\n> 1.6.1.216.g3acd\n>\n>\n\n\n\n-- \n    David\n"}]}