{"thread":{"id":"17258","subject":"[PATCH] commit: more compact summary and without extra quotes","startedAt":"2009-01-19T22:45:16Z","lastAt":"2009-01-20T10:29:05Z","messageCount":8,"participants":["Santi Béjar","Johannes Schindelin","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"101173","messageId":"1232405116-2359-1-git-send-email-santi@agolina.net","threadId":"17258","inReplyTo":null,"subject":"[PATCH] commit: more compact summary and without extra quotes","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2009-01-19T22:45:16Z","receivedAt":"2009-01-19T22:45:16Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"Original:\n[master]: created d9a5491: \"foo:bar\"\n\nWhile with the patch it becomes:\n[master d9a5491] foo:bar\n\nAs discussed in the git mailing list:\n\nhttp://marc.info/?l=git&m=122765031208922&w=2\n\nSigned-off-by: Santi Béjar \n---\n builtin-commit.c | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 2f0b00a..b159af2 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -883,7 +883,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)\n {\n \tstruct rev_info rev;\n \tstruct commit *commit;\n-\tstatic const char *format = \"format:%h: \\\"%s\\\"\";\n+\tstatic const char *format = \"format:%h] %s\";\n \tunsigned char junk_sha1[20];\n \tconst char *head = resolve_ref(\"HEAD\", junk_sha1, 0, NULL);\n \n@@ -910,7 +910,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)\n \trev.diffopt.break_opt = 0;\n \tdiff_setup_done(&rev.diffopt);\n \n-\tprintf(\"[%s%s]: created \",\n+\tprintf(\"[%s%s \",\n \t\t!prefixcmp(head, \"refs/heads/\") ?\n \t\t\thead + 11 :\n \t\t\t!strcmp(head, \"HEAD\") ?\n-- \n1.6.1.258.g7ff14\n"},{"id":"101187","messageId":"alpine.DEB.1.00.0901200043400.3586@pacific.mpi-cbg.de","threadId":"17258","inReplyTo":"1232405116-2359-1-git-send-email-santi@agolina.net","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-01-19T23:46:24Z","receivedAt":"2009-01-19T23:46:24Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 19 Jan 2009, Santi Béjar wrote:\n\n> Original:\n> [master]: created d9a5491: \"foo:bar\"\n> \n> While with the patch it becomes:\n> [master d9a5491] foo:bar\n\nMaybe you want to mention that it saves screen estate. After all, the \ncommit message is _the_ place to relate your motivation to the gentle \nreader.\n\n> As discussed in the git mailing list:\n> \n> http://marc.info/?l=git&m=122765031208922&w=2\n> \n> Signed-off-by: Santi Béjar \n> ---\n\nYou really want to move the link after the ---. I often read commit \nmessages off-line, and let me tell you: I am not really happy reading \nlinks then. Not at all.\n\nCiao,\nDscho"},{"id":"101190","messageId":"adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com","threadId":"17258","inReplyTo":"alpine.DEB.1.00.0901200043400.3586@pacific.mpi-cbg.de","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2009-01-20T00:00:30Z","receivedAt":"2009-01-20T00:00:30Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"2009/1/20 Johannes Schindelin :\n> Hi,\n>\n> On Mon, 19 Jan 2009, Santi Béjar wrote:\n>\n>> Original:\n>> [master]: created d9a5491: \"foo:bar\"\n>>\n>> While with the patch it becomes:\n>> [master d9a5491] foo:bar\n>\n> Maybe you want to mention that it saves screen estate. After all, the\n> commit message is _the_ place to relate your motivation to the gentle\n> reader.\n\nI thought it was enough with the \"more compact\" in the title line.\n\n>\n>> As discussed in the git mailing list:\n>>\n>> http://marc.info/?l=git&m=122765031208922&w=2\n>>\n>> Signed-off-by: Santi Béjar \n>> ---\n>\n> You really want to move the link after the ---. I often read commit\n> messages off-line, and let me tell you: I am not really happy reading\n> links then. Not at all.\n\nOK, less work for me :-)\n\nSanti\n"},{"id":"101209","messageId":"7vocy2ocw0.fsf@gitster.siamese.dyndns.org","threadId":"17258","inReplyTo":"adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-20T03:49:19Z","receivedAt":"2009-01-20T03:49:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Santi Béjar writes:\n\n>>> As discussed in the git mailing list:\n>>>\n>>> http://marc.info/?l=git&m=122765031208922&w=2\n>>>\n>>> Signed-off-by: Santi Béjar \n>>> ---\n>>\n>> You really want to move the link after the ---. I often read commit\n>> messages off-line, and let me tell you: I am not really happy reading\n>> links then. Not at all.\n>\n> OK, less work for me :-)\n\nI do not mind URL in the commit log; it would help me or other forgetful\npeople three months from now if we need to go back to the original\ndiscussion.\n\nI however agree with Dscho that it is irritating when somebody uses URL to\navoid summarizing the issue himself. If somebody cares enough and\nunderstands the issues discussed at URL to come up with a patch that is\nworth applying, he surely should be able to summarize the primary idea and\nissues involved in a few paragraphs.\n\nA summary of discussion in addition to URL would save everybody's time.\n"},{"id":"101212","messageId":"20090120041443.GC30714@sigill.intra.peff.net","threadId":"17258","inReplyTo":"1232405116-2359-1-git-send-email-santi@agolina.net","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-01-20T04:14:43Z","receivedAt":"2009-01-20T04:14:43Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Jan 19, 2009 at 11:45:16PM +0100, Santi Béjar wrote:\n\n> Original:\n> [master]: created d9a5491: \"foo:bar\"\n> \n> While with the patch it becomes:\n> [master d9a5491] foo:bar\n> \n> As discussed in the git mailing list:\n> \n> http://marc.info/?l=git&m=122765031208922&w=2\n\nI agree with Junio that the URL is fine, but it should not _replace_ a\nsummary of the issue. But as for the patch itself, I think it is\nsensible (and I remember wondering at some point what had become of your\nproposal, since everybody seemed to like it).\n\n-Peff\n"},{"id":"101224","messageId":"7vtz7ulaq5.fsf@gitster.siamese.dyndns.org","threadId":"17258","inReplyTo":"1232405116-2359-1-git-send-email-santi@agolina.net","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-20T07:04:18Z","receivedAt":"2009-01-20T07:04:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I've updated the log message, so there is no need to resend. I suspect\nthat documentation/tutorial needs updating after this one.\n\nWill apply to 'master'. Thanks.\n"},{"id":"101240","messageId":"alpine.DEB.1.00.0901201109430.3586@pacific.mpi-cbg.de","threadId":"17258","inReplyTo":"7vocy2ocw0.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-01-20T10:10:49Z","receivedAt":"2009-01-20T10:10:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 19 Jan 2009, Junio C Hamano wrote:\n\n> Santi Béjar writes:\n> \n> > OK, less work for me :-)\n> \n> A summary of discussion in addition to URL would save everybody's time.\n\nAs Santi pointed out, not his time. And I almost feared that he was \ncomfortable with the overall time-balance weighing dramatically in his \nfavor.\n\nCiao,\nDscho\n"},{"id":"101244","messageId":"adf1fd3d0901200229h4e7a422j9418a8d399e50931@mail.gmail.com","threadId":"17258","inReplyTo":"alpine.DEB.1.00.0901201109430.3586@pacific.mpi-cbg.de","subject":"Re: [PATCH] commit: more compact summary and without extra quotes","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2009-01-20T10:29:05Z","receivedAt":"2009-01-20T10:29:05Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"2009/1/20 Johannes Schindelin :\n> Hi,\n>\n> On Mon, 19 Jan 2009, Junio C Hamano wrote:\n>\n>> Santi Béjar writes:\n>>\n>> > OK, less work for me :-)\n>>\n>> A summary of discussion in addition to URL would save everybody's time.\n>\n> As Santi pointed out, not his time. And I almost feared that he was\n> comfortable with the overall time-balance weighing dramatically in his\n> favor.\n\nNo, I'm not comfortable. I don't like wasting other's time. It was an\nunfortunate comment from my part (I thought you were saying just\nremove or put it after the ---).\n\nSanti\n"}]}