{"thread":{"id":"17253","subject":"[PATCH] parsecvs: produce tagger fields acceptable to newer git versions","startedAt":"2009-01-19T12:02:17Z","lastAt":"2009-01-19T13:39:07Z","messageCount":3,"participants":["Lennert Buytenhek","Jim Meyering"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"101127","messageId":"20090119120217.GD4390@xi.wantstofly.org","threadId":"17253","inReplyTo":null,"subject":"[PATCH] parsecvs: produce tagger fields acceptable to newer git versions","fromName":"Lennert Buytenhek","fromEmail":"buytenh@wantstofly.org","sentAt":"2009-01-19T12:02:17Z","receivedAt":"2009-01-19T12:02:17Z","isPatch":true,"sender":{"key":"buytenh@wantstofly.org","avatar":null},"body":"Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>\n\ndiff --git a/git.c b/git.c\nindex da320d1..8f94d1b 100644\n--- a/git.c\n+++ b/git.c\n@@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)\n \t\t\"object %s\\n\"\n \t\t\"type commit\\n\"\n \t\t\"tag %s\\n\"\n-\t\t\"tagger %s\\n\"\n+\t\t\"tagger %s <%s> %lu +0000\\n\"\n \t\t\"\\n\",\n \t\tcommit->sha1,\n \t\tname,\n-\t\tauthor ? author->full : commit->author);\n+\t\tauthor ? author->full : commit->author,\n+\t\tauthor ? author->email : commit->author,\n+\t\tcommit->date);\n     if (rv < 1) {\n \tfprintf (stderr, \"%s: %s\\n\", filename, strerror (errno));\n \tfclose (f);\n"},{"id":"101130","messageId":"87ab9nbh49.fsf@meyering.net","threadId":"17253","inReplyTo":"20090119120217.GD4390@xi.wantstofly.org","subject":"Re: [PATCH] parsecvs: produce tagger fields acceptable to newer git versions","fromName":"Jim Meyering","fromEmail":"jim@meyering.net","sentAt":"2009-01-19T12:44:06Z","receivedAt":"2009-01-19T12:44:06Z","isPatch":true,"sender":{"key":"jim@meyering.net","avatar":"https://avatars.githubusercontent.com/u/710630?v=4"},"body":"Lennert Buytenhek <buytenh@wantstofly.org> wrote:\n\n> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>\n>\n> diff --git a/git.c b/git.c\n> index da320d1..8f94d1b 100644\n> --- a/git.c\n> +++ b/git.c\n> @@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)\n>  \t\t\"object %s\\n\"\n>  \t\t\"type commit\\n\"\n>  \t\t\"tag %s\\n\"\n> -\t\t\"tagger %s\\n\"\n> +\t\t\"tagger %s <%s> %lu +0000\\n\"\n>  \t\t\"\\n\",\n>  \t\tcommit->sha1,\n>  \t\tname,\n> -\t\tauthor ? author->full : commit->author);\n> +\t\tauthor ? author->full : commit->author,\n> +\t\tauthor ? author->email : commit->author,\n> +\t\tcommit->date);\n>      if (rv < 1) {\n>  \tfprintf (stderr, \"%s: %s\\n\", filename, strerror (errno));\n>  \tfclose (f);\n\nHi Lennert,\n\nI posted the same patch a while back.\n\n    http://markmail.org/message/cebh7suc7ejpayos\n\nHowever, I never heard back.\nYou'll also need the patch below, if you're building\nagainst a newer version of git.\n\n\n>From 93bc277dff113f1133ef25b8bb985af80f1fbe0e Mon Sep 17 00:00:00 2001\nFrom: Jim Meyering <meyering@redhat.com>\nDate: Thu, 6 Nov 2008 11:35:09 +0100\nSubject: [PATCH 2/2] * tree.c (init_tree): Adapt to new git_config API.\n\n---\n tree.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tree.c b/tree.c\nindex a76f27c..e2a041c 100644\n--- a/tree.c\n+++ b/tree.c\n@@ -177,7 +177,7 @@ rev_commit *create_tree(rev_commit *leader)\n\n void init_tree(int n)\n {\n-\tgit_config(git_default_config);\n+\tgit_config(git_default_config, NULL);\n \tstrip = n;\n }\n\n--\n1.6.1.331.g9c367\n"},{"id":"101134","messageId":"20090119133907.GF4390@xi.wantstofly.org","threadId":"17253","inReplyTo":"87ab9nbh49.fsf@meyering.net","subject":"Re: [PATCH] parsecvs: produce tagger fields acceptable to newer git versions","fromName":"Lennert Buytenhek","fromEmail":"buytenh@wantstofly.org","sentAt":"2009-01-19T13:39:07Z","receivedAt":"2009-01-19T13:39:07Z","isPatch":true,"sender":{"key":"buytenh@wantstofly.org","avatar":null},"body":"On Mon, Jan 19, 2009 at 01:44:06PM +0100, Jim Meyering wrote:\n\n> > Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>\n> >\n> > diff --git a/git.c b/git.c\n> > index da320d1..8f94d1b 100644\n> > --- a/git.c\n> > +++ b/git.c\n> > @@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)\n> >  \t\t\"object %s\\n\"\n> >  \t\t\"type commit\\n\"\n> >  \t\t\"tag %s\\n\"\n> > -\t\t\"tagger %s\\n\"\n> > +\t\t\"tagger %s <%s> %lu +0000\\n\"\n> >  \t\t\"\\n\",\n> >  \t\tcommit->sha1,\n> >  \t\tname,\n> > -\t\tauthor ? author->full : commit->author);\n> > +\t\tauthor ? author->full : commit->author,\n> > +\t\tauthor ? author->email : commit->author,\n> > +\t\tcommit->date);\n> >      if (rv < 1) {\n> >  \tfprintf (stderr, \"%s: %s\\n\", filename, strerror (errno));\n> >  \tfclose (f);\n> \n> Hi Lennert,\n\nHey Jim,\n\n\n> I posted the same patch a while back.\n> \n>     http://markmail.org/message/cebh7suc7ejpayos\n> \n> However, I never heard back.\n> You'll also need the patch below, if you're building\n> against a newer version of git.\n\nCan you make your parsecvs repository available somewhere?\n\n\nthanks,\nLennert\n"}]}