{"thread":{"id":"17210","subject":"[PATCH] builtin-commit.c: do not remove COMMIT_EDITMSG","startedAt":"2009-01-16T19:40:05Z","lastAt":"2009-01-16T21:15:37Z","messageCount":2,"participants":["Stephan Beyer","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"100768","messageId":"1232134805-19597-1-git-send-email-s-beyer@gmx.net","threadId":"17210","inReplyTo":null,"subject":"[PATCH] builtin-commit.c: do not remove COMMIT_EDITMSG","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2009-01-16T19:40:05Z","receivedAt":"2009-01-16T19:40:05Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"git-commit tries to remove the file ./COMMIT_EDITMSG instead of\n$GIT_DIR/COMMIT_EDITMSG after commit preparation (e.g. running\nhooks, launching editor).\nThis behavior exists since f5bbc3225c4b07 \"Port git commit to C\".\n\nSome test cases (e.g. t/t7502-commit.sh) rely on the existence of\n$GIT_DIR/COMMIT_EDITMSG after committing and, I guess, many people\nare used to it.  So it is best not to remove it.\n\nThis patch just removes the removal of COMMIT_EDITMSG.\n\nSigned-off-by: Stephan Beyer <s-beyer@gmx.net>\n---\n builtin-commit.c |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex e88b78f..977ea09 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -624,7 +624,6 @@ static int prepare_to_commit(const char *index_file, const char *prefix)\n \tif (!commitable && !in_merge && !allow_empty &&\n \t    !(amend && is_a_merge(head_sha1))) {\n \t\trun_status(stdout, index_file, prefix, 0);\n-\t\tunlink(commit_editmsg);\n \t\treturn 0;\n \t}\n \n-- \n1.6.1.160.gecdb\n"},{"id":"100776","messageId":"alpine.DEB.1.00.0901162214550.3586@pacific.mpi-cbg.de","threadId":"17210","inReplyTo":"1232134805-19597-1-git-send-email-s-beyer@gmx.net","subject":"Re: [PATCH] builtin-commit.c: do not remove COMMIT_EDITMSG","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-01-16T21:15:37Z","receivedAt":"2009-01-16T21:15:37Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 16 Jan 2009, Stephan Beyer wrote:\n\n> This patch just removes the removal of COMMIT_EDITMSG.\n\nLOL.  Let's hope we will not need a patch removing the remove of the \nremoval.\n\nCiao,\nDscho\n"}]}