{"thread":{"id":"17138","subject":"log-tree.c: date hardwired","startedAt":"2009-01-13T03:13:18Z","lastAt":"2009-01-18T00:52:08Z","messageCount":6,"participants":["jidanni@jidanni.org","Alex Riesen","Sitaram Chamarty","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"100225","messageId":"87r637oq41.fsf@jidanni.org","threadId":"17138","inReplyTo":null,"subject":"log-tree.c: date hardwired","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-13T03:13:18Z","receivedAt":"2009-01-13T03:13:18Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"In log-tree.c: printf(\"From %s Mon Sep 17 00:00:00 2001\\n\", name);\nWouldn't it be more aesthetically pleasing to use current local or UTC time?\nOr at least comment in the code that the date is hardwired like that\nin the fear that otherwise people will think it is the actual commit time.\nNo, I can't think of any other tool that hardwires the From separators\nthey produce.\n"},{"id":"100887","messageId":"87fxjhcy3i.fsf@jidanni.org","threadId":"17138","inReplyTo":"87r637oq41.fsf@jidanni.org","subject":"Re: log-tree.c: date hardwired","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-17T23:27:29Z","receivedAt":"2009-01-17T23:27:29Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Can I get a go-ahead from somebody for me to begin work on implementing a fix?\n(Yes, trivial.)\n\n>>>>> \"j\" == jidanni  <jidanni@jidanni.org> writes:\n\nj> In log-tree.c: printf(\"From %s Mon Sep 17 00:00:00 2001\\n\", name);\nj> Wouldn't it be more aesthetically pleasing to use current local or UTC time?\nj> Or at least comment in the code that the date is hardwired like that\nj> in the fear that otherwise people will think it is the actual commit time.\nj> No, I can't think of any other tool that hardwires the From separators\nj> they produce.\n"},{"id":"100888","messageId":"81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com","threadId":"17138","inReplyTo":"87fxjhcy3i.fsf@jidanni.org","subject":"Re: log-tree.c: date hardwired","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-01-17T23:38:35Z","receivedAt":"2009-01-17T23:38:35Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2009/1/18  <jidanni@jidanni.org>:\n> Can I get a go-ahead from somebody for me to begin work on implementing a fix?\n\nNo. Try and guess why\n"},{"id":"100890","messageId":"87bpu5cx10.fsf@jidanni.org","threadId":"17138","inReplyTo":"81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com","subject":"Re: log-tree.c: date hardwired","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-17T23:50:35Z","receivedAt":"2009-01-17T23:50:35Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Perhaps a comment could be added to the code as to the reason a date\nor that certain date is hardwired. Any reason would be satisfactory.\n"},{"id":"100894","messageId":"slrngn4uk0.r31.sitaramc@sitaramc.homelinux.net","threadId":"17138","inReplyTo":"81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com","subject":"Re: log-tree.c: date hardwired","fromName":"Sitaram Chamarty","fromEmail":"sitaramc@gmail.com","sentAt":"2009-01-18T00:40:32Z","receivedAt":"2009-01-18T00:40:32Z","isPatch":false,"sender":{"key":"sitaramc@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43316?v=4"},"body":"On 2009-01-17, Alex Riesen <raa.lkml@gmail.com> wrote:\n> 2009/1/18  <jidanni@jidanni.org>:\n>> Can I get a go-ahead from somebody for me to begin work\n>> on implementing a fix?\n>\n> No. Try and guess why\n\nOK, I'll bite...\n\nBecause it's only used as the date for the mbox format\nleader line, and not an actual email (RFC 822/2822) header\nline?  And in that format it represents \"delivery date\",\nwhich is irrelevant for stuff you're generating to be sent\nout anyway, meaning this line doesn't actually get sent out\nto anyone when you mail your patches, so we don't care what\nit is.\n\nI can't think of anything else, so if it isn't that please\ndo tell.  Not that I cared about it before, but once someone\nsays \"try and guess why\" it somehow becomes important :-)\n"},{"id":"100897","messageId":"7vbpu55tc7.fsf@gitster.siamese.dyndns.org","threadId":"17138","inReplyTo":"87fxjhcy3i.fsf@jidanni.org","subject":"Re: log-tree.c: date hardwired","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-18T00:52:08Z","receivedAt":"2009-01-18T00:52:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"jidanni@jidanni.org writes:\n\n> Can I get a go-ahead from somebody for me to begin work on implementing a fix?\n\nNo, don't \"fix\" it.\n\nPlease keep it as a known constant.  That way, you can come up with an\n/etc/magic entry to teach find(1) that it is not just a random mailbox but\nis an output from format-patch.\n"}]}