{"thread":{"id":"17089","subject":"stopping patches from just floating by","startedAt":"2009-01-11T17:27:20Z","lastAt":"2009-01-12T09:35:08Z","messageCount":7,"participants":["jidanni@jidanni.org","Daniel Barkalow","Junio C Hamano","jdelstrother@gmail.com"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"99973","messageId":"87y6xhkb2f.fsf@jidanni.org","threadId":"17089","inReplyTo":null,"subject":"stopping patches from just floating by","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-11T17:27:20Z","receivedAt":"2009-01-11T17:27:20Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"I have many Documentation/* grammar patches that I can send next week.\n\nHowever I fear they will be for naught, just floating by.\n\nOK, one should keep track of the patches one sends, making sure they\nare resolved one way or the other, and don't just float by.\n\nReviewing SubmittingPatches, in the future I will use [PATCH/RFC]\ninstead of just [PATCH].\n\nI notice lots of \"Merge branch qq/bla\". And think, hmmm, Mr. QQ must\nbe using Documentation/everyday.txt's [[Individual Developer\n(Participant)]] git-push methods, for a more efficient way of getting\nhis patches included by the maintainer.\n\nBut then I step back and look at all the [PATCH]s on this list and\nconclude that just as SubmittingPatches doesn't mention git-push, the\nwhole git development world must be by simple emailed patches, and I\nneedn't bother learning git-push, making depositories on my web server\netc.\n"},{"id":"100001","messageId":"alpine.LNX.1.00.0901111524110.19665@iabervon.org","threadId":"17089","inReplyTo":"87y6xhkb2f.fsf@jidanni.org","subject":"Re: stopping patches from just floating by","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2009-01-11T20:37:36Z","receivedAt":"2009-01-11T20:37:36Z","isPatch":false,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Mon, 12 Jan 2009, jidanni@jidanni.org wrote:\n\n> I notice lots of \"Merge branch qq/bla\". And think, hmmm, Mr. QQ must\n> be using Documentation/everyday.txt's [[Individual Developer\n> (Participant)]] git-push methods, for a more efficient way of getting\n> his patches included by the maintainer.\n\nNope, that would lead to \"Merge git://qq.org/git bla\". In fact, Junio is \ngetting the patches by email, and then using that workflow in his own tree \nto manage the maintence process. That is, he creates a branch for each \npatch series that someone sends that looks ready for more exposure, by \nstarting with some plausible commit and applying the series of patches, \nand then he can merge than branch into pu, next, master, or maint as \nneeded. This is particularly useful for pu, where he redoes all the merges \nfrequently; if he worked by just applying the patches, every time he \nwanted to drop a series that he'd applied before some other series, he'd \nhave to pick out the conflict resolutions from the original author's \nchanges.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"100005","messageId":"874p05k1ie.fsf@jidanni.org","threadId":"17089","inReplyTo":"alpine.LNX.1.00.0901111524110.19665@iabervon.org","subject":"Re: stopping patches from just floating by","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-11T20:53:45Z","receivedAt":"2009-01-11T20:53:45Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"I see. Say, for my forthcoming 40 minor grammar fixes that affect 20\nfiles in Documentation/*, I just couldn't bear spamming this list with\nmore that one or two [PATCH] mails. OK one long mail it will be then,\nwith several commits encompassing many diffs. Hope that will be OK.\n(Then another long mail next month, when I finish looking at the second\nhalf of the man pages.)\n"},{"id":"100029","messageId":"7vprito32u.fsf@gitster.siamese.dyndns.org","threadId":"17089","inReplyTo":"874p05k1ie.fsf@jidanni.org","subject":"Re: stopping patches from just floating by","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-11T23:06:17Z","receivedAt":"2009-01-11T23:06:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"jidanni@jidanni.org writes:\n\n> I see. Say, for my forthcoming 40 minor grammar fixes that affect 20\n> files in Documentation/*, I just couldn't bear spamming this list with\n> more that one or two [PATCH] mails. OK one long mail it will be then,\n> with several commits encompassing many diffs. Hope that will be OK.\n\nIt probably won't be Ok, as earlier documentation patches from you that\nwere smaller had good bits that were applied and not so good bits that\nwere dropped, and I'd refuse to pick and choose only good bits from one\nsingle large patch myself.  The tradeoff between \"minor grammar fixes\" and\nmy time spent to do so is not good enough.\n\nPlease send in small isolated pieces so that people do not have to comment\n\"in this patch, this and that rewordings are very good clarification, but\nthis other hunk adds noise without adding much signal\".\n\nAnd by \"isolated\", I do not mean \"one mail per patched file\".\n\nFor example, if you fix many misused 3rd person singular verbs that ends\nwith 's' that are used for subject that is not 3rd person singular, that\nis one topic and one patch can fix an error of that kind in all of 20\nfiles.\n\nOn the other hand, if you conflate such a fix with a new explanation of an\noption (which may or may not be adding more noise than the signal) to the\nsame file in a single e-mailed patch, you will force people to say \"this\npart is good but that part is not\".  That's not the isolation I am\nreferring to.\n"},{"id":"100060","messageId":"87bpudp77t.fsf_-_@jidanni.org","threadId":"17089","inReplyTo":"7vprito32u.fsf@gitster.siamese.dyndns.org","subject":"grammar patches not best use of talent","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-12T02:51:34Z","receivedAt":"2009-01-12T02:51:34Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"I've decided to back out of my plan to patch grammar.\n$ perl -nwle '/\\w+\\s+handful.*/i&& print $&' Documentation/*|sort -uf\na handful commits on top of that,\nA handful documentation fixes.\nA handful documentation updates.\na handful example hooks are copied in the\na handful fixes to run it\na handful of examples:\nA handful of sample hooks are installed when\na handful pack-objects changes to help you cope better\na handful small fixes to gitweb.\na handful the real changes in non-zero\nfirst handful of characters, show the full\nonly handful hexdigits prefix.\nonly handful hexdigits prefix.  Non default number of\nonly handful hexdigits prefix.  This is\n\nAt first some of the above lines irritated me, but who am I to say\nthat English must be said like my mom says it, and is never allowed to\nevolve further. Nope, I'll stick to correcting 2+2=3 type things.\n"},{"id":"100084","messageId":"57518fd10901120054o5fbe78f8he0a54f6d62216ad5@mail.gmail.com","threadId":"17089","inReplyTo":"87bpudp77t.fsf_-_@jidanni.org","subject":"Re: grammar patches not best use of talent","fromName":"","fromEmail":"jdelstrother@gmail.com","sentAt":"2009-01-12T08:54:16Z","receivedAt":"2009-01-12T08:54:16Z","isPatch":false,"sender":{"key":"jdelstrother@gmail.com","avatar":"https://gravatar.com/avatar/42e379ac542f06e3fc4282a9b97ddf25e79c67e4ade5c1fd3d6a9159942e138f?d=mp&s=160"},"body":"Wait, \"a handful X\" is now a legitimate form of \"a handful of X\"?  I\nassumed they were due to non-native speakers.\n\nOn 1/12/09, jidanni@jidanni.org <jidanni@jidanni.org> wrote:\n> I've decided to back out of my plan to patch grammar.\n> $ perl -nwle '/\\w+\\s+handful.*/i&& print $&' Documentation/*|sort -uf\n> a handful commits on top of that,\n> A handful documentation fixes.\n> A handful documentation updates.\n> a handful example hooks are copied in the\n> a handful fixes to run it\n> a handful of examples:\n> A handful of sample hooks are installed when\n> a handful pack-objects changes to help you cope better\n> a handful small fixes to gitweb.\n> a handful the real changes in non-zero\n> first handful of characters, show the full\n> only handful hexdigits prefix.\n> only handful hexdigits prefix.  Non default number of\n> only handful hexdigits prefix.  This is\n>\n> At first some of the above lines irritated me, but who am I to say\n> that English must be said like my mom says it, and is never allowed to\n> evolve further. Nope, I'll stick to correcting 2+2=3 type things.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n"},{"id":"100093","messageId":"7vtz84j29f.fsf@gitster.siamese.dyndns.org","threadId":"17089","inReplyTo":"57518fd10901120054o5fbe78f8he0a54f6d62216ad5@mail.gmail.com","subject":"Re: grammar patches not best use of talent","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-12T09:35:08Z","receivedAt":"2009-01-12T09:35:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"jdelstrother@gmail.com writes:\n\n> Wait, \"a handful X\" is now a legitimate form of \"a handful of X\"?  I\n> assumed they were due to non-native speakers.\n\nYou assumed correctly.\n\nJidanni is saying that _he_ thought about doing so, and then changed his\nmind.  I personally do not know what the point of saying such things on\nthe public list like this: you either just do it, or you don't, and you do\nnot add noise to the traffic by saying you won't do this nor that.\n\nIf you agree with me on the above point, just ignore the message you are\nresponding to (I am not saying \"just ignore _him_\"; at least not yet), and\nif you are inclined to help, please don't let the message you are\nresponding to discourage you.\n\nThanks.\n"}]}