{"thread":{"id":"17082","subject":"Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]","startedAt":"2009-01-10T20:34:05Z","lastAt":"2009-01-12T22:53:19Z","messageCount":3,"participants":["Robin Rosenberg","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"99921","messageId":"200901102134.05652.robin.rosenberg@dewire.com","threadId":"17082","inReplyTo":"142772020901071910ha95d53fo2454f8685908338c@mail.gmail.com","subject":"Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-10T20:34:05Z","receivedAt":"2009-01-10T20:34:05Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:\n> I have attached a small fix for when a git config has /r lines in the file.\n> I have to admit that I do not usually submit patches to the open source\n> community and I am not very familiar with the process :-) Please, please,\n> let me know if I can do something different next time!\n\n1) Inline the patch\nNo, need for such a large sign-off. It's good you declare that you have\nunderstand the SOB-line.\n\nYou can add \"extra\" comments that should not go into the cBommit after the\ncomment like this:\n\nFrom:.. etc\n\n\"This\" goes into the commit\n\nSigned-off-by: Whom Ever \n--- \n\nThe three dashes ends the comment. Anything after it and the actual patch\nwill be ignored by git am, but might be useful to the maintainer.\n\nBack to the patch. I think we should only ignore \\r (not /r, but could say CR in\na comment) before an LF. \n\n-- robin\n"},{"id":"100136","messageId":"20090112171045.GI10179@spearce.org","threadId":"17082","inReplyTo":"200901102134.05652.robin.rosenberg@dewire.com","subject":"Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-01-12T17:10:45Z","receivedAt":"2009-01-12T17:10:45Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Robin Rosenberg wrote:\n> torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:\n> > I have attached a small fix for when a git config has /r lines in the file.\n> > I have to admit that I do not usually submit patches to the open source\n> > community and I am not very familiar with the process :-) Please, please,\n> > let me know if I can do something different next time!\n> \n> Back to the patch. I think we should only ignore \\r (not /r, but could say CR in\n> a comment) before an LF. \n\nI disagree; ignoring CR anyplace in the file should be fine, unless\nit is within a double quoted value, in which case it should use\nthe same rule that \\n would use within the same region.\n\n' ', \\n, \\t all act the same with regards to being (mostly) ignored\nwhitespace. \\r is no different. Especially for anyone crazy enough\nto still be using a Mac style formatted file, with only CRs in it.\n\n-- \nShawn.\n"},{"id":"100188","messageId":"200901122353.19408.robin.rosenberg.lists@dewire.com","threadId":"17082","inReplyTo":"20090112171045.GI10179@spearce.org","subject":"Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2009-01-12T22:53:19Z","receivedAt":"2009-01-12T22:53:19Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"\"Shawn O. Pearce\" wrote\n> Robin Rosenberg wrote:\n> > torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:\n> > > I have attached a small fix for when a git config has /r lines in the file.\n> > > I have to admit that I do not usually submit patches to the open source\n> > > community and I am not very familiar with the process :-) Please, please,\n> > > let me know if I can do something different next time!\n> > \n> > Back to the patch. I think we should only ignore \\r (not /r, but could say CR in\n> > a comment) before an LF. \n> \n> I disagree; ignoring CR anyplace in the file should be fine, unless\n> it is within a double quoted value, in which case it should use\n> the same rule that \\n would use within the same region.\n> \n> ' ', \\n, \\t all act the same with regards to being (mostly) ignored\n> whitespace. \\r is no different. Especially for anyone crazy enough\n> to still be using a Mac style formatted file, with only CRs in it.\n\nThose are copied from in to out in the repo config parser today. Why\nshould ' \\r' be treated differently? Just CR (FF, Ctrl-G etc) is garbage, \nbut CRLF is a well established line terminator.\n\n-- robin\n"}]}