{"thread":{"id":"16977","subject":"[EGIT PATCH] Allow non-ASCII ref names when writing packs","startedAt":"2009-01-03T22:04:35Z","lastAt":"2009-01-03T22:11:38Z","messageCount":2,"participants":["Robin Rosenberg","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"99267","messageId":"1231020275-7637-1-git-send-email-robin.rosenberg@dewire.com","threadId":"16977","inReplyTo":null,"subject":"[EGIT PATCH] Allow non-ASCII ref names when writing packs","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-01-03T22:04:35Z","receivedAt":"2009-01-03T22:04:35Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../org/spearce/jgit/transport/PacketLineOut.java  |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\nDisovered this bug when trying to clone a local repo with some \"funny\" \nref names. C Git handles them so jgit should too.\n\n-- robin\n\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/PacketLineOut.java b/org.spearce.jgit/src/org/spearce/jgit/transport/PacketLineOut.java\nindex aae4be5..cb6d89a 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/transport/PacketLineOut.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/PacketLineOut.java\n@@ -54,7 +54,7 @@ PacketLineOut(final OutputStream i) {\n \t}\n \n \tvoid writeString(final String s) throws IOException {\n-\t\twritePacket(Constants.encodeASCII(s));\n+\t\twritePacket(Constants.encode(s));\n \t}\n \n \tvoid writePacket(final byte[] packet) throws IOException {\n-- \n1.6.1.rc3.56.gd0306\n"},{"id":"99268","messageId":"20090103221138.GB12438@spearce.org","threadId":"16977","inReplyTo":"1231020275-7637-1-git-send-email-robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH] Allow non-ASCII ref names when writing packs","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-01-03T22:11:38Z","receivedAt":"2009-01-03T22:11:38Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Robin Rosenberg <robin.rosenberg@dewire.com> wrote:\n> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n> ---\n>  .../org/spearce/jgit/transport/PacketLineOut.java  |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> Disovered this bug when trying to clone a local repo with some \"funny\" \n> ref names. C Git handles them so jgit should too.\n\nOy.  Good catch.\n \n-- \nShawn.\n"}]}