{"thread":{"id":"16962","subject":"[PATCH] gitweb: use href() when generating URLs in OPML","startedAt":"2009-01-02T12:15:28Z","lastAt":"2009-01-06T08:17:43Z","messageCount":3,"participants":["Giuseppe Bilotta","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"99164","messageId":"1230898528-24187-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"16962","inReplyTo":null,"subject":"[PATCH] gitweb: use href() when generating URLs in OPML","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2009-01-02T12:15:28Z","receivedAt":"2009-01-02T12:15:28Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"Since the OPML project list view was hand-coding the RSS and HTML URLs,\nit didn't respect global options such as use_pathinfo. Make it use\nhref() to ensure consistency with the rest of the gitweb setup.\n\nSigned-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n---\n gitweb/gitweb.perl |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex fa7d8ad..b164001 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -6146,8 +6146,8 @@ XML\n \t\t}\n \n \t\tmy $path = esc_html(chop_str($proj{'path'}, 25, 5));\n-\t\tmy $rss  = \"$my_url?p=$proj{'path'};a=rss\";\n-\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n+\t\tmy $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);\n+\t\tmy $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);\n \t\tprint \"<outline type=\\\"rss\\\" text=\\\"$path\\\" title=\\\"$path\\\" xmlUrl=\\\"$rss\\\" htmlUrl=\\\"$html\\\"/>\\n\";\n \t}\n \tprint <<XML;\n-- \n1.5.6.5\n"},{"id":"99165","messageId":"200901021409.07695.jnareb@gmail.com","threadId":"16962","inReplyTo":"1230898528-24187-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] gitweb: use href() when generating URLs in OPML","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-01-02T13:09:06Z","receivedAt":"2009-01-02T13:09:06Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Giuseppe Bilotta wrote:\n> Since the OPML project list view was hand-coding the RSS and HTML URLs,\n> it didn't respect global options such as use_pathinfo. Make it use\n> href() to ensure consistency with the rest of the gitweb setup.\n\nGood catch. I guess it was before href(..., -full=>1)...\n\n> \n> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n> ---\n>  gitweb/gitweb.perl |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index fa7d8ad..b164001 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -6146,8 +6146,8 @@ XML\n>  \t\t}\n>  \n>  \t\tmy $path = esc_html(chop_str($proj{'path'}, 25, 5));\n> -\t\tmy $rss  = \"$my_url?p=$proj{'path'};a=rss\";\n> -\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n> +\t\tmy $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);\n> +\t\tmy $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);\n>  \t\tprint \"<outline type=\\\"rss\\\" text=\\\"$path\\\" title=\\\"$path\\\" xmlUrl=\\\"$rss\\\" htmlUrl=\\\"$html\\\"/>\\n\";\n>  \t}\n>  \tprint <<XML;\n> -- \n> 1.5.6.5\n> \n> \n\n-- \nJakub Narebski\nPoland\n"},{"id":"99429","messageId":"7vaba4n908.fsf@gitster.siamese.dyndns.org","threadId":"16962","inReplyTo":"200901021409.07695.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: use href() when generating URLs in OPML","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-06T08:17:43Z","receivedAt":"2009-01-06T08:17:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both; applied.\n"}]}