{"thread":{"id":"16888","subject":"[PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root","startedAt":"2008-12-27T19:57:04Z","lastAt":"2008-12-27T22:36:21Z","messageCount":3,"participants":["jidanni@jidanni.org","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"98805","messageId":"E1LGfLz-0001nM-AO@jidanni.org","threadId":"16888","inReplyTo":null,"subject":"[PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-27T19:57:04Z","receivedAt":"2008-12-27T19:57:04Z","isPatch":true,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"However note --root is not mentioned in SYNOPSIS nor on its own line.\nAlso fixed grammar.\n\nSigned-off-by: jidanni <jidanni@jidanni.org>\n\ndiff --git a/git-format-patch.txt b/git-format-patch.txt\nindex ee27eff..51c25cd 100644\n--- a/git-format-patch.txt\n+++ b/git-format-patch.txt\n@@ -48 +48 @@ everything since project inception to one commit, say \"git\n-format-patch \\--root <commit>\" to make it clear that it is the\n+format-patch --root <commit>\" to make it clear that it is the\n@@ -166 +166 @@ not add any suffix.\n-\tthat they differ.  Note that this disable the patch to be properly\n+\tthat they differ.  Note that this disables the patch from being properly\n@@ -209 +209 @@ project:\n-$ git format-patch \\--root origin\n+$ git format-patch --root origin\n-- \n1.5.6.5\n"},{"id":"98815","messageId":"7v4p0pcliy.fsf@gitster.siamese.dyndns.org","threadId":"16888","inReplyTo":"E1LGfLz-0001nM-AO@jidanni.org","subject":"Re: [PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-27T22:15:33Z","receivedAt":"2008-12-27T22:15:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"jidanni@jidanni.org writes:\n\n> @@ -209 +209 @@ project:\n> -$ git format-patch \\--root origin\n> +$ git format-patch --root origin\n\nI thought these backslashes before double-dash are protecting the latter\nfrom being turned into em-dashes.  I do not see any weird backslash in the\n\"git help\" (aka \"manpage\") output nor in the HTML documentation, e.g.\n\n    http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html\n\nwithout your patch, so I have to say that this chunk is a useless churn.\n\nAll of your three patches lack context, which is essential enabler for\neasier review.  They have \"diff --git\" header, but are not made relative\nto the root of the project tree (i.e. lack \"Documentation/\" prefix), which\nis the norm for both the tool and for this project and this mailing list.\n\nI guess that you may be experimenting with various options to see how they\nwork, and the curiosity by itself is a good thing, but please do not make\nother people suffer with results from such experiments by sending patches\nin nonstandard forms.\n\nBy submitting a patch to try improving the system, you are already making\na difference in substance.  Please do not try to be creative in form.  It\nonly makes lives of other people unnecessarily harder with no real reason\nand wastes other people's time.  And it wastes yours, too.  A patch\nconforming to the norm is much easier to review, comment on and apply.\nOk?\n\n\"Don't try to be different in form, make a difference in substance\" also\napplies to your S-o-b line, by the way.\n"},{"id":"98816","messageId":"877i5ljlei.fsf@jidanni.org","threadId":"16888","inReplyTo":"7v4p0pcliy.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-27T22:36:21Z","receivedAt":"2008-12-27T22:36:21Z","isPatch":true,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"JCH> http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html\nThat looks OK. All I know is on Debian (1:1.5.6.5-2) it gets rendered:\n$ w3m -dump /usr/share/doc/git-doc/git-format-patch.html|fgrep \\\\-\n    $ git format-patch \\--root origin\n\nI was patching offline from Debian. OK, in the future I will clone\nupstream directly properly first.\n"}]}