{"thread":{"id":"1685","subject":"[PATCH] Update SubmittingPatches.","startedAt":"2005-08-29T00:57:08Z","lastAt":"2005-08-29T00:57:08Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7887","messageId":"7vk6i5ef17.fsf@assigned-by-dhcp.cox.net","threadId":"1685","inReplyTo":null,"subject":"[PATCH] Update SubmittingPatches.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-29T00:57:08Z","receivedAt":"2005-08-29T00:57:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\n- It does not matter how I read git list.  What matters is that\n  I do not necessarily read everything on it.\n\n- Talk a bit about how to use applymbox to check one's own\n  patches.\n\n- Talk a bit about PGP signed patches.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n\n---\n\n * Strictly speaking, PGP signing your message might make some\n   sense, not about what is in the patch (which isjudged by\n   technical merit alone), but about Signed-off-by: line when\n   later the patch is found that it should not have been sent to\n   the list to begin with.\n\n Documentation/SubmittingPatches |   62 +++++++++++++++++++++++++++++++++++----\n 1 files changed, 55 insertions(+), 7 deletions(-)\n\n9847f7e0db8359b3932fd51290d777610090c33f\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -73,14 +73,25 @@ MIME-attached change being accepted, but\n that it will be postponed.\n \n Exception:  If your mailer is mangling patches then someone may ask\n-you to re-send them using MIME.\n+you to re-send them using MIME, that is OK.\n \n-Note that your maintainer does not subscribe to the git mailing\n-list (he reads it via mail-to-news gateway).  If your patch is\n-for discussion first, send it \"To:\" the mailing list, and\n-optoinally \"cc:\" him.  If it is trivially correct or after list\n-discussion reached consensus, send it \"To:\" the maintainer and\n-optionally \"cc:\" the list.\n+Do not PGP sign your patch, at least for now.  Most likely, your\n+maintainer or other people on the list would not have your PGP\n+key and would not bother obtaining it anyway.  Your patch is not\n+judged by who you are; a good patch from an unknown origin has a\n+far better chance of being accepted than a patch from a known,\n+respected origin that is done poorly or does incorrect things.\n+\n+If you really really really really want to do a PGP signed\n+patch, format it as \"multipart/signed\", not a text/plain message\n+that starts with '-----BEGIN PGP SIGNED MESSAGE-----'.  That is\n+not a text/plain, it's something else.\n+\n+Note that your maintainer does not necessarily read everything\n+on the git mailing list.  If your patch is for discussion first,\n+send it \"To:\" the mailing list, and optionally \"cc:\" him.  If it\n+is trivially correct or after the list reached a consensus, send\n+it \"To:\" the maintainer and optionally \"cc:\" the list.\n \n \n (6) Sign your work\n@@ -143,6 +154,43 @@ I have seen:\n * Non empty context lines that have one extra whitespace at the\n   beginning.\n \n+One test you could do yourself if your MUA is set up correctly is:\n+\n+* Send the patch to yourself, exactly the way you would, except\n+  To: and Cc: lines, which would not contain the list and\n+  maintainer address.\n+\n+* Save that patch to a file in UNIX mailbox format.  Call it say\n+  a.patch.\n+\n+* Try to apply to the tip of the \"master\" branch from the\n+  git.git public repository:\n+\n+    $ git fetch http://kernel.org/pub/scm/git/git.git master:test-apply\n+    $ git checkout test-apply\n+    $ git reset --hard\n+    $ git applymbox a.patch\n+\n+If it does not apply correctly, there can be various reasons.\n+\n+* Your patch itself does not apply cleanly.  That is _bad_ but\n+  does not have much to do with your MUA.  Please rebase the\n+  patch appropriately.\n+\n+* Your MUA corrupted your patch; applymbox would complain that\n+  the patch does not apply.  Look at .dotest/ subdirectory and\n+  see what 'patch' file contains and check for the common\n+  corruption patterns mentioned above.\n+\n+* While you are at it, check what are in 'info' and\n+  'final-commit' files as well.  If what is in 'final-commit' is\n+  not exactly what you would want to see in the commit log\n+  message, it is very likely that your maintainer would end up\n+  hand editing the log message when he applies your patch.\n+  Things like \"Hi, this is my first patch.\\n\", if you really\n+  want to put in the patch e-mail, should come after the\n+  three-dash line that signals the end of the commit message.\n+\n \n Pine\n ----\n"}]}