{"thread":{"id":"16835","subject":"git 1.6.1-rc4 testing dependency","startedAt":"2008-12-22T15:06:37Z","lastAt":"2008-12-23T01:52:08Z","messageCount":4,"participants":["Peter van der Does","Junio C Hamano","Miklos Vajna"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"98547","messageId":"20081222100637.716c5b8a@montecarlo.grandprix.int","threadId":"16835","inReplyTo":null,"subject":"git 1.6.1-rc4 testing dependency","fromName":"Peter van der Does","fromEmail":"peter@ourvirtualhome.com","sentAt":"2008-12-22T15:06:37Z","receivedAt":"2008-12-22T15:06:37Z","isPatch":false,"sender":{"key":"peter@ourvirtualhome.com","avatar":"https://gravatar.com/avatar/b25de625e7ec33ce8ffc0b09abb0b92ced3882881c0eeaf5961d0023608dac2f?d=mp&s=160"},"body":"With git 1.6.1 it it seems you need to install the locale en_US.UTF-8\notherwise it won't pass the testing during building the package. \n\nThe locale comes in play with test:\nt9129-git-svn-i18n-commitencoding.sh \ncompare_svn_head_with () {\n LC_ALL=en_US.UTF-8 svn log --limit 1 `git svn info --url` | \\\n sed -e 1,3d -e \"/^-\\{1,\\}\\$/d\" >current &&\n test_cmp current \"$1\"\n}\n\nOn my building machine I don't have any locales installed, making the\nLC_ALL=C.\nNot everybody will have this locale installed nor would they want it\ninstalled on their machines.\nIs the locale is a dependency for git svn?\nOr can this test be changed? Either by not having the locale dependency\nor by skipping the test completely?\n\n\n-- \nPeter van der Does\n\nGPG key: E77E8E98\n\n"},{"id":"98556","messageId":"7vzliogcie.fsf@gitster.siamese.dyndns.org","threadId":"16835","inReplyTo":"20081222100637.716c5b8a@montecarlo.grandprix.int","subject":"Re: git 1.6.1-rc4 testing dependency","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-22T20:50:49Z","receivedAt":"2008-12-22T20:50:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter van der Does writes:\n\n> On my building machine I don't have any locales installed, making the\n> LC_ALL=C.\n> Not everybody will have this locale installed nor would they want it\n> installed on their machines.\n\nI think some tests play nicer than this one and skip tests that want UTF-8\nlocales; you may want to teach this script the same trick.\n\nIn the meantime, perhaps \"GIT_SKIP_TETS='t9129' make test\" would help.\n"},{"id":"98586","messageId":"1229994564-5153-1-git-send-email-vmiklos@frugalware.org","threadId":"16835","inReplyTo":"7vzliogcie.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] t9129: skip the last two tests if UTF-8 locale not available","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-23T01:09:24Z","receivedAt":"2008-12-23T01:09:24Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n\nOn Mon, Dec 22, 2008 at 12:50:49PM -0800, Junio C Hamano wrote:\n> I think some tests play nicer than this one and skip tests that want\n> UTF-8 locales; you may want to teach this script the same trick.\n\nWhat about this?\n\nTesed on two Linux boxes (where I have / do not have UTF-8) and HP-UX\n(where I do not have, either).\n\n t/t9129-git-svn-i18n-commitencoding.sh | 30 +++++++++++++++++-------------\n 1 files changed, 17 insertions(+), 13 deletions(-)\n\ndiff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh\nindex 938b7fe..8a9dde4 100755\n--- a/t/t9129-git-svn-i18n-commitencoding.sh\n+++ b/t/t9129-git-svn-i18n-commitencoding.sh\n@@ -60,21 +60,25 @@ do\n \t'\n done\n \n-test_expect_success 'ISO-8859-1 should match UTF-8 in svn' '\n-(\n-\tcd ISO-8859-1 &&\n-\tcompare_svn_head_with \"$TEST_DIRECTORY\"/t3900/1-UTF-8.txt\n-)\n-'\n-\n-for H in EUCJP ISO-2022-JP\n-do\n-\ttest_expect_success '$H should match UTF-8 in svn' '\n+if locale -a |grep -q en_US.utf8; then\n+\ttest_expect_success 'ISO-8859-1 should match UTF-8 in svn' '\n \t(\n-\t\tcd $H &&\n-\t\tcompare_svn_head_with \"$TEST_DIRECTORY\"/t3900/2-UTF-8.txt\n+\t\tcd ISO-8859-1 &&\n+\t\tcompare_svn_head_with \"$TEST_DIRECTORY\"/t3900/1-UTF-8.txt\n \t)\n \t'\n-done\n+\n+\tfor H in EUCJP ISO-2022-JP\n+\tdo\n+\t\ttest_expect_success '$H should match UTF-8 in svn' '\n+\t\t(\n+\t\t\tcd $H &&\n+\t\t\tcompare_svn_head_with \"$TEST_DIRECTORY\"/t3900/2-UTF-8.txt\n+\t\t)\n+\t\t'\n+\tdone\n+else\n+\tsay \"UTF-8 locale not available, test skipped\"\n+fi\n \n test_done\n-- \n1.6.1.rc1.35.gae26e.dirty\n"},{"id":"98587","messageId":"7vy6y7fyk7.fsf@gitster.siamese.dyndns.org","threadId":"16835","inReplyTo":"1229994564-5153-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] t9129: skip the last two tests if UTF-8 locale not available","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-23T01:52:08Z","receivedAt":"2008-12-23T01:52:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> Signed-off-by: Miklos Vajna \n> ---\n>\n> On Mon, Dec 22, 2008 at 12:50:49PM -0800, Junio C Hamano wrote:\n>> I think some tests play nicer than this one and skip tests that want\n>> UTF-8 locales; you may want to teach this script the same trick.\n>\n> What about this?\n>\n> Tesed on two Linux boxes (where I have / do not have UTF-8) and HP-UX\n> (where I do not have, either).\n\nThanks.\n\nPeter, is this the only test that you had trouble with, and does Miklos's\npatch help your environment?\n"}]}