{"thread":{"id":"16773","subject":"git-format-patch patch","startedAt":"2008-12-17T20:53:42Z","lastAt":"2008-12-20T00:52:17Z","messageCount":18,"participants":["jidanni@jidanni.org","Miklos Vajna","Jeff King","Junio C Hamano","Nanako Shiraishi","Bernt Hansen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"98184","messageId":"877i5yy149.fsf@jidanni.org","threadId":"16773","inReplyTo":null,"subject":"git-format-patch patch","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-17T20:53:42Z","receivedAt":"2008-12-17T20:53:42Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"I'm still reading the manpage about submitting proper patches, so for now:\n\n*** /tmp/git-format-patch.txt\t2008-12-18 04:41:34.050800884 +0800\n--- /tmp/git-format-patchNEW.txt\t2008-12-18 04:46:25.738801367 +0800\n***************\n*** 127,133 ****\n --in-reply-to=Message-Id::\n \tMake the first mail (or all the mails with --no-thread) appear as a\n \treply to the given Message-Id, which avoids breaking threads to\n! \tprovide a new patch series.\n \n --ignore-if-in-upstream::\n \tDo not include a patch that matches a commit in\n--- 127,134 ----\n --in-reply-to=Message-Id::\n \tMake the first mail (or all the mails with --no-thread) appear as a\n \treply to the given Message-Id, which avoids breaking threads to\n! \tprovide a new patch series. Generates coresponding References and\n! \tIn-Reply-To headers. Angle brackets around are optional.\n \n --ignore-if-in-upstream::\n \tDo not include a patch that matches a commit in\n"},{"id":"98190","messageId":"20081217215535.GI5691@genesis.frugalware.org","threadId":"16773","inReplyTo":"877i5yy149.fsf@jidanni.org","subject":"Re: git-format-patch patch","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-17T21:55:35Z","receivedAt":"2008-12-17T21:55:35Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Thu, Dec 18, 2008 at 04:53:42AM +0800, jidanni@jidanni.org wrote:\n> I'm still reading the manpage about submitting proper patches, so for now:\n\nIt is not a manual page, it lives under Documentation/SubmittingPatches.\n\nProblems with the current patch:\n\n- It is not a unidiff.\n\n- No signoff\n\n- No commit message\n\nHope this helps. :)\n"},{"id":"98238","messageId":"20081218083515.GB29356@coredump.intra.peff.net","threadId":"16773","inReplyTo":"877i5yy149.fsf@jidanni.org","subject":"Re: git-format-patch patch","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-12-18T08:35:15Z","receivedAt":"2008-12-18T08:35:15Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Dec 18, 2008 at 04:53:42AM +0800, jidanni@jidanni.org wrote:\n\n> I'm still reading the manpage about submitting proper patches, so for now:\n\nIt looks like you didn't even use git to create it (since it is a\ncontext diff and the filenames are obviously bogus). If you are\ncommitted to improving git, then surely using it is not so bad? :)\n\nTry cloning git://git.kernel.org/pub/scm/git/git.git, or if you just\nhave a tarball, at least do \"cd /path/to/git && git init && git add . &&\ngit commit -m 'import from git version $whatever'\". Then you can make\nyour changes and have git track them and prepare them for submission.\n\nThen read Documentation/SubmittingPatches, which covers some of the\nbasics. Besides the format not being applicable by regular git tools:\n\n - there is no commit message describing the changes, nor the reasoning\n behind them\n\n - it was not sent to the maintainer (who does read the list, but does\n not always read every message).\n\n> --in-reply-to=Message-Id::\n> \tMake the first mail (or all the mails with --no-thread) appear as a\n> \treply to the given Message-Id, which avoids breaking threads to\n> ! \tprovide a new patch series. Generates coresponding References and\n> ! \tIn-Reply-To headers. Angle brackets around are optional.\n\nAs for the change itself, it looks reasonable to me.\n\n-Peff\n"},{"id":"98240","messageId":"7vzlitho1o.fsf@gitster.siamese.dyndns.org","threadId":"16773","inReplyTo":"20081218083515.GB29356@coredump.intra.peff.net","subject":"Re: git-format-patch patch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-18T08:42:43Z","receivedAt":"2008-12-18T08:42:43Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> ... Besides the format not being applicable by regular git tools:\n>\n> - there is no commit message describing the changes, nor the reasoning\n> behind them\n>\n> - it was not sent to the maintainer (who does read the list, but does\n> not always read every message).\n\nActually, it would probably be a good idea not to send your first patch to\nme and instead to request for comments from the list ;-)n\n\nThe worst offence of the message was the choice of bad Subject that\nstrongly encouraged anyone to skip it. Consider:\n\n\tSubject: [PATCH] document \"format-patch --in-reply-to\" better\n\nor something like that.\n"},{"id":"98365","messageId":"87k59wc73n.fsf@jidanni.org","threadId":"16773","inReplyTo":"7vzlitho1o.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] Clarify git-format-patch --in-reply-to","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-19T19:12:12Z","receivedAt":"2008-12-19T19:12:12Z","isPatch":true,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Signed-off-by: jidanni \n\ndiff --git a/git-format-patch.txt b/git-format-patch.txt\nindex ee27eff..04958de 100644\n--- a/git-format-patch.txt\n+++ b/git-format-patch.txt\n@@ -130 +130,2 @@ include::diff-options.txt[]\n-\tprovide a new patch series.\n+\tprovide a new patch series. Generates coresponding References and\n+\tIn-Reply-To headers. Angle brackets around are optional.\n-- \n1.5.6.5\n"},{"id":"98377","messageId":"20081220065135.6117@nanako3.lavabit.com","threadId":"16773","inReplyTo":"87k59wc73n.fsf@jidanni.org","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"Nanako Shiraishi","fromEmail":"nanako3@lavabit.com","sentAt":"2008-12-19T21:51:35Z","receivedAt":"2008-12-19T21:51:35Z","isPatch":true,"sender":{"key":"nanako3@lavabit.com","avatar":"https://gravatar.com/avatar/3777b9e201c5883a62b1a6fdf7c53f2d712d1d80989146063ea861e33aad72a8?d=mp&s=160"},"body":"Quoting jidanni@jidanni.org:\n\n> Signed-off-by: jidanni \n\nI understand that \"Signed-off-by\" is about code ownership and thought that the official history prefers to have a real name instead of a pseudonym. Perhaps you would want to say \"Dan Jacobson \" or something similar?\n\n-- \nNanako Shiraishi\nhttp://ivory.ap.teacup.com/nanako3/\n"},{"id":"98382","messageId":"87bpv77rkv.fsf@gollum.intra.norang.ca","threadId":"16773","inReplyTo":"87k59wc73n.fsf@jidanni.org","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"Bernt Hansen","fromEmail":"bernt@norang.ca","sentAt":"2008-12-19T22:01:04Z","receivedAt":"2008-12-19T22:01:04Z","isPatch":true,"sender":{"key":"bernt@norang.ca","avatar":null},"body":"jidanni@jidanni.org writes:\n\n> Signed-off-by: jidanni \n>\n> diff --git a/git-format-patch.txt b/git-format-patch.txt\n> index ee27eff..04958de 100644\n> --- a/git-format-patch.txt\n> +++ b/git-format-patch.txt\n> @@ -130 +130,2 @@ include::diff-options.txt[]\n> -\tprovide a new patch series.\n> +\tprovide a new patch series. Generates coresponding References and\n ^^^^^^^^^^^^\nTypo corresponding\n> +\tIn-Reply-To headers. Angle brackets around are optional.\n> -- \n> 1.5.6.5\n"},{"id":"98379","messageId":"20081219222209.GG21154@genesis.frugalware.org","threadId":"16773","inReplyTo":"20081220065135.6117@nanako3.lavabit.com","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-19T22:22:09Z","receivedAt":"2008-12-19T22:22:09Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Dec 20, 2008 at 06:51:35AM +0900, Nanako Shiraishi wrote:\n> I understand that \"Signed-off-by\" is about code ownership and thought\n> that the official history prefers to have a real name instead of a\n> pseudonym. Perhaps you would want to say \"Dan Jacobson\n> \" or something similar?\n\nI don't think it's a requirement, see 2b36b14 for example. Though yes,\nin general it's considered childish to hide behind a nickname, instead\nof using your real name. (ESR has a section about this in the \"hacker\nhowto\".)\n"},{"id":"98381","messageId":"87k59vby27.fsf@jidanni.org","threadId":"16773","inReplyTo":"20081220065135.6117@nanako3.lavabit.com","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-19T22:27:28Z","receivedAt":"2008-12-19T22:27:28Z","isPatch":true,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"NS> I understand that \"Signed-off-by\" is about code ownership and\nNS> thought that the official history prefers to have a real name\nNS> instead of a pseudonym. Perhaps you would want to say \"Dan\nNS> Jacobson \" or something similar?\n\nThanks but I want to be http://zh.wikipedia.org/wiki/積丹尼\n(which is what all my ID cards say) and not any\nhttp://en.wikipedia.org/wiki/Jacobson , http://en.wikipedia.org/wiki/Jacobsen .\nI've completed a name-change operation, and prefer to use my post-op name.\nChildish? Bingo.\n"},{"id":"98383","messageId":"20081219223306.GH21154@genesis.frugalware.org","threadId":"16773","inReplyTo":"87k59vby27.fsf@jidanni.org","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-19T22:33:06Z","receivedAt":"2008-12-19T22:33:06Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Dec 20, 2008 at 06:27:28AM +0800, jidanni@jidanni.org wrote:\n> NS> I understand that \"Signed-off-by\" is about code ownership and\n> NS> thought that the official history prefers to have a real name\n> NS> instead of a pseudonym. Perhaps you would want to say \"Dan\n> NS> Jacobson \" or something similar?\n> \n> Thanks but I want to be http://zh.wikipedia.org/wiki/?????????\n> (which is what all my ID cards say) and not any\n> http://en.wikipedia.org/wiki/Jacobson , http://en.wikipedia.org/wiki/Jacobsen .\n> I've completed a name-change operation, and prefer to use my post-op name.\n\nWho said you can't use utf-8 chars in the author field?\n\nSee\nhttp://repo.or.cz/w/git.git?a=commit;h=6b312253cb6e8b21e74882a3ae0972fac1290244\nfor example.\n"},{"id":"98386","messageId":"7vhc4z7oia.fsf@gitster.siamese.dyndns.org","threadId":"16773","inReplyTo":"20081219222209.GG21154@genesis.frugalware.org","subject":"Re: [PATCH] Clarify git-format-patch --in-reply-to","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-19T23:07:25Z","receivedAt":"2008-12-19T23:07:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> On Sat, Dec 20, 2008 at 06:51:35AM +0900, Nanako Shiraishi wrote:\n>> I understand that \"Signed-off-by\" is about code ownership and thought\n>> that the official history prefers to have a real name instead of a\n>> pseudonym. Perhaps you would want to say \"Dan Jacobson\n>> \" or something similar?\n>\n> I don't think it's a requirement, see 2b36b14 for example. Though yes,\n> in general it's considered childish to hide behind a nickname, instead\n> of using your real name. (ESR has a section about this in the \"hacker\n> howto\".)\n\nAn earlier mistake does not justify adding new ones. Besides, I think\nALASCM once revealed his \"real name\" on the list.\n"},{"id":"98389","messageId":"87fxkjbvl3.fsf_-_@jidanni.org","threadId":"16773","inReplyTo":"20081219223306.GH21154@genesis.frugalware.org","subject":"just can't live without a user.name","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-19T23:20:56Z","receivedAt":"2008-12-19T23:20:56Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Actually it's all git's fault for not working if user.name is null or\nunset. Ask yourself, would email programs panic if all there was only\nbob@example.org in a header?\n> But we need a user.name for legal reasons.\nBut there should be a way to override it, in case those laws don't apply.\nI want\n Author: jidanni@jidanni.org\nlike my email address above. But the closest I can get is\n Author: jidanni \nAnd then there are some programs that need\n$ git config --global user.name $USER\njust to get that, else the springs come loose:\n$ git-format-patch -s\n*** Please tell me who you are.\nRun\n git config --global user.email \"you@example.com\"\n git config --global user.name \"Your Name\"\nto set your account's default identity.\nOmit --global to set the identity only in this repository.\nfatal: empty ident not allowed\n"},{"id":"98397","messageId":"20081220000803.GK21154@genesis.frugalware.org","threadId":"16773","inReplyTo":"87fxkjbvl3.fsf_-_@jidanni.org","subject":"Re: just can't live without a user.name","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-20T00:08:03Z","receivedAt":"2008-12-20T00:08:03Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Dec 20, 2008 at 07:20:56AM +0800, jidanni@jidanni.org wrote:\n> Actually it's all git's fault for not working if user.name is null or\n> unset.\n\nPlease don't turn this thread into a flame.\n\nIf I understand correctly, you said you hide your name because you can't\nuse your real name and using some limited ASCII replacement makes you\nunhappy.\n\nI said you can use utf-8 in the user.name field and showed you an\nexample about this.\n\nInstead of replying to this, you just did not quote any parts of my\nmessage, but started to talk about you don't want to show your real name\nat all. What's the point of doing so?\n"},{"id":"98398","messageId":"7vmyer66nj.fsf@gitster.siamese.dyndns.org","threadId":"16773","inReplyTo":"20081220000803.GK21154@genesis.frugalware.org","subject":"Re: just can't live without a user.name","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-20T00:18:24Z","receivedAt":"2008-12-20T00:18:24Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> On Sat, Dec 20, 2008 at 07:20:56AM +0800, jidanni@jidanni.org wrote:\n>> Actually it's all git's fault for not working if user.name is null or\n>> unset.\n>\n> Please don't turn this thread into a flame.\n\nJust pay attention to messages in which he says something that adds value\nto the discussion, and simply ignore the rest.\n"},{"id":"98399","messageId":"1229732427-14740-1-git-send-email-vmiklos@frugalware.org","threadId":"16773","inReplyTo":"7vhc4z7oia.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] SubmittingPatches: mention the usage of real name in Signed-off-by: lines","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-20T00:20:27Z","receivedAt":"2008-12-20T00:20:27Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Especially with something that is supposed to hopefully have some legal\nvalue down the line if somebody starts making noises, it really would be\nnice to have a real person to associate things with. Suggest this in the\nSubmittingPatches document.\n\nSigned-off-by: Miklos Vajna \n---\n\nOn Fri, Dec 19, 2008 at 03:07:25PM -0800, Junio C Hamano wrote:\n> An earlier mistake does not justify adding new ones. Besides, I think\n> ALASCM once revealed his \"real name\" on the list.\n\nAh, true ($gmane/7946). Then maybe something like this would be good to\nhave? The commit message is mostly copy&paste from Linus' message.\n\n Documentation/SubmittingPatches | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex f0295c6..530aa25 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -222,6 +222,9 @@ D-C-O. Indeed you are encouraged to do so. Do not forget to\n place an in-body \"From: \" line at the beginning to properly attribute\n the change to its true author (see (2) above).\n \n+Also notice that a real name is used in the Signed-off-by: line. Please\n+don't be childish and don't hide your real name.\n+\n Some people also put extra tags at the end.\n \n \"Acked-by:\" says that the patch was reviewed by the person who\n-- \n1.6.1.rc1.35.gae26e.dirty\n"},{"id":"98402","messageId":"877i5vbs2m.fsf@jidanni.org","threadId":"16773","inReplyTo":"20081220000803.GK21154@genesis.frugalware.org","subject":"Re: just can't live without a user.name","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-20T00:36:49Z","receivedAt":"2008-12-20T00:36:49Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"MV> I said you can use utf-8 in the user.name field and showed you an example\nBut I want to use null or (my favorite string of) ASCII.\nAnyway no program so far on UNIX broke with just\n$ grep $USER /etc/passwd\njidanni:x:1000:1000:,,,:/home/jidanni:/bin/bash\nexcept git.\n"},{"id":"98403","messageId":"7vbpv765oc.fsf@gitster.siamese.dyndns.org","threadId":"16773","inReplyTo":"1229732427-14740-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] SubmittingPatches: mention the usage of real name in Signed-off-by: lines","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-20T00:39:31Z","receivedAt":"2008-12-20T00:39:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> Especially with something that is supposed to hopefully have some legal\n> value down the line if somebody starts making noises, it really would be\n> nice to have a real person to associate things with.\n\nI would agree with the reasoning, but do we have to say \"childish\" just to\nbe derogatory? I think that is counterproductive.\n"},{"id":"98404","messageId":"1229734337-14853-1-git-send-email-vmiklos@frugalware.org","threadId":"16773","inReplyTo":"7vbpv765oc.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] SubmittingPatches: mention the usage of real name in Signed-off-by: lines","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-20T00:52:17Z","receivedAt":"2008-12-20T00:52:17Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Especially with something that is supposed to hopefully have some legal\nvalue down the line if somebody starts making noises, it really would be\nnice to have a real person to associate things with. Suggest this in the\nSubmittingPatches document.\n\nSigned-off-by: Miklos Vajna \n---\n\nOn Fri, Dec 19, 2008 at 04:39:31PM -0800, Junio C Hamano wrote:\n> I would agree with the reasoning, but do we have to say \"childish\"\n> just to\n> be derogatory? I think that is counterproductive.\n\nTrue.\n\n Documentation/SubmittingPatches | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex f0295c6..ba07c8c 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -222,6 +222,9 @@ D-C-O. Indeed you are encouraged to do so. Do not forget to\n place an in-body \"From: \" line at the beginning to properly attribute\n the change to its true author (see (2) above).\n \n+Also notice that a real name is used in the Signed-off-by: line. Please\n+don't hide your real name.\n+\n Some people also put extra tags at the end.\n \n \"Acked-by:\" says that the patch was reviewed by the person who\n-- \n1.6.1.rc1.35.gae26e.dirty\n"}]}