{"thread":{"id":"16734","subject":"Interactive rebase encoding","startedAt":"2008-12-15T12:42:08Z","lastAt":"2008-12-15T16:56:18Z","messageCount":5,"participants":["Constantine Plotnikov","Miklos Vajna","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97953","messageId":"85647ef50812150442n48609eadl4f3e47fcc715e643@mail.gmail.com","threadId":"16734","inReplyTo":null,"subject":"Interactive rebase encoding","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2008-12-15T12:42:08Z","receivedAt":"2008-12-15T12:42:08Z","isPatch":false,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"The interactive rebase command builds a text file and passes it to\neditor specified as environment variable or as configuration\nparameter. However the man page for rebase operation says nothing\nabout which encoding will be used for that file. Apparently\ni18n.logoutputencoding is used. I think that the man page for rebase\noperation should explicitly specify it.\n\nAlso it might make sense to use explicit encoding parameter for\ninteractive rebase operation.\n\nConstantine\n"},{"id":"97966","messageId":"20081215151322.GI5691@genesis.frugalware.org","threadId":"16734","inReplyTo":"85647ef50812150442n48609eadl4f3e47fcc715e643@mail.gmail.com","subject":"Re: Interactive rebase encoding","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-15T15:13:22Z","receivedAt":"2008-12-15T15:13:22Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Mon, Dec 15, 2008 at 03:42:08PM +0300, Constantine Plotnikov wrote:\n> The interactive rebase command builds a text file and passes it to\n> editor specified as environment variable or as configuration\n> parameter. However the man page for rebase operation says nothing\n> about which encoding will be used for that file. Apparently\n> i18n.logoutputencoding is used. I think that the man page for rebase\n> operation should explicitly specify it.\n\nCare to send a patch?\n\n> Also it might make sense to use explicit encoding parameter for\n> interactive rebase operation.\n\nDo you have a use-case where having a different encoding for log output\nand rebase -i todo list makes sense?\n\nThanks.\n"},{"id":"97967","messageId":"alpine.DEB.1.00.0812151652400.30769@pacific.mpi-cbg.de","threadId":"16734","inReplyTo":"85647ef50812150442n48609eadl4f3e47fcc715e643@mail.gmail.com","subject":"Re: Interactive rebase encoding","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-15T15:54:17Z","receivedAt":"2008-12-15T15:54:17Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 15 Dec 2008, Constantine Plotnikov wrote:\n\n> The interactive rebase command builds a text file and passes it to \n> editor specified as environment variable or as configuration parameter. \n> However the man page for rebase operation says nothing about which \n> encoding will be used for that file. Apparently i18n.logoutputencoding \n> is used.\n\nAs rebase -i does nothing else than piping the output of git log into a \nfile (at least this is the first step), I thought it would be obvious that \nit uses the output encoding preferred by the user.\n\nIndeed, I cannot think of any scenario where it might make sense to have a \ndifferent encoding in git rebase -i than in git log.\n\nCiao,\nDscho\n"},{"id":"97972","messageId":"85647ef50812150821g4a032af0u31425fd7f4c0fd9@mail.gmail.com","threadId":"16734","inReplyTo":"alpine.DEB.1.00.0812151652400.30769@pacific.mpi-cbg.de","subject":"Re: Interactive rebase encoding","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2008-12-15T16:21:07Z","receivedAt":"2008-12-15T16:21:07Z","isPatch":false,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"On Mon, Dec 15, 2008 at 6:54 PM, Johannes Schindelin\n wrote:\n> Hi,\n>\n> On Mon, 15 Dec 2008, Constantine Plotnikov wrote:\n>\n>> The interactive rebase command builds a text file and passes it to\n>> editor specified as environment variable or as configuration parameter.\n>> However the man page for rebase operation says nothing about which\n>> encoding will be used for that file. Apparently i18n.logoutputencoding\n>> is used.\n>\n> As rebase -i does nothing else than piping the output of git log into a\n> file (at least this is the first step), I thought it would be obvious that\n> it uses the output encoding preferred by the user.\n\nYes. That was my first hypothesis, but I had to check it through small\nexperiment and source code examination. And if consider the bug\ndescribed in the thread\nhttp://kerneltrap.org/mailarchive/git/2008/11/11/4063184, the\nhypothesis might have been incorrect.\n\n>\n> Indeed, I cannot think of any scenario where it might make sense to have a\n> different encoding in git rebase -i than in git log.\n>\n\nFor IDE, it might make sense to force UTF-8 encoding instead of using\ncurrently configured logoutputencoding. Currently the extra call to\ngit config is needed to check expected encoding of the file before\ndata could be shown to the user. Also user specified encoding might\nfail to display some characters in commit messages that was encoded\nusing other encodings, forcing UTF-8 would have also fixed this\nproblem as well.\n\nBTW for IDEs an option that causes non-abbreviated commit hashes would\nhave been useful as well.\n\nConstantine\n"},{"id":"97974","messageId":"alpine.DEB.1.00.0812151755040.30769@pacific.mpi-cbg.de","threadId":"16734","inReplyTo":"85647ef50812150821g4a032af0u31425fd7f4c0fd9@mail.gmail.com","subject":"Re: Interactive rebase encoding","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-15T16:56:18Z","receivedAt":"2008-12-15T16:56:18Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 15 Dec 2008, Constantine Plotnikov wrote:\n\n> On Mon, Dec 15, 2008 at 6:54 PM, Johannes Schindelin\n> wrote:\n> >\n> > Indeed, I cannot think of any scenario where it might make sense to \n> > have a different encoding in git rebase -i than in git log.\n> \n> For IDE, it might make sense to force UTF-8 encoding instead of using \n> currently configured logoutputencoding.\n\nI consider rebase -i to be porcelain, and as such not suitable to be used \nas a backend for an IDE. Help the git-sequencer effort if you want a \nplumbing.\n\nCiao,\nDscho\n"}]}