{"thread":{"id":"16715","subject":"[PATCH] bash completion: remove deprecated --prune from git-gc","startedAt":"2008-12-13T19:08:08Z","lastAt":"2008-12-15T18:06:17Z","messageCount":8,"participants":["Markus Heidelberg","Johannes Schindelin","Jeff King","Jakub Narebski","Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"97805","messageId":"200812132008.08543.markus.heidelberg@web.de","threadId":"16715","inReplyTo":null,"subject":"[PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2008-12-13T19:08:08Z","receivedAt":"2008-12-13T19:08:08Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c79c98f..9e0c48b 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -835,7 +835,7 @@ _git_gc ()\n \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n \tcase \"$cur\" in\n \t--*)\n-\t\t__gitcomp \"--prune --aggressive\"\n+\t\t__gitcomp \"--aggressive\"\n \t\treturn\n \t\t;;\n \tesac\n-- \n1.6.1.rc1.54.gd1643\n"},{"id":"97852","messageId":"alpine.DEB.1.00.0812141137350.2014@eeepc-johanness","threadId":"16715","inReplyTo":"200812132008.08543.markus.heidelberg@web.de","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-14T10:38:17Z","receivedAt":"2008-12-14T10:38:17Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 13 Dec 2008, Markus Heidelberg wrote:\n\n> -\t\t__gitcomp \"--prune --aggressive\"\n> +\t\t__gitcomp \"--aggressive\"\n\ngit gc --prune is deprecated?  That's news to me.\n\nHow would you suggest, then, to remove the loose objects you always get \nwith conflicts in a merge?\n\nCiao,\nDscho\n"},{"id":"97860","messageId":"20081214111213.GA6499@coredump.intra.peff.net","threadId":"16715","inReplyTo":"alpine.DEB.1.00.0812141137350.2014@eeepc-johanness","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-12-14T11:12:13Z","receivedAt":"2008-12-14T11:12:13Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Dec 14, 2008 at 11:38:17AM +0100, Johannes Schindelin wrote:\n\n> > -\t\t__gitcomp \"--prune --aggressive\"\n> > +\t\t__gitcomp \"--aggressive\"\n> git gc --prune is deprecated?  That's news to me.\n\nCheck out 9e7d501 (builtin-gc.c: deprecate --prune, it now really has no\neffect, 2008-05-09).\n\nWhich annoyingly has no discussion about _why_ it no longer has an\neffect. But I suspect it has something to do with 25ee973 (gc: call\n\"prune --expire 2.weeks.ago\" by default, 2008-03-12) by you.\n\n-Peff\n"},{"id":"97861","messageId":"alpine.DEB.1.00.0812141216120.2014@eeepc-johanness","threadId":"16715","inReplyTo":"20081214111213.GA6499@coredump.intra.peff.net","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-14T11:17:07Z","receivedAt":"2008-12-14T11:17:07Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 14 Dec 2008, Jeff King wrote:\n\n> On Sun, Dec 14, 2008 at 11:38:17AM +0100, Johannes Schindelin wrote:\n> \n> > > -\t\t__gitcomp \"--prune --aggressive\"\n> > > +\t\t__gitcomp \"--aggressive\"\n> > git gc --prune is deprecated?  That's news to me.\n> \n> Check out 9e7d501 (builtin-gc.c: deprecate --prune, it now really has no\n> effect, 2008-05-09).\n> \n> Which annoyingly has no discussion about _why_ it no longer has an\n> effect. But I suspect it has something to do with 25ee973 (gc: call\n> \"prune --expire 2.weeks.ago\" by default, 2008-03-12) by you.\n\nOops.\n\nBut I thought that git gc --prune does expire _all_ dangling loose \nobjects _now_, not with --expire 2.weeks.ago.\n\nCiao,\nDscho\n"},{"id":"97864","messageId":"20081214111939.GC6499@coredump.intra.peff.net","threadId":"16715","inReplyTo":"alpine.DEB.1.00.0812141216120.2014@eeepc-johanness","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-12-14T11:19:39Z","receivedAt":"2008-12-14T11:19:39Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Dec 14, 2008 at 12:17:07PM +0100, Johannes Schindelin wrote:\n\n> > Which annoyingly has no discussion about _why_ it no longer has an\n> > effect. But I suspect it has something to do with 25ee973 (gc: call\n> > \"prune --expire 2.weeks.ago\" by default, 2008-03-12) by you.\n> \n> Oops.\n> \n> But I thought that git gc --prune does expire _all_ dangling loose \n> objects _now_, not with --expire 2.weeks.ago.\n\nNope, see 25ee973. You explicitly wrote:\n\n      Note that this new behaviour makes \"--prune\" be a no-op.\n\nThat being said, I think that is perhaps a reasonable thing for --prune\nto do (and I don't think there is any conflict with the name, because\nthat is what it _used_ to do before becoming a no-op). But nobody has\nactually implemented it.\n\n-Peff\n"},{"id":"97866","messageId":"m3hc57dmrl.fsf@localhost.localdomain","threadId":"16715","inReplyTo":"alpine.DEB.1.00.0812141137350.2014@eeepc-johanness","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-12-14T11:23:39Z","receivedAt":"2008-12-14T11:23:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> On Sat, 13 Dec 2008, Markus Heidelberg wrote:\n> \n> > -\t\t__gitcomp \"--prune --aggressive\"\n> > +\t\t__gitcomp \"--aggressive\"\n> \n> git gc --prune is deprecated?  That's news to me.\n\nMore like \"git gc --prune\" is no-op now.\n \n> How would you suggest, then, to remove the loose objects you always get \n> with conflicts in a merge?\n\n\"git gc\" does pruning of loose objects, but protected by grace period\nfor loose objects with gc.pruneexpire\n\nYou always have (admittedly lowe level) git-prune.\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"97975","messageId":"0zFE1s-V9qRpO8jkUYC05iTwrouhwDxFz3yJgo_P3R0KZaGeJ6jKSg@cipher.nrlssc.navy.mil","threadId":"16715","inReplyTo":"20081214111213.GA6499@coredump.intra.peff.net","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-12-15T16:51:46Z","receivedAt":"2008-12-15T16:51:46Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Jeff King wrote:\n> On Sun, Dec 14, 2008 at 11:38:17AM +0100, Johannes Schindelin wrote:\n> \n>>> -\t\t__gitcomp \"--prune --aggressive\"\n>>> +\t\t__gitcomp \"--aggressive\"\n>> git gc --prune is deprecated?  That's news to me.\n> \n> Check out 9e7d501 (builtin-gc.c: deprecate --prune, it now really has no\n> effect, 2008-05-09).\n> \n> Which annoyingly has no discussion about _why_ it no longer has an\n> effect. But I suspect it has something to do with 25ee973 (gc: call\n> \"prune --expire 2.weeks.ago\" by default, 2008-03-12) by you.\n\nI think the nail in the coffin for --prune was a37cce3b, which preceded\n9e7d501. I guess the commit message for 9e7d501 made sense with a37cce3b\nas a reference. There was another commit around the same time which\nclaimed that --prune was deprecated even though it still provided some\nfunctionality, hence the \"...really has no effect\" part.\n\nI definitely remember that Johannes implemented the gc.pruneExpire\nfunctionality, so his \"That's news to me\" made me laugh. Thanks for\nthe chuckle Johannes. :)\n\n-brandon\n"},{"id":"97987","messageId":"FVglwe6MZJA2-0F8smd8RgHUYqc_tvsZE8KdwKzxQK3gqGN8-pvvhQ@cipher.nrlssc.navy.mil","threadId":"16715","inReplyTo":"20081214111939.GC6499@coredump.intra.peff.net","subject":"Re: [PATCH] bash completion: remove deprecated --prune from git-gc","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-12-15T18:06:17Z","receivedAt":"2008-12-15T18:06:17Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Jeff King wrote:\n> On Sun, Dec 14, 2008 at 12:17:07PM +0100, Johannes Schindelin wrote:\n> \n>>> Which annoyingly has no discussion about _why_ it no longer has an\n>>> effect. But I suspect it has something to do with 25ee973 (gc: call\n>>> \"prune --expire 2.weeks.ago\" by default, 2008-03-12) by you.\n>> Oops.\n>>\n>> But I thought that git gc --prune does expire _all_ dangling loose \n>> objects _now_, not with --expire 2.weeks.ago.\n> \n> Nope, see 25ee973. You explicitly wrote:\n> \n>       Note that this new behaviour makes \"--prune\" be a no-op.\n> \n> That being said, I think that is perhaps a reasonable thing for --prune\n> to do (and I don't think there is any conflict with the name, because\n> that is what it _used_ to do before becoming a no-op). But nobody has\n> actually implemented it.\n\nMaybe --mrproper would be a more appropriate name.\n\n-brandon\n"}]}