{"thread":{"id":"16693","subject":"[JGIT PATCH] Fix typos in comments / testcase output","startedAt":"2008-12-12T10:55:57Z","lastAt":"2008-12-12T15:30:25Z","messageCount":2,"participants":["Mike Ralphson","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"97689","messageId":"1229079357-19167-1-git-send-email-mike@abacus.co.uk","threadId":"16693","inReplyTo":null,"subject":"[JGIT PATCH] Fix typos in comments / testcase output","fromName":"Mike Ralphson","fromEmail":"mike@abacus.co.uk","sentAt":"2008-12-12T10:55:57Z","receivedAt":"2008-12-12T10:55:57Z","isPatch":true,"sender":{"key":"mike@abacus.co.uk","avatar":"https://gravatar.com/avatar/717865f1e9a9197ec082b9f6a12e048210a9da06878e47f165b470c43a9e9175?d=mp&s=160"},"body":"Signed-off-by: Mike Ralphson <mike@abacus.co.uk>\n---\n\nIs it me, or is the actual maintainer of JGIT/EGIT not actually\nmentioned anywhere? Apologies if I've got the to and cc round\nthe wrong way 8-)\n\nThis patch is the product of\nfind . -name \"*.java\" -type f -exec aspell --mode=ccpp -c {} \\;\n\nI would post my aspell wordlists but they're polluted by other\nprojects...\n\nPossibly also s/packes to/packs so/ in README?\n\n .../org/spearce/egit/core/GitMoveDeleteHook.java   |    2 +-\n .../org/spearce/jgit/lib/RepositoryTestCase.java   |    2 +-\n .../spearce/jgit/revwalk/RevCommitParseTest.java   |    2 +-\n .../spearce/jgit/transport/BundleWriterTest.java   |    2 +-\n .../spearce/jgit/transport/FetchConnection.java    |    2 +-\n 5 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java\nindex cc4059c..7faa65a 100644\n--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java\n+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java\n@@ -122,7 +122,7 @@ public boolean moveFolder(final IResourceTree tree, final IFolder source,\n \t\t\tfinal IFolder destination, final int updateFlags,\n \t\t\tfinal IProgressMonitor monitor) {\n \t\t// TODO: Implement this. Should be relatively easy, but consider that\n-\t\t// Eclipse thinks folders are real thinsgs, while Git does not care.\n+\t\t// Eclipse thinks folders are real things, while Git does not care.\n \t\treturn FINISH_FOR_ME;\n \t}\n \ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\nindex 8937145..9e48fde 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n@@ -94,7 +94,7 @@ protected void configure() {\n \n \t/**\n \t * Utility method to delete a directory recursively. It is\n-\t * also used internally. If a file or directory cannote be removed\n+\t * also used internally. If a file or directory cannot be removed\n \t * it throws an AssertionFailure.\n \t *\n \t * @param dir\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java\nindex 805e29e..9b95924 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java\n@@ -226,7 +226,7 @@ public void testParse_explicit_bad_encoded() throws Exception {\n \t *\n \t * What happens here is that an encoding us given, but data is not encoded\n \t * that way (and we can detect it), so we try other encodings. Here data could\n-\t * actually be decoded in the stated encoding, but we overide using UTF-8.\n+\t * actually be decoded in the stated encoding, but we override using UTF-8.\n \t *\n \t * @throws Exception\n \t */\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java\nindex 3cfb8b1..f13d25c 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java\n@@ -117,7 +117,7 @@ assertEquals(db.resolve(\"c\").name(), newRepo.resolve(\"refs/heads/cc\")\n \t\t\t// Check that we actually needed the first bundle\n \t\t\tRepository newRepo2 = createNewEmptyRepo();\n \t\t\tfetchResult = fetchFromBundle(newRepo2, bundle);\n-\t\t\tfail(\"We should not be able to fetch from bundle with prerequisistes that are not fulfilled\");\n+\t\t\tfail(\"We should not be able to fetch from bundle with prerequisites that are not fulfilled\");\n \t\t} catch (MissingBundlePrerequisiteException e) {\n \t\t\tassertTrue(e.getMessage()\n \t\t\t\t\t.indexOf(db.resolve(\"refs/heads/a\").name()) >= 0);\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java\nindex 461ad71..a56ca6c 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java\n@@ -126,7 +126,7 @@ public void fetch(final ProgressMonitor monitor, final Collection<Ref> want)\n \t * able to supply a fully connected graph to the client (although it may\n \t * only be transferring the parts the client does not yet have). Its faster\n \t * to assume such remote peers are well behaved and send the correct\n-\t * response to the client. In such tranports this method returns false.\n+\t * response to the client. In such transports this method returns false.\n \t *\n \t * @return true if the last fetch had to perform a connectivity check on the\n \t *         client side in order to succeed; false if the last fetch assumed\n-- \n1.6.0.2\n"},{"id":"97699","messageId":"20081212153025.GN32487@spearce.org","threadId":"16693","inReplyTo":"1229079357-19167-1-git-send-email-mike@abacus.co.uk","subject":"Re: [JGIT PATCH] Fix typos in comments / testcase output","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-12-12T15:30:25Z","receivedAt":"2008-12-12T15:30:25Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Mike Ralphson <mike@abacus.co.uk> wrote:\n> Signed-off-by: Mike Ralphson <mike@abacus.co.uk>\n\nThanks, I've applied this change, and the README correction you\nnoted but didn't send a patch for.  :-)\n\n> Is it me, or is the actual maintainer of JGIT/EGIT not actually\n> mentioned anywhere? Apologies if I've got the to and cc round\n> the wrong way 8-)\n\nRobin and I run JGit and EGit as a dual-maintainer approach.\nWe both have write access to the master repository and we apply\neach other's patches rather than push directly ourselves.  It\nhelps keep us from cutting corners.\n\nAlthough I just broke that rule by pushing my own patch to README\nand my own patch to SUBMITTING_PATCHES to address the other points\nyou raised, but these are two auxiliary documents that we don't\npay much attention to, hence they have fallen into disarray... :-\\\n\n-- \nShawn.\n"}]}