{"thread":{"id":"16621","subject":"Remove feature_grep in gitweb?","startedAt":"2008-12-07T05:22:30Z","lastAt":"2008-12-07T11:16:30Z","messageCount":4,"participants":["Matt Kraai","Jakub Narebski","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97293","messageId":"20081207052230.GD4357@ftbfs.org","threadId":"16621","inReplyTo":null,"subject":"Remove feature_grep in gitweb?","fromName":"Matt Kraai","fromEmail":"kraai@ftbfs.org","sentAt":"2008-12-07T05:22:30Z","receivedAt":"2008-12-07T05:22:30Z","isPatch":false,"sender":{"key":"kraai@ftbfs.org","avatar":null},"body":"Howdy,\n\nA feature_grep subroutine is defined in gitweb.perl, but unlike the\nother feature_* subroutines there, it doesn't appear to be used\nanywhere.  Should it be removed?\n\n-- \nMatt                                                 http://ftbfs.org/\n"},{"id":"97296","messageId":"20081207093447.25785.41811.stgit@localhost.localdomain","threadId":"16621","inReplyTo":"20081207052230.GD4357@ftbfs.org","subject":"[PATCH] gitweb: Make project specific override for 'grep' feature work","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-12-07T09:36:36Z","receivedAt":"2008-12-07T09:36:36Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"The 'grep' feature was marked in the comments as having project\nspecific config, but it lacked 'sub' key required for it to work.\n\nKind-of-Noticed-by: Matt Kraai <kraai@ftbfs.org>\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nMatt Kraai wrote:\n\n> A feature_grep subroutine is defined in gitweb.perl, but unlike the\n> other feature_* subroutines there, it doesn't appear to be used\n> anywhere.  Should it be removed?\n\nNo, it was oversight; it should be used in setting up 'grep' %feature\nconfiguration, see below.\n\nThanks for catching this.\n\n gitweb/gitweb.perl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 95988fb..9517392 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -241,6 +241,7 @@ our %feature = (\n \t# $feature{'grep'}{'override'} = 1;\n \t# and in project config gitweb.grep = 0|1;\n \t'grep' => {\n+\t\t'sub' => \\&feature_grep,\n \t\t'override' => 0,\n \t\t'default' => [1]},\n \n"},{"id":"97299","messageId":"7vljuscl4v.fsf@gitster.siamese.dyndns.org","threadId":"16621","inReplyTo":"20081207093447.25785.41811.stgit@localhost.localdomain","subject":"Re: [PATCH] gitweb: Make project specific override for 'grep' feature work","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-07T10:52:48Z","receivedAt":"2008-12-07T10:52:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both.  This should go to maint, right?\n"},{"id":"97300","messageId":"200812071216.31850.jnareb@gmail.com","threadId":"16621","inReplyTo":"7vljuscl4v.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: Make project specific override for 'grep' feature work","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-12-07T11:16:30Z","receivedAt":"2008-12-07T11:16:30Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sun, 7 Dec 2008, Junio C Hamano wrote:\n\n> Thanks, both.  This should go to maint, right?\n> \n\nYes, I think so.\n-- \nJakub Narebski\nPoland\n"}]}