{"thread":{"id":"16577","subject":"[BUG] git bisect visualize crash","startedAt":"2008-12-03T11:20:29Z","lastAt":"2008-12-04T15:59:21Z","messageCount":4,"participants":["Alejandro Riveira","Johannes Schindelin","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97049","messageId":"gh5q1t$qjn$1@ger.gmane.org","threadId":"16577","inReplyTo":null,"subject":"[BUG] git bisect visualize crash","fromName":"Alejandro Riveira","fromEmail":"ariveira@gmail.com","sentAt":"2008-12-03T11:20:29Z","receivedAt":"2008-12-03T11:20:29Z","isPatch":false,"sender":{"key":"ariveira@gmail.com","avatar":null},"body":"i'm using ubuntu 8.10 and git bisect visualize is crashing.\nNoticed when bisecting the kernel but it is easily reproducible\n\nin git repository as of today\n\n$ git bisect bad\n$ git bisect good HEAD~20\n\n$ git bisect visualize                                                                  (03-12 12:16)\nError in startup script: can't read \"notflag\": no such variable\n    while executing\n\"expr {!$notflag}\"\n    (\"--not\" arm line 2)\n    invoked from within\n\"switch -glob -- $arg {\n            \"-d\" -\n            \"--date-order\" {\n                set vdatemode($n) 1\n                # remove from origargs in case we hit an unknown option\n                set origarg...\"\n    (procedure \"parseviewargs\" line 21)\n    invoked from within\n\"parseviewargs $view $args\"\n    (procedure \"start_rev_list\" line 27)\n    invoked from within\n\"start_rev_list $curview\"\n    (procedure \"getcommits\" line 5)\n    invoked from within\n\"getcommits {}\"\n    (file \"/usr/local/bin/gitk\" line 10897)\n\n$ git --version\ngit version 1.6.1.rc1\n$\n"},{"id":"97144","messageId":"alpine.DEB.1.00.0812041532160.7045@racer","threadId":"16577","inReplyTo":"gh5q1t$qjn$1@ger.gmane.org","subject":"[PATCH] gitk: fix 'can't read \"notflag\"'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-04T14:34:15Z","receivedAt":"2008-12-04T14:34:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nSometimes, when calling git bisect visualize, parameters including\na \"--not\" are passed to gitk, triggering an uninitialized-variable bug\nintroduced in ee66e089(gitk: Make updates go faster).\n\nNoticed by Alejandro Riveira Fernández.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n\n\tOn Wed, 3 Dec 2008, Alejandro Riveira wrote:\n\n\t> $ git bisect visualize                                                                  (03-12 12:16)\n\t> Error in startup script: can't read \"notflag\": no such variable\n\n\tAlejandro was good enough to test this fix.\n\n gitk-git/gitk |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 3353f4a..b18bdf0 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {\n     set origargs $arglist\n     set allknown 1\n     set filtered 0\n+    set notflag 0\n     set i -1\n     foreach arg $arglist {\n \tincr i\n-- \n1.6.0.4.1189.g8876f\n"},{"id":"97146","messageId":"alpine.DEB.1.00.0812041609150.7045@racer","threadId":"16577","inReplyTo":"alpine.DEB.1.00.0812041532160.7045@racer","subject":"Re: [PATCH] gitk: fix 'can't read \"notflag\"'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-12-04T15:09:36Z","receivedAt":"2008-12-04T15:09:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 4 Dec 2008, Johannes Schindelin wrote:\n\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n\nD'oh.  Please apply with -p2.\n\nCiao,\nDscho\n"},{"id":"97148","messageId":"4937FE59.2030906@viscovery.net","threadId":"16577","inReplyTo":"alpine.DEB.1.00.0812041609150.7045@racer","subject":"Re: [PATCH] gitk: fix 'can't read \"notflag\"'","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-12-04T15:59:21Z","receivedAt":"2008-12-04T15:59:21Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Johannes Schindelin schrieb:\n> On Thu, 4 Dec 2008, Johannes Schindelin wrote:\n> \n>> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> \n> D'oh.  Please apply with -p2.\n\nNo; pull -s subtree before you write this patch ;) It's already fixed in\nupstream gitk.\n\n-- Hannes\n"}]}