{"thread":{"id":"16569","subject":"X-Debbugs-Cc didn't make it to git@vger.kernel.org","startedAt":"2008-12-03T01:32:30Z","lastAt":"2010-08-22T07:23:16Z","messageCount":10,"participants":["jidanni@jidanni.org","Jeff King","Jonathan Nieder","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97004","messageId":"87ej0qf3gx.fsf@jidanni.org","threadId":"16569","inReplyTo":null,"subject":"X-Debbugs-Cc didn't make it to git@vger.kernel.org","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-03T01:32:30Z","receivedAt":"2008-12-03T01:32:30Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Bummer, on\nhttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507475\nhttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476\nI used X-Debbugs-Cc, and it says Report forwarded to git@vger.kernel.org\nbut I don't see them here on nntp:gmane.comp.version-control.git .\nPerhaps they got filtered out?\n"},{"id":"97616","messageId":"87wse6zc9x.fsf@jidanni.org","threadId":"16569","inReplyTo":"87ej0qf3gx.fsf@jidanni.org","subject":"git-doc CSS dependent, breaks down in text browsers","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-11T20:29:14Z","receivedAt":"2008-12-11T20:29:14Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"E.g., pages look like\n\nSYNOPSIS\n\ngit-config [<file-option>] [type] [-z|--null] name [value [value_regex]] git-config [<file-option>] [type] --add name\nvalue git-config [<file-option>] [type] --replace-all name [value [value_regex]] git-config [<file-option>] [type] [-z|\n--null] --get name [value_regex] git-config [<file-option>] [type] [-z|--null] --get-all name [value_regex] git-config...\n\nPlease see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507475 ,\nwhich was supposed to be forwarded to git@vger.kernel.org but wasn't,\napparently.\n"},{"id":"97618","messageId":"87skouzc4w.fsf@jidanni.org","threadId":"16569","inReplyTo":"87ej0qf3gx.fsf@jidanni.org","subject":"user-manual.html invalid HTML","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-11T20:32:15Z","receivedAt":"2008-12-11T20:32:15Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":"Please see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476\nWhich it turns out didn't get forwarded to git@vger.kernel.org after all. \n"},{"id":"97658","messageId":"20081212023003.GD23128@sigill.intra.peff.net","threadId":"16569","inReplyTo":"87skouzc4w.fsf@jidanni.org","subject":"Re: user-manual.html invalid HTML","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-12-12T02:30:04Z","receivedAt":"2008-12-12T02:30:04Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Dec 12, 2008 at 04:32:15AM +0800, jidanni@jidanni.org wrote:\n\n> Please see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476\n> Which it turns out didn't get forwarded to git@vger.kernel.org after all. \n\nThe versions I build locally have:\n\n<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\"\n    \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n\nin each HTML file, which is added by asciidoc.  Maybe the package you\nare looking at was built with an older version of asciidoc that doesn't\ndo this (I don't actually know the history of this feature, but it seems\nto me that this is something asciidoc should be doing, not git).\n\n-Peff\n"},{"id":"97677","messageId":"87hc5ahzy8.fsf@jidanni.org","threadId":"16569","inReplyTo":"20081212023003.GD23128@sigill.intra.peff.net","subject":"Re: user-manual.html invalid HTML","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2008-12-12T02:47:27Z","receivedAt":"2008-12-12T02:47:27Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":">>>>> \"JK\" == Jeff King <peff@peff.net> writes:\n\nJK> On Fri, Dec 12, 2008 at 04:32:15AM +0800, jidanni@jidanni.org wrote:\n>> Please see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476\n>> Which it turns out didn't get forwarded to git@vger.kernel.org after all. \n\nJK> The versions I build locally have:\n\nJK> <!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\"\nJK>     \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n\nJK> in each HTML file, which is added by asciidoc.  Maybe the package you\nJK> are looking at was built with an older version of asciidoc that doesn't\nJK> do this (I don't actually know the history of this feature, but it seems\nJK> to me that this is something asciidoc should be doing, not git).\n\nJK> -Peff\n\nOK, adding 507476@bugs.debian.org to the CCs.\n"},{"id":"97681","messageId":"20081212033348.GA29663@coredump.intra.peff.net","threadId":"16569","inReplyTo":"87wse6zc9x.fsf@jidanni.org","subject":"Re: git-doc CSS dependent, breaks down in text browsers","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-12-12T03:33:48Z","receivedAt":"2008-12-12T03:33:48Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Dec 12, 2008 at 04:29:14AM +0800, jidanni@jidanni.org wrote:\n\n> E.g., pages look like\n> \n> SYNOPSIS\n> \n> git-config [<file-option>] [type] [-z|--null] name [value [value_regex]] git-config [<file-option>] [type] --add name\n> value git-config [<file-option>] [type] --replace-all name [value [value_regex]] git-config [<file-option>] [type] [-z|\n> --null] --get name [value_regex] git-config [<file-option>] [type] [-z|--null] --get-all name [value_regex] git-config...\n\nI think this is another asciidoc issue, as git merely specifies \"verse\"\nformat for this section. Probably the most friendly thing to do would be\nto use\n\n  <pre class=\"verseblock-content\">\n\ninstead of\n\n  <div class=\"verseblock-content\">\n\nso that non-CSS browsers fall back to preserving the line boundaries\n(which is what is making it look so unbearable in your text browser).\nBut it is definitely something to be fixed in asciidoc, not in the git\ndocumentation.\n\n-Peff\n"},{"id":"99735","messageId":"87ljtlk2sl.fsf@jidanni.org","threadId":"16569","inReplyTo":"87ej0qf3gx.fsf@jidanni.org","subject":"Re: X-Debbugs-Cc didn't make it to git@vger.kernel.org","fromName":"","fromEmail":"jidanni@jidanni.org","sentAt":"2009-01-08T19:36:58Z","receivedAt":"2009-01-08T19:36:58Z","isPatch":false,"sender":{"key":"jidanni@jidanni.org","avatar":"https://gravatar.com/avatar/36568d4af4c8d3e71627ef3b8c8d00e39065b12f29676cccd38ced75e68fa2a6?d=mp&s=160"},"body":">>>>> \"j\" == jidanni  <jidanni@jidanni.org> writes:\n\nj> Bummer, on\nj> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507475\nj> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476\nj> I used X-Debbugs-Cc, and it says Report forwarded to git@vger.kernel.org\nj> but I don't see them here on nntp:gmane.comp.version-control.git .\nj> Perhaps they got filtered out?\n\nWhy of course,\n$ git checkout origin/todo\n$ GET 'http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=2;mbox=yes;bug=507475'|./taboo.perl\n43 Delivered-To: submit@bugs.debian.org\nmatches /^[-\\w_]*:/ && m!Delivered-To:!\n\n# These are Majordomo's  global  majordomo.cf  as used at\n# vger.kernel.org.\n\nSo forget about any X-Debbugs-Cc reaching any kernel.org list.\n"},{"id":"148501","messageId":"20100820050401.GC25013@burratino","threadId":"16569","inReplyTo":"87hc5ahzy8.fsf@jidanni.org","subject":"Re: user-manual.html invalid HTML","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-08-20T05:04:02Z","receivedAt":"2010-08-20T05:04:02Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nSorry for the long silence.\n\nJeff King wrote:\n> On Fri, Dec 12, 2008 at 04:32:15AM +0800, jidanni@jidanni.org wrote:\n\n[user-manual.html lacks a !DOCTYPE declaration]\n> \n> The versions I build locally have:\n> \n> <!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\"\n>     \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n> \n> in each HTML file, which is added by asciidoc.  Maybe the package you\n> are looking at was built with an older version of asciidoc that doesn't\n> do this (I don't actually know the history of this feature, but it seems\n> to me that this is something asciidoc should be doing, not git).\n\nIt looks like the HTML for user-manual.html (unlike the reference\nmanual and other articles) is not generated by asciidoc after all;\ninstead, the rule in Documentation/Makefile uses xsltproc directly to\nconvert the asciidoc-generated XML to HTML.\n\nApparently the caller is supposed to set the\nchunker.output.doctype-public parameter.\nhttp://www.sagehill.net/docbookxsl/Chunking.html#OutputDoctype\n\nMaybe something as simple as this would work.\n\n-- 8< --\nSubject: Documentation: set a !DOCTYPE for user manual\n\nasciidoc already takes care of including a doctype for most of the\nHTML documentation, but the user manual which is processed with\ndocbook-xsl directly lacks one (at least with Debian docbook-xsl\n1.75.2+dfsg-5).  This makes it harder to automatically validate the\nHTML.\n\nReported-by: 積丹尼 <jidanni@jidanni.org>\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\ndiff --git a/Documentation/docbook.xsl b/Documentation/docbook.xsl\nindex 9a6912c..da8b05b 100644\n--- a/Documentation/docbook.xsl\n+++ b/Documentation/docbook.xsl\n@@ -1,5 +1,8 @@\n <xsl:stylesheet xmlns:xsl=\"http://www.w3.org/1999/XSL/Transform\"\n \t\tversion='1.0'>\n  <xsl:import href=\"http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl\"/>\n- <xsl:output method=\"html\" encoding=\"UTF-8\" indent=\"no\" />\n+ <xsl:output method=\"html\"\n+     encoding=\"UTF-8\" indent=\"no\"\n+     doctype-public=\"-//W3C//DTD HTML 4.01//EN\"\n+     doctype-system=\"http://www.w3.org/TR/html4/strict.dtd\" />\n </xsl:stylesheet>\n-- \n"},{"id":"148641","messageId":"20100821062122.GA28735@coredump.intra.peff.net","threadId":"16569","inReplyTo":"20100820050401.GC25013@burratino","subject":"Re: user-manual.html invalid HTML","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2010-08-21T06:21:22Z","receivedAt":"2010-08-21T06:21:22Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Aug 20, 2010 at 12:04:02AM -0500, Jonathan Nieder wrote:\n\n> > The versions I build locally have:\n> > \n> > <!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\"\n> >     \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n> > \n> > in each HTML file, which is added by asciidoc.  Maybe the package you\n> > are looking at was built with an older version of asciidoc that doesn't\n> > do this (I don't actually know the history of this feature, but it seems\n> > to me that this is something asciidoc should be doing, not git).\n> \n> It looks like the HTML for user-manual.html (unlike the reference\n> manual and other articles) is not generated by asciidoc after all;\n> instead, the rule in Documentation/Makefile uses xsltproc directly to\n> convert the asciidoc-generated XML to HTML.\n\nThanks for tracking this down.\n\n> Apparently the caller is supposed to set the\n> chunker.output.doctype-public parameter.\n> http://www.sagehill.net/docbookxsl/Chunking.html#OutputDoctype\n\nYour patch works fine for me, though I am using the exact same toolchain\nas you. I have no idea if older docbook's will work less well.\n\n> + <xsl:output method=\"html\"\n> +     encoding=\"UTF-8\" indent=\"no\"\n> +     doctype-public=\"-//W3C//DTD HTML 4.01//EN\"\n> +     doctype-system=\"http://www.w3.org/TR/html4/strict.dtd\" />\n\nMy asciidoc-generated pages are xhtml. We are using \"html/docbook.xsl\"\nfrom docbook, and now \"xhtml\", so probably some form of html is right.\nBut is html4 strict right? With nothing else to go on, it seems a good\nguess to me, but I'm wondering if you actually found the answer\nsomewhere.\n\nAlso, while testing your patch, I found and fixed the following buglet:\n\n-- >8 --\nSubject: [PATCH] docs: fix Makefile dependency for user manual\n\nWe use our custom xsl file to build the user manual, so make\nsure we depend on it. We don't use it anywhere else, so we\ncan stick it straight in the rule.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n Documentation/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex a4c4063..e117bc4 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -279,7 +279,7 @@ $(patsubst %,%.html,$(API_DOCS) technical/api-index): %.html : %.txt\n XSLT = docbook.xsl\n XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css\n \n-user-manual.html: user-manual.xml\n+user-manual.html: user-manual.xml $(XSLT)\n \t$(QUIET_XSLTPROC)$(RM) $@+ $@ && \\\n \txsltproc $(XSLTOPTS) -o $@+ $(XSLT) $< && \\\n \tmv $@+ $@\n-- \n1.7.2.2.350.g9c7e\n"},{"id":"148699","messageId":"7vvd735cwr.fsf@alter.siamese.dyndns.org","threadId":"16569","inReplyTo":"20100821062122.GA28735@coredump.intra.peff.net","subject":"Re: user-manual.html invalid HTML","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-08-22T07:23:16Z","receivedAt":"2010-08-22T07:23:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> Subject: [PATCH] docs: fix Makefile dependency for user manual\n\nThanks.\n"}]}