{"thread":{"id":"16565","subject":"[PATCH] gitk: Use check-buttons' -text property instead of separate labels","startedAt":"2008-12-02T20:42:16Z","lastAt":"2008-12-18T10:41:36Z","messageCount":2,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"96982","messageId":"200812022142.16095.j6t@kdbg.org","threadId":"16565","inReplyTo":null,"subject":"[PATCH] gitk: Use check-buttons' -text property instead of separate labels","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2008-12-02T20:42:16Z","receivedAt":"2008-12-02T20:42:16Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Previously the check-buttons' labels in the Preferences were separate\nwidgets. This had the disadvantage that in order to toggle the check-button\nwith the mouse the check-box had to be clicked. With this change the\ncheck-box can also be toggled by clicking the label.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n gitk |   30 ++++++++++--------------------\n 1 files changed, 10 insertions(+), 20 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 64a873d..ee1941c 100755\n--- a/gitk\n+++ b/gitk\n@@ -10079,15 +10079,11 @@ proc doprefs {} {\n \t-font optionfont\n     spinbox $top.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct\n     grid x $top.maxpctl $top.maxpct -sticky w\n-    frame $top.showlocal\n-    label $top.showlocal.l -text [mc \"Show local changes\"] -font optionfont\n-    checkbutton $top.showlocal.b -variable showlocalchanges\n-    pack $top.showlocal.b $top.showlocal.l -side left\n+    checkbutton $top.showlocal -text [mc \"Show local changes\"] \\\n+\t-font optionfont -variable showlocalchanges\n     grid x $top.showlocal -sticky w\n-    frame $top.autoselect\n-    label $top.autoselect.l -text [mc \"Auto-select SHA1\"] -font optionfont\n-    checkbutton $top.autoselect.b -variable autoselect\n-    pack $top.autoselect.b $top.autoselect.l -side left\n+    checkbutton $top.autoselect -text [mc \"Auto-select SHA1\"] \\\n+\t-font optionfont -variable autoselect\n     grid x $top.autoselect -sticky w\n \n     label $top.ddisp -text [mc \"Diff display options\"]\n@@ -10095,20 +10091,14 @@ proc doprefs {} {\n     label $top.tabstopl -text [mc \"Tab spacing\"] -font optionfont\n     spinbox $top.tabstop -from 1 -to 20 -width 4 -textvariable tabstop\n     grid x $top.tabstopl $top.tabstop -sticky w\n-    frame $top.ntag\n-    label $top.ntag.l -text [mc \"Display nearby tags\"] -font optionfont\n-    checkbutton $top.ntag.b -variable showneartags\n-    pack $top.ntag.b $top.ntag.l -side left\n+    checkbutton $top.ntag -text [mc \"Display nearby tags\"] \\\n+\t-font optionfont -variable showneartags\n     grid x $top.ntag -sticky w\n-    frame $top.ldiff\n-    label $top.ldiff.l -text [mc \"Limit diffs to listed paths\"] -font optionfont\n-    checkbutton $top.ldiff.b -variable limitdiffs\n-    pack $top.ldiff.b $top.ldiff.l -side left\n+    checkbutton $top.ldiff -text [mc \"Limit diffs to listed paths\"] \\\n+\t-font optionfont -variable limitdiffs\n     grid x $top.ldiff -sticky w\n-    frame $top.lattr\n-    label $top.lattr.l -text [mc \"Support per-file encodings\"] -font optionfont\n-    checkbutton $top.lattr.b -variable perfile_attrs\n-    pack $top.lattr.b $top.lattr.l -side left\n+    checkbutton $top.lattr -text [mc \"Support per-file encodings\"] \\\n+\t-font optionfont -variable perfile_attrs\n     grid x $top.lattr -sticky w\n \n     entry $top.extdifft -textvariable extdifftool\n-- \n1.6.0.4.763.g42102\n"},{"id":"98243","messageId":"494A28E0.2010009@viscovery.net","threadId":"16565","inReplyTo":"200812022142.16095.j6t@kdbg.org","subject":"Re: [PATCH] gitk: Use check-buttons' -text property instead of separate labels","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-12-18T10:41:36Z","receivedAt":"2008-12-18T10:41:36Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Johannes Sixt schrieb:\n> Previously the check-buttons' labels in the Preferences were separate\n> widgets. This had the disadvantage that in order to toggle the check-button\n> with the mouse the check-box had to be clicked. With this change the\n> check-box can also be toggled by clicking the label.\n\nDid you consider this patch?\n\n-- Hannes\n\n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n> ---\n>  gitk |   30 ++++++++++--------------------\n>  1 files changed, 10 insertions(+), 20 deletions(-)\n> \n> diff --git a/gitk b/gitk\n> index 64a873d..ee1941c 100755\n> --- a/gitk\n> +++ b/gitk\n> @@ -10079,15 +10079,11 @@ proc doprefs {} {\n>  \t-font optionfont\n>      spinbox $top.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct\n>      grid x $top.maxpctl $top.maxpct -sticky w\n> -    frame $top.showlocal\n> -    label $top.showlocal.l -text [mc \"Show local changes\"] -font optionfont\n> -    checkbutton $top.showlocal.b -variable showlocalchanges\n> -    pack $top.showlocal.b $top.showlocal.l -side left\n> +    checkbutton $top.showlocal -text [mc \"Show local changes\"] \\\n> +\t-font optionfont -variable showlocalchanges\n>      grid x $top.showlocal -sticky w\n> -    frame $top.autoselect\n> -    label $top.autoselect.l -text [mc \"Auto-select SHA1\"] -font optionfont\n> -    checkbutton $top.autoselect.b -variable autoselect\n> -    pack $top.autoselect.b $top.autoselect.l -side left\n> +    checkbutton $top.autoselect -text [mc \"Auto-select SHA1\"] \\\n> +\t-font optionfont -variable autoselect\n>      grid x $top.autoselect -sticky w\n>  \n>      label $top.ddisp -text [mc \"Diff display options\"]\n> @@ -10095,20 +10091,14 @@ proc doprefs {} {\n>      label $top.tabstopl -text [mc \"Tab spacing\"] -font optionfont\n>      spinbox $top.tabstop -from 1 -to 20 -width 4 -textvariable tabstop\n>      grid x $top.tabstopl $top.tabstop -sticky w\n> -    frame $top.ntag\n> -    label $top.ntag.l -text [mc \"Display nearby tags\"] -font optionfont\n> -    checkbutton $top.ntag.b -variable showneartags\n> -    pack $top.ntag.b $top.ntag.l -side left\n> +    checkbutton $top.ntag -text [mc \"Display nearby tags\"] \\\n> +\t-font optionfont -variable showneartags\n>      grid x $top.ntag -sticky w\n> -    frame $top.ldiff\n> -    label $top.ldiff.l -text [mc \"Limit diffs to listed paths\"] -font optionfont\n> -    checkbutton $top.ldiff.b -variable limitdiffs\n> -    pack $top.ldiff.b $top.ldiff.l -side left\n> +    checkbutton $top.ldiff -text [mc \"Limit diffs to listed paths\"] \\\n> +\t-font optionfont -variable limitdiffs\n>      grid x $top.ldiff -sticky w\n> -    frame $top.lattr\n> -    label $top.lattr.l -text [mc \"Support per-file encodings\"] -font optionfont\n> -    checkbutton $top.lattr.b -variable perfile_attrs\n> -    pack $top.lattr.b $top.lattr.l -side left\n> +    checkbutton $top.lattr -text [mc \"Support per-file encodings\"] \\\n> +\t-font optionfont -variable perfile_attrs\n>      grid x $top.lattr -sticky w\n>  \n>      entry $top.extdifft -textvariable extdifftool\n\n\n-- \nDI Johannes Sixt\nLeiter Softwareentwicklung\nViscovery Software GmbH\nLandstrasse 11\nA-4020 Linz, Austria\n\nT: +43-1-532 0570-51\nM: +43-676-8494 9571\nF: +43-1-532 0570-33\nj.sixt@viscovery.net\nwww.viscovery.net\n\nt u r n   y o u r   d a t a   i n t o   r e a l   v a l u e !\n"}]}