{"thread":{"id":"16546","subject":"[PATCH] git-stash: use git rev-parse -q","startedAt":"2008-12-02T00:56:09Z","lastAt":"2008-12-08T08:46:53Z","messageCount":4,"participants":["Miklos Vajna","Björn Steinbrink","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"96892","messageId":"1228179369-3766-1-git-send-email-vmiklos@frugalware.org","threadId":"16546","inReplyTo":null,"subject":"[PATCH] git-stash: use git rev-parse -q","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-02T00:56:09Z","receivedAt":"2008-12-02T00:56:09Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Don't redirect stderr to /dev/null, use -q to suppress the output on\nstderr.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n git-stash.sh |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex b9ace99..c0532e8 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -30,7 +30,7 @@ clear_stash () {\n \tthen\n \t\tdie \"git stash clear with parameters is unimplemented\"\n \tfi\n-\tif current=$(git rev-parse --verify $ref_stash 2>/dev/null)\n+\tif current=$(git rev-parse -q --verify $ref_stash)\n \tthen\n \t\tgit update-ref -d $ref_stash $current\n \tfi\n@@ -129,7 +129,7 @@ save_stash () {\n }\n \n have_stash () {\n-\tgit rev-parse --verify $ref_stash >/dev/null 2>&1\n+\tgit rev-parse -q --verify $ref_stash >/dev/null\n }\n \n list_stash () {\n@@ -229,16 +229,16 @@ drop_stash () {\n \tfi\n \t# Verify supplied argument looks like a stash entry\n \ts=$(git rev-parse --verify \"$@\") &&\n-\tgit rev-parse --verify \"$s:\"   > /dev/null 2>&1 &&\n-\tgit rev-parse --verify \"$s^1:\" > /dev/null 2>&1 &&\n-\tgit rev-parse --verify \"$s^2:\" > /dev/null 2>&1 ||\n+\tgit rev-parse -q --verify \"$s:\"   > /dev/null &&\n+\tgit rev-parse -q --verify \"$s^1:\" > /dev/null &&\n+\tgit rev-parse -q --verify \"$s^2:\" > /dev/null ||\n \t\tdie \"$*: not a valid stashed state\"\n \n \tgit reflog delete --updateref --rewrite \"$@\" &&\n \t\techo \"Dropped $* ($s)\" || die \"$*: Could not drop stash entry\"\n \n \t# clear_stash if we just dropped the last stash entry\n-\tgit rev-parse --verify \"$ref_stash@{0}\" > /dev/null 2>&1 || clear_stash\n+\tgit rev-parse -q --verify \"$ref_stash@{0}\" > /dev/null || clear_stash\n }\n \n apply_to_branch () {\n-- \n1.6.0.4\n"},{"id":"97315","messageId":"20081207231723.GA5068@atjola.homenet","threadId":"16546","inReplyTo":"1228179369-3766-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] git-stash: use git rev-parse -q","fromName":"Björn Steinbrink","fromEmail":"b.steinbrink@gmx.de","sentAt":"2008-12-07T23:17:23Z","receivedAt":"2008-12-07T23:17:23Z","isPatch":true,"sender":{"key":"b.steinbrink@gmx.de","avatar":"https://avatars.githubusercontent.com/u/230962?v=4"},"body":"On 2008.12.02 01:56:09 +0100, Miklos Vajna wrote:\n> Don't redirect stderr to /dev/null, use -q to suppress the output on\n> stderr.\n> \n> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>\n> ---\n>  \n>  \t# clear_stash if we just dropped the last stash entry\n> -\tgit rev-parse --verify \"$ref_stash@{0}\" > /dev/null 2>&1 || clear_stash\n> +\tgit rev-parse -q --verify \"$ref_stash@{0}\" > /dev/null || clear_stash\n\nThis one causes an error message to pop up when the last stash entry is\ndropped:\n\ndoener@atjola:git (master) $ echo 123 >> Makefile\n\ndoener@atjola:git (master) $ git stash\nSaved working directory and index state \"WIP on master: 2dd6202...\nUpdate draft release notes to 1.6.1\"\nHEAD is now at 2dd6202 Update draft release notes to 1.6.1\n(To restore them type \"git stash apply\")\n\ndoener@atjola:git (master) $ git stash drop\nDropped refs/stash@{0} (e692e43ce03fe0b5f0eb94123123ea61a0f2097a)\nfatal: Log .git/logs/refs/stash is empty.\n\ngit version 1.6.1.rc1.56.g2dd62\n\nAfter \"git stash drop\" finished the rev-parse won't complain anymore,\neven if you recreate an empty .git/logs/refs/stash file, because\n.git/refs/stash is also gone, and then it doesn't seem to care anymore.\n\nBut having a valid ref and an empty log makes it unhappy:\n\ndoener@atjola:git (master) $ git rev-parse HEAD > .git/refs/stash\ndoener@atjola:git (master) $ : > .git/logs/refs/stash\ndoener@atjola:git (master) $ git rev-parse -q --verify 'refs/stash@{1}'\nfatal: Log .git/logs/refs/stash is empty.\n\nBjörn\n"},{"id":"97318","messageId":"7vhc5fcui1.fsf@gitster.siamese.dyndns.org","threadId":"16546","inReplyTo":"20081207231723.GA5068@atjola.homenet","subject":"Re: [PATCH] git-stash: use git rev-parse -q","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-08T01:42:46Z","receivedAt":"2008-12-08T01:42:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; I'll revert this one.  Use of -q is simply not worth this\naggravation.\n"},{"id":"97341","messageId":"20081208084653.GR5691@genesis.frugalware.org","threadId":"16546","inReplyTo":"7vhc5fcui1.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] git-stash: use git rev-parse -q","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-12-08T08:46:53Z","receivedAt":"2008-12-08T08:46:53Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sun, Dec 07, 2008 at 05:42:46PM -0800, Junio C Hamano <gitster@pobox.com> wrote:\n> Thanks; I'll revert this one.  Use of -q is simply not worth this\n> aggravation.\n\nSorry, I missed that 2>/dev/null is used for this purpose there as well. \n"}]}