{"thread":{"id":"16544","subject":"[PATCH (GITK) v2] gitk: Make line origin search update the busy status.","startedAt":"2008-12-01T17:30:09Z","lastAt":"2008-12-01T17:30:09Z","messageCount":1,"participants":["Alexander Gavrilov"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"96876","messageId":"200812012030.09114.angavrilov@gmail.com","threadId":"16544","inReplyTo":null,"subject":"[PATCH (GITK) v2] gitk: Make line origin search update the busy status.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-12-01T17:30:09Z","receivedAt":"2008-12-01T17:30:09Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"Currently the 'show origin of this line' feature does\nnot update the status field of the gitk window, so it\nis not evident that any processing is going on. It may\nseem at first that clicking the item had no effect.\n\nThis commit adds calls to set and clear the busy\nstatus with an appropriate title, similar to other\nsearch commands.\n\nSigned-off-by: Alexander Gavrilov <angavrilov@gmail.com>\n---\n\n\tI changed the visible message to Searching.\n\n\tI think that this is something of a usability bug, so this\n\tprobably should still go in 1.6.1.\n\n\tAlexander\n\n gitk |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 6eaeadf..076f036 100755\n--- a/gitk\n+++ b/gitk\n@@ -3407,6 +3407,7 @@ proc show_line_source {} {\n \terror_popup [mc \"Couldn't start git blame: %s\" $err]\n \treturn\n     }\n+    nowbusy blaming [mc \"Searching\"]\n     fconfigure $f -blocking 0\n     set i [reg_instance $f]\n     set blamestuff($i) {}\n@@ -3420,6 +3421,7 @@ proc stopblaming {} {\n     if {[info exists blameinst]} {\n \tstop_instance $blameinst\n \tunset blameinst\n+\tnotbusy blaming\n     }\n }\n \n@@ -3434,6 +3436,7 @@ proc read_line_source {fd inst} {\n     }\n     unset commfd($inst)\n     unset blameinst\n+    notbusy blaming\n     fconfigure $fd -blocking 1\n     if {[catch {close $fd} err]} {\n \terror_popup [mc \"Error running git blame: %s\" $err]\n-- \n1.6.0.4.30.gf4240\n"}]}