{"thread":{"id":"16500","subject":"[PATCH] bash: offer refs instead of filenames for 'git revert'","startedAt":"2008-11-27T13:35:53Z","lastAt":"2008-11-27T21:30:12Z","messageCount":2,"participants":["SZEDER Gábor","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"96622","messageId":"1227792953-4095-1-git-send-email-szeder@ira.uka.de","threadId":"16500","inReplyTo":null,"subject":"[PATCH] bash: offer refs instead of filenames for 'git revert'","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2008-11-27T13:35:53Z","receivedAt":"2008-11-27T13:35:53Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"The completion script for 'git revert' currently offers options and\nfilenames.  However, 'git revert' doesn't take any filenames from the\ncommand line, but a single commit.  Therefore, it's more sane to offer\nrefs instead.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 39bf18b..7e668d5 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1348,7 +1348,7 @@ _git_revert ()\n \t\treturn\n \t\t;;\n \tesac\n-\tCOMPREPLY=()\n+\t__gitcomp \"$(__git_refs)\"\n }\n \n _git_rm ()\n-- \n1.6.0.4.814.gfe502\n"},{"id":"96650","messageId":"20081127213012.GC23984@spearce.org","threadId":"16500","inReplyTo":"1227792953-4095-1-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH] bash: offer refs instead of filenames for 'git revert'","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-11-27T21:30:12Z","receivedAt":"2008-11-27T21:30:12Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"SZEDER GGGbor <szeder@ira.uka.de> wrote:\n> The completion script for 'git revert' currently offers options and\n> filenames.  However, 'git revert' doesn't take any filenames from the\n> command line, but a single commit.  Therefore, it's more sane to offer\n> refs instead.\n> \n> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>\n\nOh, good catch.\n\nAcked-by: Shawn O. Pearce <spearce@spearce.org>\n\n> ---\n>  contrib/completion/git-completion.bash |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 39bf18b..7e668d5 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1348,7 +1348,7 @@ _git_revert ()\n>  \t\treturn\n>  \t\t;;\n>  \tesac\n> -\tCOMPREPLY=()\n> +\t__gitcomp \"$(__git_refs)\"\n>  }\n>  \n>  _git_rm ()\n> -- \n> 1.6.0.4.814.gfe502\n> \n\n-- \nShawn.\n"}]}